| Message ID | 20170620205015.hfmwqcwqyqcw4mgz@ubuntu-xps13 |
|---|---|
| State | New |
| Headers | show |
On 20.06.2017 22:50, Seth Forshee wrote: > BugLink: http://bugs.launchpad.net/bugs/1689980 > > This series updates the aacraid driver in zesty with commits from > upstream and from linux-next to bring it up to version 50834 of the > driver. Almost all the patches address issues found on Power 8 and Power > 9 systems, and aside from a patch which fixes some typos all changes are > limited to the aacraid driver. Microsemi has done regression testing of > the driver updates on other architectures as well. > > Thanks, > Seth > > > The following changes since commit ab1f739cb13986bcfc4875c15dc0161935d7f004: > > UBUNTU: Ubuntu-4.10.0-25.29 (2017-06-20 16:40:58 +0200) > > are available in the git repository at: > > git://git.launchpad.net/~sforshee/+git/ubuntu-zesty aacraid > > for you to fetch changes up to b5d62a3c0f089690a9ba84c6a6cbabec94a6f822: > > scsi: aacraid: Update driver version to 50834 (2017-06-20 10:27:51 -0500) > > ---------------------------------------------------------------- > Guilherme G. Piccoli (1): > scsi: aacraid: fix PCI error recovery path > > Mahesh Rajashekhara (1): > scsi: aacraid: pci_alloc_consistent() failures on ARM64 > > Masahiro Yamada (1): > scripts/spelling.txt: add "therfore" pattern and fix typo instances > > Raghava Aditya Renukunta (19): > scsi: aacraid: Remove __GFP_DMA for raw srb memory > scsi: aacraid: Fix DMAR issues with iommu=pt > scsi: aacraid: Added 32 and 64 queue depth for arc natives > scsi: aacraid: Set correct Queue Depth for HBA1000 RAW disks > scsi: aacraid: Remove reset support from check_health > scsi: aacraid: Change wait time for fib completion > scsi: aacraid: Log count info of scsi cmds before reset > scsi: aacraid: Print ctrl status before eh reset > scsi: aacraid: Using single reset mask for IOP reset > scsi: aacraid: Rework IOP reset > scsi: aacraid: Add periodic checks to see IOP reset status > scsi: aacraid: Rework SOFT reset code > scsi: aacraid: Rework aac_src_restart > scsi: aacraid: Use correct function to get ctrl health > scsi: aacraid: Make sure ioctl returns on controller reset > scsi: aacraid: Enable ctrl reset for both hba and arc > scsi: aacraid: Add reset debugging statements > scsi: aacraid: Remove reference to Series-9 > scsi: aacraid: Update driver version to 50834 > > drivers/infiniband/sw/rdmavt/mad.c | 6 +- > drivers/scsi/aacraid/aachba.c | 30 +-- > drivers/scsi/aacraid/aacraid.h | 33 ++- > drivers/scsi/aacraid/commctrl.c | 21 +- > drivers/scsi/aacraid/comminit.c | 21 +- > drivers/scsi/aacraid/commsup.c | 101 ++++----- > drivers/scsi/aacraid/linit.c | 242 +++++++++++++-------- > drivers/scsi/aacraid/rx.c | 16 +- > drivers/scsi/aacraid/src.c | 136 +++++++----- > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 +- That mad.c and vchiq_arm.c modifications feel a bit out of place wrt the claim of only touching the aacraid driver. -Stefan > scripts/spelling.txt | 1 + > 11 files changed, 350 insertions(+), 261 deletions(-) >
On Wed, Jun 21, 2017 at 10:25:13AM +0200, Stefan Bader wrote: > On 20.06.2017 22:50, Seth Forshee wrote: > > BugLink: http://bugs.launchpad.net/bugs/1689980 > > > > This series updates the aacraid driver in zesty with commits from > > upstream and from linux-next to bring it up to version 50834 of the > > driver. Almost all the patches address issues found on Power 8 and Power > > 9 systems, and aside from a patch which fixes some typos all changes are > > limited to the aacraid driver. Microsemi has done regression testing of > > the driver updates on other architectures as well. > > > > Thanks, > > Seth > > > > > > The following changes since commit ab1f739cb13986bcfc4875c15dc0161935d7f004: > > > > UBUNTU: Ubuntu-4.10.0-25.29 (2017-06-20 16:40:58 +0200) > > > > are available in the git repository at: > > > > git://git.launchpad.net/~sforshee/+git/ubuntu-zesty aacraid > > > > for you to fetch changes up to b5d62a3c0f089690a9ba84c6a6cbabec94a6f822: > > > > scsi: aacraid: Update driver version to 50834 (2017-06-20 10:27:51 -0500) > > > > ---------------------------------------------------------------- > > Guilherme G. Piccoli (1): > > scsi: aacraid: fix PCI error recovery path > > > > Mahesh Rajashekhara (1): > > scsi: aacraid: pci_alloc_consistent() failures on ARM64 > > > > Masahiro Yamada (1): > > scripts/spelling.txt: add "therfore" pattern and fix typo instances > > > > Raghava Aditya Renukunta (19): > > scsi: aacraid: Remove __GFP_DMA for raw srb memory > > scsi: aacraid: Fix DMAR issues with iommu=pt > > scsi: aacraid: Added 32 and 64 queue depth for arc natives > > scsi: aacraid: Set correct Queue Depth for HBA1000 RAW disks > > scsi: aacraid: Remove reset support from check_health > > scsi: aacraid: Change wait time for fib completion > > scsi: aacraid: Log count info of scsi cmds before reset > > scsi: aacraid: Print ctrl status before eh reset > > scsi: aacraid: Using single reset mask for IOP reset > > scsi: aacraid: Rework IOP reset > > scsi: aacraid: Add periodic checks to see IOP reset status > > scsi: aacraid: Rework SOFT reset code > > scsi: aacraid: Rework aac_src_restart > > scsi: aacraid: Use correct function to get ctrl health > > scsi: aacraid: Make sure ioctl returns on controller reset > > scsi: aacraid: Enable ctrl reset for both hba and arc > > scsi: aacraid: Add reset debugging statements > > scsi: aacraid: Remove reference to Series-9 > > scsi: aacraid: Update driver version to 50834 > > > > drivers/infiniband/sw/rdmavt/mad.c | 6 +- > > drivers/scsi/aacraid/aachba.c | 30 +-- > > drivers/scsi/aacraid/aacraid.h | 33 ++- > > drivers/scsi/aacraid/commctrl.c | 21 +- > > drivers/scsi/aacraid/comminit.c | 21 +- > > drivers/scsi/aacraid/commsup.c | 101 ++++----- > > drivers/scsi/aacraid/linit.c | 242 +++++++++++++-------- > > drivers/scsi/aacraid/rx.c | 16 +- > > drivers/scsi/aacraid/src.c | 136 +++++++----- > > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 +- > > That mad.c and vchiq_arm.c modifications feel a bit out of place wrt the claim > of only touching the aacraid driver. Note that I said that they're limited to the aacraid driver "aside from a patch which fixes some typos." The changes to those files are only in comments. But that patch could safely be skipped too, possibly there would be some trivial context adjustments needed for later patches, not sure. Seth
On 21.06.2017 13:46, Seth Forshee wrote: > On Wed, Jun 21, 2017 at 10:25:13AM +0200, Stefan Bader wrote: >> On 20.06.2017 22:50, Seth Forshee wrote: >>> BugLink: http://bugs.launchpad.net/bugs/1689980 >>> >>> This series updates the aacraid driver in zesty with commits from >>> upstream and from linux-next to bring it up to version 50834 of the >>> driver. Almost all the patches address issues found on Power 8 and Power >>> 9 systems, and aside from a patch which fixes some typos all changes are >>> limited to the aacraid driver. Microsemi has done regression testing of >>> the driver updates on other architectures as well. >>> >>> Thanks, >>> Seth >>> >>> >>> The following changes since commit ab1f739cb13986bcfc4875c15dc0161935d7f004: >>> >>> UBUNTU: Ubuntu-4.10.0-25.29 (2017-06-20 16:40:58 +0200) >>> >>> are available in the git repository at: >>> >>> git://git.launchpad.net/~sforshee/+git/ubuntu-zesty aacraid >>> >>> for you to fetch changes up to b5d62a3c0f089690a9ba84c6a6cbabec94a6f822: >>> >>> scsi: aacraid: Update driver version to 50834 (2017-06-20 10:27:51 -0500) >>> >>> ---------------------------------------------------------------- >>> Guilherme G. Piccoli (1): >>> scsi: aacraid: fix PCI error recovery path >>> >>> Mahesh Rajashekhara (1): >>> scsi: aacraid: pci_alloc_consistent() failures on ARM64 >>> >>> Masahiro Yamada (1): >>> scripts/spelling.txt: add "therfore" pattern and fix typo instances >>> >>> Raghava Aditya Renukunta (19): >>> scsi: aacraid: Remove __GFP_DMA for raw srb memory >>> scsi: aacraid: Fix DMAR issues with iommu=pt >>> scsi: aacraid: Added 32 and 64 queue depth for arc natives >>> scsi: aacraid: Set correct Queue Depth for HBA1000 RAW disks >>> scsi: aacraid: Remove reset support from check_health >>> scsi: aacraid: Change wait time for fib completion >>> scsi: aacraid: Log count info of scsi cmds before reset >>> scsi: aacraid: Print ctrl status before eh reset >>> scsi: aacraid: Using single reset mask for IOP reset >>> scsi: aacraid: Rework IOP reset >>> scsi: aacraid: Add periodic checks to see IOP reset status >>> scsi: aacraid: Rework SOFT reset code >>> scsi: aacraid: Rework aac_src_restart >>> scsi: aacraid: Use correct function to get ctrl health >>> scsi: aacraid: Make sure ioctl returns on controller reset >>> scsi: aacraid: Enable ctrl reset for both hba and arc >>> scsi: aacraid: Add reset debugging statements >>> scsi: aacraid: Remove reference to Series-9 >>> scsi: aacraid: Update driver version to 50834 >>> >>> drivers/infiniband/sw/rdmavt/mad.c | 6 +- >>> drivers/scsi/aacraid/aachba.c | 30 +-- >>> drivers/scsi/aacraid/aacraid.h | 33 ++- >>> drivers/scsi/aacraid/commctrl.c | 21 +- >>> drivers/scsi/aacraid/comminit.c | 21 +- >>> drivers/scsi/aacraid/commsup.c | 101 ++++----- >>> drivers/scsi/aacraid/linit.c | 242 +++++++++++++-------- >>> drivers/scsi/aacraid/rx.c | 16 +- >>> drivers/scsi/aacraid/src.c | 136 +++++++----- >>> .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 +- >> >> That mad.c and vchiq_arm.c modifications feel a bit out of place wrt the claim >> of only touching the aacraid driver. > > Note that I said that they're limited to the aacraid driver "aside from > a patch which fixes some typos." The changes to those files are only in > comments. But that patch could safely be skipped too, possibly there > would be some trivial context adjustments needed for later patches, not > sure. Duh! Yeah you mentioned that. Sorry. > > Seth >
On 20.06.2017 22:50, Seth Forshee wrote: > BugLink: http://bugs.launchpad.net/bugs/1689980 > > This series updates the aacraid driver in zesty with commits from > upstream and from linux-next to bring it up to version 50834 of the > driver. Almost all the patches address issues found on Power 8 and Power > 9 systems, and aside from a patch which fixes some typos all changes are > limited to the aacraid driver. Microsemi has done regression testing of > the driver updates on other architectures as well. Acked-by: Stefan Bader <stefan.bader@canonical.com> > > Thanks, > Seth > > > The following changes since commit ab1f739cb13986bcfc4875c15dc0161935d7f004: > > UBUNTU: Ubuntu-4.10.0-25.29 (2017-06-20 16:40:58 +0200) > > are available in the git repository at: > > git://git.launchpad.net/~sforshee/+git/ubuntu-zesty aacraid > > for you to fetch changes up to b5d62a3c0f089690a9ba84c6a6cbabec94a6f822: > > scsi: aacraid: Update driver version to 50834 (2017-06-20 10:27:51 -0500) > > ---------------------------------------------------------------- > Guilherme G. Piccoli (1): > scsi: aacraid: fix PCI error recovery path > > Mahesh Rajashekhara (1): > scsi: aacraid: pci_alloc_consistent() failures on ARM64 > > Masahiro Yamada (1): > scripts/spelling.txt: add "therfore" pattern and fix typo instances > > Raghava Aditya Renukunta (19): > scsi: aacraid: Remove __GFP_DMA for raw srb memory > scsi: aacraid: Fix DMAR issues with iommu=pt > scsi: aacraid: Added 32 and 64 queue depth for arc natives > scsi: aacraid: Set correct Queue Depth for HBA1000 RAW disks > scsi: aacraid: Remove reset support from check_health > scsi: aacraid: Change wait time for fib completion > scsi: aacraid: Log count info of scsi cmds before reset > scsi: aacraid: Print ctrl status before eh reset > scsi: aacraid: Using single reset mask for IOP reset > scsi: aacraid: Rework IOP reset > scsi: aacraid: Add periodic checks to see IOP reset status > scsi: aacraid: Rework SOFT reset code > scsi: aacraid: Rework aac_src_restart > scsi: aacraid: Use correct function to get ctrl health > scsi: aacraid: Make sure ioctl returns on controller reset > scsi: aacraid: Enable ctrl reset for both hba and arc > scsi: aacraid: Add reset debugging statements > scsi: aacraid: Remove reference to Series-9 > scsi: aacraid: Update driver version to 50834 > > drivers/infiniband/sw/rdmavt/mad.c | 6 +- > drivers/scsi/aacraid/aachba.c | 30 +-- > drivers/scsi/aacraid/aacraid.h | 33 ++- > drivers/scsi/aacraid/commctrl.c | 21 +- > drivers/scsi/aacraid/comminit.c | 21 +- > drivers/scsi/aacraid/commsup.c | 101 ++++----- > drivers/scsi/aacraid/linit.c | 242 +++++++++++++-------- > drivers/scsi/aacraid/rx.c | 16 +- > drivers/scsi/aacraid/src.c | 136 +++++++----- > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 +- > scripts/spelling.txt | 1 + > 11 files changed, 350 insertions(+), 261 deletions(-) >
On 20/06/17 21:50, Seth Forshee wrote: > BugLink: http://bugs.launchpad.net/bugs/1689980 > > This series updates the aacraid driver in zesty with commits from > upstream and from linux-next to bring it up to version 50834 of the > driver. Almost all the patches address issues found on Power 8 and Power > 9 systems, and aside from a patch which fixes some typos all changes are > limited to the aacraid driver. Microsemi has done regression testing of > the driver updates on other architectures as well. > > Thanks, > Seth > > > The following changes since commit ab1f739cb13986bcfc4875c15dc0161935d7f004: > > UBUNTU: Ubuntu-4.10.0-25.29 (2017-06-20 16:40:58 +0200) > > are available in the git repository at: > > git://git.launchpad.net/~sforshee/+git/ubuntu-zesty aacraid > > for you to fetch changes up to b5d62a3c0f089690a9ba84c6a6cbabec94a6f822: > > scsi: aacraid: Update driver version to 50834 (2017-06-20 10:27:51 -0500) > > ---------------------------------------------------------------- > Guilherme G. Piccoli (1): > scsi: aacraid: fix PCI error recovery path > > Mahesh Rajashekhara (1): > scsi: aacraid: pci_alloc_consistent() failures on ARM64 > > Masahiro Yamada (1): > scripts/spelling.txt: add "therfore" pattern and fix typo instances > > Raghava Aditya Renukunta (19): > scsi: aacraid: Remove __GFP_DMA for raw srb memory > scsi: aacraid: Fix DMAR issues with iommu=pt > scsi: aacraid: Added 32 and 64 queue depth for arc natives > scsi: aacraid: Set correct Queue Depth for HBA1000 RAW disks > scsi: aacraid: Remove reset support from check_health > scsi: aacraid: Change wait time for fib completion > scsi: aacraid: Log count info of scsi cmds before reset > scsi: aacraid: Print ctrl status before eh reset > scsi: aacraid: Using single reset mask for IOP reset > scsi: aacraid: Rework IOP reset > scsi: aacraid: Add periodic checks to see IOP reset status > scsi: aacraid: Rework SOFT reset code > scsi: aacraid: Rework aac_src_restart > scsi: aacraid: Use correct function to get ctrl health > scsi: aacraid: Make sure ioctl returns on controller reset > scsi: aacraid: Enable ctrl reset for both hba and arc > scsi: aacraid: Add reset debugging statements > scsi: aacraid: Remove reference to Series-9 > scsi: aacraid: Update driver version to 50834 > > drivers/infiniband/sw/rdmavt/mad.c | 6 +- > drivers/scsi/aacraid/aachba.c | 30 +-- > drivers/scsi/aacraid/aacraid.h | 33 ++- > drivers/scsi/aacraid/commctrl.c | 21 +- > drivers/scsi/aacraid/comminit.c | 21 +- > drivers/scsi/aacraid/commsup.c | 101 ++++----- > drivers/scsi/aacraid/linit.c | 242 +++++++++++++-------- > drivers/scsi/aacraid/rx.c | 16 +- > drivers/scsi/aacraid/src.c | 136 +++++++----- > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 +- > scripts/spelling.txt | 1 + > 11 files changed, 350 insertions(+), 261 deletions(-) > Given this has had positive testing and the functional changes are limited to to the aacraid driver, I'm going to ACK this. Acked-by: Colin Ian King <colin.king@canonical.com>
On 20.06.2017 22:50, Seth Forshee wrote: > BugLink: http://bugs.launchpad.net/bugs/1689980 > > This series updates the aacraid driver in zesty with commits from > upstream and from linux-next to bring it up to version 50834 of the > driver. Almost all the patches address issues found on Power 8 and Power > 9 systems, and aside from a patch which fixes some typos all changes are > limited to the aacraid driver. Microsemi has done regression testing of > the driver updates on other architectures as well. > > Thanks, > Seth > > > The following changes since commit ab1f739cb13986bcfc4875c15dc0161935d7f004: > > UBUNTU: Ubuntu-4.10.0-25.29 (2017-06-20 16:40:58 +0200) > > are available in the git repository at: > > git://git.launchpad.net/~sforshee/+git/ubuntu-zesty aacraid > > for you to fetch changes up to b5d62a3c0f089690a9ba84c6a6cbabec94a6f822: > > scsi: aacraid: Update driver version to 50834 (2017-06-20 10:27:51 -0500) > > ---------------------------------------------------------------- > Guilherme G. Piccoli (1): > scsi: aacraid: fix PCI error recovery path > > Mahesh Rajashekhara (1): > scsi: aacraid: pci_alloc_consistent() failures on ARM64 > > Masahiro Yamada (1): > scripts/spelling.txt: add "therfore" pattern and fix typo instances > > Raghava Aditya Renukunta (19): > scsi: aacraid: Remove __GFP_DMA for raw srb memory > scsi: aacraid: Fix DMAR issues with iommu=pt > scsi: aacraid: Added 32 and 64 queue depth for arc natives > scsi: aacraid: Set correct Queue Depth for HBA1000 RAW disks > scsi: aacraid: Remove reset support from check_health > scsi: aacraid: Change wait time for fib completion > scsi: aacraid: Log count info of scsi cmds before reset > scsi: aacraid: Print ctrl status before eh reset > scsi: aacraid: Using single reset mask for IOP reset > scsi: aacraid: Rework IOP reset > scsi: aacraid: Add periodic checks to see IOP reset status > scsi: aacraid: Rework SOFT reset code > scsi: aacraid: Rework aac_src_restart > scsi: aacraid: Use correct function to get ctrl health > scsi: aacraid: Make sure ioctl returns on controller reset > scsi: aacraid: Enable ctrl reset for both hba and arc > scsi: aacraid: Add reset debugging statements > scsi: aacraid: Remove reference to Series-9 > scsi: aacraid: Update driver version to 50834 > > drivers/infiniband/sw/rdmavt/mad.c | 6 +- > drivers/scsi/aacraid/aachba.c | 30 +-- > drivers/scsi/aacraid/aacraid.h | 33 ++- > drivers/scsi/aacraid/commctrl.c | 21 +- > drivers/scsi/aacraid/comminit.c | 21 +- > drivers/scsi/aacraid/commsup.c | 101 ++++----- > drivers/scsi/aacraid/linit.c | 242 +++++++++++++-------- > drivers/scsi/aacraid/rx.c | 16 +- > drivers/scsi/aacraid/src.c | 136 +++++++----- > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 +- > scripts/spelling.txt | 1 + > 11 files changed, 350 insertions(+), 261 deletions(-) > Applied to Zesty master-next. Thanks, -Stefan
BugLink: http://bugs.launchpad.net/bugs/1689980 This series updates the aacraid driver in zesty with commits from upstream and from linux-next to bring it up to version 50834 of the driver. Almost all the patches address issues found on Power 8 and Power 9 systems, and aside from a patch which fixes some typos all changes are limited to the aacraid driver. Microsemi has done regression testing of the driver updates on other architectures as well. Thanks, Seth The following changes since commit ab1f739cb13986bcfc4875c15dc0161935d7f004: UBUNTU: Ubuntu-4.10.0-25.29 (2017-06-20 16:40:58 +0200) are available in the git repository at: git://git.launchpad.net/~sforshee/+git/ubuntu-zesty aacraid for you to fetch changes up to b5d62a3c0f089690a9ba84c6a6cbabec94a6f822: scsi: aacraid: Update driver version to 50834 (2017-06-20 10:27:51 -0500) ---------------------------------------------------------------- Guilherme G. Piccoli (1): scsi: aacraid: fix PCI error recovery path Mahesh Rajashekhara (1): scsi: aacraid: pci_alloc_consistent() failures on ARM64 Masahiro Yamada (1): scripts/spelling.txt: add "therfore" pattern and fix typo instances Raghava Aditya Renukunta (19): scsi: aacraid: Remove __GFP_DMA for raw srb memory scsi: aacraid: Fix DMAR issues with iommu=pt scsi: aacraid: Added 32 and 64 queue depth for arc natives scsi: aacraid: Set correct Queue Depth for HBA1000 RAW disks scsi: aacraid: Remove reset support from check_health scsi: aacraid: Change wait time for fib completion scsi: aacraid: Log count info of scsi cmds before reset scsi: aacraid: Print ctrl status before eh reset scsi: aacraid: Using single reset mask for IOP reset scsi: aacraid: Rework IOP reset scsi: aacraid: Add periodic checks to see IOP reset status scsi: aacraid: Rework SOFT reset code scsi: aacraid: Rework aac_src_restart scsi: aacraid: Use correct function to get ctrl health scsi: aacraid: Make sure ioctl returns on controller reset scsi: aacraid: Enable ctrl reset for both hba and arc scsi: aacraid: Add reset debugging statements scsi: aacraid: Remove reference to Series-9 scsi: aacraid: Update driver version to 50834 drivers/infiniband/sw/rdmavt/mad.c | 6 +- drivers/scsi/aacraid/aachba.c | 30 +-- drivers/scsi/aacraid/aacraid.h | 33 ++- drivers/scsi/aacraid/commctrl.c | 21 +- drivers/scsi/aacraid/comminit.c | 21 +- drivers/scsi/aacraid/commsup.c | 101 ++++----- drivers/scsi/aacraid/linit.c | 242 +++++++++++++-------- drivers/scsi/aacraid/rx.c | 16 +- drivers/scsi/aacraid/src.c | 136 +++++++----- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 +- scripts/spelling.txt | 1 + 11 files changed, 350 insertions(+), 261 deletions(-)