| Message ID | 20170525032822.19305-2-kai.heng.feng@canonical.com |
|---|---|
| State | New |
| Headers | show |
On 25/05/17 04:28, Kai-Heng Feng wrote: > From: Alex Hung <alex.hung@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1693126 > > This is to support Latitude 7480 and many other newer Dell laptops. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > Reviewed-by: Pali Rohár <pali.rohar@gmail.com> > Signed-off-by: Darren Hart <dvhart@linux.intel.com> > (cherry picked from commit 8d2c4538dbc7154c4aed1364db127a0e51dbd459) > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > drivers/platform/x86/dell-laptop.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c > index aaeeae81e3a9..de8cdc7df180 100644 > --- a/drivers/platform/x86/dell-laptop.c > +++ b/drivers/platform/x86/dell-laptop.c > @@ -139,6 +139,12 @@ static const struct dmi_system_id dell_device_table[] __initconst = { > }, > }, > { > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/ > + }, > + }, > + { > .ident = "Dell Computer Corporation", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"), > I'd like the all SRU specific details (impact/fix/test and also very importantly the regression risk added to the bug report to make SRU review a little easier. As it stands, it's upstream and the regression risk is almost negligible, but it's good practice to think about this and detail it as part of the SRU process. This fix is from upstream and targeted to a very limited set of devices and knowing that Alex wrote it I suspect it has been tested on a real device during the enablement work phase of a Dell project. Acked-by: Colin Ian King <colin.king@canonical.com>
On Thu, May 25, 2017 at 11:28:22AM +0800, Kai-Heng Feng wrote: > From: Alex Hung <alex.hung@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1693126 > > This is to support Latitude 7480 and many other newer Dell laptops. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > Reviewed-by: Pali Rohár <pali.rohar@gmail.com> > Signed-off-by: Darren Hart <dvhart@linux.intel.com> > (cherry picked from commit 8d2c4538dbc7154c4aed1364db127a0e51dbd459) > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Clean cherry pick, minimal regression potential. Acked-by: Seth Forshee <seth.forshee@canonical.com> Artful/unstable already have this patch as it went upstream in 4.11.
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index aaeeae81e3a9..de8cdc7df180 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -139,6 +139,12 @@ static const struct dmi_system_id dell_device_table[] __initconst = { }, }, { + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/ + }, + }, + { .ident = "Dell Computer Corporation", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),