| Message ID | 1502117549-24086-1-git-send-email-marcelo.cerri@canonical.com |
|---|---|
| State | New |
| Headers | show |
Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
diff --git a/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules b/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules index adf80fa92cd2..863909400f94 100644 --- a/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules +++ b/debian.azure/abi/4.11.0-1005.5/amd64/azure.modules @@ -240,8 +240,8 @@ hid-generic hid-hyperv hv_balloon hv_netvsc -hv_network_direct_142.0 -hv_network_direct_144.0 +hv_network_direct_142_0 +hv_network_direct_144_0 hv_sock hv_utils hyperv_fb diff --git a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile index 8fc23718bcf1..bc825bb4fb0d 100644 --- a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile +++ b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile @@ -1,3 +1,3 @@ -obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_142.0.o +obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_142_0.o -hv_network_direct_142.0-y := provider.o vmbus_rdma.o hvnd_addr.o +hv_network_direct_142_0-y := provider.o vmbus_rdma.o hvnd_addr.o diff --git a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile index 19afb983ea70..f55fa77566a8 100644 --- a/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile +++ b/drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile @@ -1,3 +1,3 @@ -obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_144.0.o +obj-$(CONFIG_HYPERV_INFINIBAND_ND) += hv_network_direct_144_0.o -hv_network_direct_144.0-y := provider.o vmbus_rdma.o hvnd_addr.o +hv_network_direct_144_0-y := provider.o vmbus_rdma.o hvnd_addr.o
BugLink: http://bugs.launchpad.net/bugs/1709101 kmod tools seems to not handle properly module names with dots. Impact: Currently RDMA drivers names have a dot to separate the major and minor host OS version number (eg, hv_network_directly_142.0.ko). That causes some unexpected behavior with the kmod tools. modprobe ignores everything after the dot, so it's only possible to load the modules manually with `modprobe hv_network_direct_142` instead of `modprobe hv_network_direct_142.0`. Also, after the modules is loaded, lsmod shows some errors when searching for `/sys/module/hv_network_direct_142.0` while only `/sys/module/hv_network_direct_142` is available. Fix: Replace dots with underscores to separate major and minor host OS version numbers. Testcase: The user should be able to load the drivers with their complete name, eg `modprobe hv_network_direct_142_0` and lsmod should not show any errors after the module is loaded. Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com> --- debian.azure/abi/4.11.0-1005.5/amd64/azure.modules | 4 ++-- drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-142.0/Makefile | 4 ++-- drivers/infiniband/hw/vmbus-rdma/vmbus-rdma-144.0/Makefile | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)