From patchwork Mon Mar 27 11:25:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Talat Batheesh X-Patchwork-Id: 743777 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3vsCPl1R4Pz9s7l; Mon, 27 Mar 2017 23:04:43 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="xNMjmzPg"; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1csTO1-00054v-KA; Mon, 27 Mar 2017 12:04:37 +0000 Received: from mail-ve1eur01on0076.outbound.protection.outlook.com ([104.47.1.76] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1csSmI-0008R0-Ca for kernel-team@lists.canonical.com; Mon, 27 Mar 2017 11:25:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+vbxHxK0HfsEfj6CDXV8mSx6MN2ixZ298st9SEE6y+M=; b=xNMjmzPgatkrFL1JQASm69hJyjhj6GFkuAXNU/ylHq/DdEEXuNzUpqtCSjRrN7XvdBiP8Svh1r2DA5RPIJ0EzxFyv9pbu++KHt4tFMXZ8pctuLVtoISv+QVnHtHc8IOVoc24VqP4RtIhuSLmBKhBWUg9IfIpS2FnOIoEDu1SYSk= Authentication-Results: lists.canonical.com; dkim=none (message not signed) header.d=none; lists.canonical.com; dmarc=none action=none header.from=mellanox.com; Received: from dev-h-vrt-005.mth.labs.mlnx (193.47.165.251) by HE1PR05MB1306.eurprd05.prod.outlook.com (10.162.250.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Mon, 27 Mar 2017 11:25:35 +0000 From: Talat Batheesh To: Subject: [PATCH 1/2] net/mlx5: Fix create autogroup prev initializer Date: Mon, 27 Mar 2017 14:25:14 +0300 Message-ID: <1490613915-25800-1-git-send-email-talatb@mellanox.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: VI1P194CA0016.EURP194.PROD.OUTLOOK.COM (10.175.178.26) To HE1PR05MB1306.eurprd05.prod.outlook.com (10.162.250.151) X-MS-Office365-Filtering-Correlation-Id: 41728e19-1921-44c2-ed9b-08d47503fd55 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:HE1PR05MB1306; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1306; 3:+DsF4pWUEX2dMc3Al0Qqj8jKBx1G1XCJoljEk/i6v2J6m8QDmM4U4OZA1vzrSUHgTul2pr6/AIJ8JrG133RgGwr9u+ZNaSAUq/QrYCAMSUuNWDvWvMEUa9xTrNp+J3sjobsuQpYsjpfdd0EwIGqXd+Gj8EKJBqmslci+DnO+/TUt0OF4jZv2nAaq7UV6isAGBVQ+PMjBjFhbeUoOAsJChHF2KqKpq1MRicLHfUehQJS8pVqefoPIEc7PZSCIzHWQX1w1e977ykVh6VCMRQKWqbAE3/fUgTmyJPR2MsNvEGI=; 25:z7pE0Pi/fDIDkbd7Sv5W2haA9h66c508CJXHPcSzE96bj522Kg4EtYgwUr9HHTmaDyWO4SJCFztIZx5sS2rNcR9H6Bs7SLyKvHTrY+7kdNBMndMDck2QPnZbgCYUq+MfG5YSu9q3c4eCdovfS7litkJSBG3HW4QQMjz1h2O8iOgx7pOLJcIyinfrhoDR8/aairlCk8di6wkv11HnmpeUeyQ/f4U/bo3asSHXIRuWt1MBd0RoM0vcPaR4J6lGYS+yO1GD7hhprfr4zC6/ZUJY2DGlPxdTPFt+MHaBfR5tkstaC7+0rWnSWxRG99OYJfIG3M9lW6H3epKbxWONtoAw/MdVXI+JW/cmPqExd74SIbkldvdcPIsKqq1cRjy6/xuXHAjVtbJH6k79M2kYRnfWR5Xgo99K1eQOSOZsETkYTXPVTru+KZMAJr4cLoLF2yl/QnDBFQk+cCkeAPtUTLHbxQ== X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1306; 31:UavlQ4Lrn7oYOOUU8nuJNhibHL3wfQx79wMxU2CPESbCC4vw9UZlJY4OEXqcG7xMSy8Ne6wJoIWiUhkOk4jywSjGRTlIY5esqV+h4DGaB7XzqsZmB5Pa+qPk6h0iwPj8p+SLCNdyZ/esHSdjsjn1AtWd2iJSdLwZBY35QbvJwBA9pr6iQ4/j4Cr2VjSnMsegnyTpauk0XL1EE1viIqEfyewm+djcF3RviN/HHZRXZlM=; 20:cwBYOM7oZ6TYQRVc13f6EIYvPl2IyAlW2CxbuOKL4AAoYD3ja49zzQobiA/2uNl3Xnbc7Ts0BRBWNRrZj2Ckzm3CbWY/dmjNd/4UL+IQM9onz6kIVP00FG5xiO9YJ/GTTsgtiavu9b5hGdxH1jaNgdlP6BJ5j9Gtu0w24cDtC/6qeAsYa+JpYAXkpPaasT/1AoEtH3Hylv4ZdqB/ZmRM5/PmcbNdZ0NHkRFq6p2fk+BNOFRKsebEJ5EituBzK0PtGpcvvHOjD0ZZSaryZsTbNl+RattVClh5Fy8kZZ2/JJhZ7dsPAYWuclA9N/B2P9lYCQlkCfv0WVVPVqGBmSMLgUcmnP9d5SsfuhF3Ag3BsWgq3XkjPyNkFioqw641aJdIoy3c7sMz4vd3Ug/p+gfB0qIWAvBg9ZuTGKKZE1JbZFkuF1zSPx45Pwi9H0CDHEcbwOrkE5b4Qh1GQ4Qoia+t9+W4TrciBWmQgXQ3Az8M/AuYZKcAytnw3CmEczehyUC3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211254476889703)(24339691489775); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123560025)(20161123558025)(20161123555025)(20161123562025)(6072148); SRVR:HE1PR05MB1306; BCL:0; PCL:0; RULEID:; SRVR:HE1PR05MB1306; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1306; 4:XVpNeaxNvX+K7SdCtBdBneyivG9j75O5rUvIfnQgIBoRlSgfn56BZ+/XpKYuU4BoIn5Lg4irKjJPpdypCmyO7wqzRzl3kUwG+OD+27HeXH1tTOPqbkS032cLudmakXeB81SAqOsNnLDMpBhiKH4FEQnBnOi0s7rs3aSGOnM3u/PPBV9y+qxxwxjVJ8DE8osyt4/R7Rx5TU3cloCURAz3Jz4aKfoIu1fk6NHR3rtDsHxWOGQlX+HCDG1b6dWkEWCRYVaHOZMMfAJPeZQ9WK0KSHaGfYsGuzbbtdkZy4OK4Lbuh7hLyMW0aAJH+Ogh03SCs1ryBw2e9mlIYLaXzdTZpnguq2A64Z9FgyD2srLOHsjs5Ua/L07x8p1eD3LGifxLSQXGAljzx/3uIp3u78v3hG+S2KJiyoMWiSq/0i6zpoh+lJKw1iUCBxGSqHEFgZ3XAt/onEdaltsNxNBHgmvfeC5jyoi5YseaAAeFBZqosiDAwBDuYdCWI+tb4ITDBSgV+2xbNdOZ6uldJ8KgVCvi7M7MMdGNbtSnZ13+PvXU52s2y4b6SE5x9CWIomw2r8Otb6rPIvpHN0Rype2H7Bt/KWsGua6CJPsQuOOXHmrft0QrjjqzZxSQILBnHSPKwhLWdEbyRSPPI4ZmPkfLiiJvEb3KRnEcYZ/Zth3AwNB3kZBkoje1I5FDkuL9ds+vJ3I1Dh6kRPBv3O5SnRBT6Ao5Sg== X-Forefront-PRVS: 02596AB7DA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39450400003)(39840400002)(39410400002)(39850400002)(39860400002)(6116002)(7736002)(50226002)(47776003)(8676002)(305945005)(53936002)(81166006)(1720100001)(6506006)(38730400002)(110136004)(107886003)(6486002)(3846002)(4326008)(966004)(36756003)(2351001)(48376002)(5003940100001)(6306002)(6512007)(66066001)(54906002)(6916009)(5660300001)(25786009)(6666003)(189998001)(2906002)(42186005)(50986999)(33646002)(86362001)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB1306; H:dev-h-vrt-005.mth.labs.mlnx; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB1306; 23:s5Ed0Me7E/EF7MchorejJP5pnFCHgPWCjXP9reda4?= =?us-ascii?Q?Xka/Aub41Ak+JMOXOnOCO4gKBVz6KyOU6VTaECcdqO7F0Y5w31htfK1hu5ze?= =?us-ascii?Q?6YQ8txMCWLp6nVoq4yyj3GlzbJS5tBg98uuhLcgQB6NGFfoVo1UO9II3/7ma?= =?us-ascii?Q?S3EEOBLKl6tFSSVoQrUu74gV4TBLizR8mKoPZogUO2Mdbx6E3GPX8s/TSKb9?= =?us-ascii?Q?RLXGbj9YgHvonZyrkGLpitu8pqI1oQvr/faJPlnC7O6n2VjWKQ59b9mWIPU1?= =?us-ascii?Q?7DjWXHFlLQltYeiMYwTWrFYUuHl7gb3yymmLWIEcqIKN235H3elRF01H/ds5?= =?us-ascii?Q?A/KoPO/KyE6Qj+68qt3EKVdGD7q5OeABuOWlatMJJYhtjoYFHKaJj4lrvmfn?= =?us-ascii?Q?1qNgD0Ll5TG7Cq5QbKRSnt6vuogZktxUzS/1eYjArDb0QOFoEKL/QdxMrOGg?= =?us-ascii?Q?NHGHOrW62HB886J+Pu8JATL1et2np+On5MTG1uoyPHjak8+dLzjxnfjNYhfC?= =?us-ascii?Q?MQ0xeKOztpneDkzpsnjUZbcT8t24E3v9DgJRcj24jwusVfOniw9TRP6lh5/X?= =?us-ascii?Q?NEe5VCF/YSP13SfgNDqOC0Wzp3lfznzSm1UgzdZjZBgGFKtWC7IBy2jovkbe?= =?us-ascii?Q?xWDZY0lY5ChiN3AYrlet2yN2qlSSMpXNPoNDkgoUabnSd6Wn4Lq9+hfMsQzf?= =?us-ascii?Q?eVWiM7k3pi71tfdh99t/CFexMfbWX8Lf3Y2BKFpVJZScqZ4MZ/RmNk9GCWHK?= =?us-ascii?Q?7kfN31uxuM3R00pJCVF+DIbwFeMfKSp3yXrDaH+Yk+VwwLFzffgr6GIfeIRp?= =?us-ascii?Q?KfuBq8KS72WmXKQGP4/2FAAIRT1yr5NS2Wnpv75u8CHLW6XHlONdKolYo+Kn?= =?us-ascii?Q?D1nLM+VYSszvdVjzwxzdr1Np3WQgwGIUdu1W01K/gySgNsmAksTy0c2TgqZ0?= =?us-ascii?Q?tE9QLCAK6TTBfDSXeGB4i6nMfe0S/lk+CJ9616rqzrrZ/6sVYKn/p57fAlI/?= =?us-ascii?Q?3c8921lU2WOi3qFhGvmhW56KKVezQuw2AY4Oz9EQN665RlAMuMqwDXZl69zn?= =?us-ascii?Q?7CauY4WFvAJKFmk2Obb2MdT2RtN?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1306; 6:QNfRLzy8jolItZutgYFguzB1Z7Bu9y9go8UZavhJ7i6PS9bXVvz3poNG+mCxaIQkZWrzzDEvJNvnYioEp8R4+6BKp5QY8eRqwJT+xsGQHMiBLGt9MfgqY0fUI/gG5Sse95JHHGCV4hZxvCLtDfxCrjNqIIEA6Ju6jCfJP5yAuacB2bTVf5RrUkFvqR8oOggKCTP3ATgFAk+AhEHdj+IfxzeeV3SugmhMIarbyd8pY4IIlnBE5FFUz3AaopglOShsnY4m6jyai9xJbJUG4ak3zDXdtrYu6dqi8JL0kUbA8uQ2+VqYjkTLaQiawuN4sy1EfGjTd6uwtHBDKImhXRLhSWhHn4Vwv7rZKK9FVcBcIKB7F4kRc1Pe+I7u7HFJfA6MToQ/PU4bV/Ds0wL7FxeLVM8e6n01kMog2Gho6jsm+ZQ=; 5:NfJuU97Fxjww/iIb9bamuik9rFAAQq5WXIIufsifX8hqWcm0ogDMfc9JDboLykyV213/8VGzamkmRXMnIIKrZXa6tUPovOPZr5sOkBT8LhERr0Vxy/zL/pY6yOOhXD1Lo5KWFUYYDVYyEtnQpbcVCg==; 24:zxpqqGArdIk1q75MFEJqZKLZg25XzKlUyRmaM5bYmG0+/m9k80wniWHzBb7JVcK2CII3ZNDgbD/IkeLl8MmkziUUGHqIlmqg63wSxreoHI0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1306; 7:8/5+Z33k1MZ7zhWFCA8Qt4njBZOa2xi08kJevs41o3NdM62jOBCbrokuw6gCFaVRQEDUbNXIWJDcGJeEsGUQlj37ijW/93qPRbceRaZa5+IbU0Ga7iUOWgxtuajYPeomGreskH9v5va7hT4UVUaOuWdiTfAWJFrlTe73mGE9YzxUBDUdJ4/Npl4Lvz4Vy2fLtA1lB3v31IyUVzZgrvjz0blA2u3Z7WtW3/zI4zmF3FbkEJHM/P+jWy0/wjOG81fK05oUyuvBL3JxVikqnuO6gD7OPfeIwlEMsvjtAdzfbtklE2M0MtgWVMacyd+EA4hAxbdiOrp2XNufW0ehMTJ+kA== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2017 11:25:35.2733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1306 X-Mailman-Approved-At: Mon, 27 Mar 2017 12:04:36 +0000 Cc: roid@mellanox.com, noas@mellanox.com, paulb@mellanox.com, talatb@mellanox.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com From: Paul Blakey BugLink: http://bugs.launchpad.net/bugs/1676388 [ Upstream commit af36370569eb37420e1e78a2e60c277b781fcd00 ] The autogroups list is a list of non overlapping group boundaries sorted by their start index. If the autogroups list wasn't empty and an empty group slot was found at the start of the list, the new group was added to the end of the list instead of the beginning, as the prev initializer was incorrect. When this was repeated, it caused multiple groups to have overlapping boundaries. Fixed that by correctly initializing the prev pointer to the start of the list. Fixes: eccec8da3b4e ('net/mlx5: Keep autogroups list ordered') Signed-off-by: Paul Blakey Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed Signed-off-by: David S. Miller Signed-off-by: Talat Batheesh --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c index 6346a8f..80772bb 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c @@ -1136,7 +1136,7 @@ static struct mlx5_flow_group *create_autogroup(struct mlx5_flow_table *ft, u32 *match_criteria) { int inlen = MLX5_ST_SZ_BYTES(create_flow_group_in); - struct list_head *prev = ft->node.children.prev; + struct list_head *prev = &ft->node.children; unsigned int candidate_index = 0; struct mlx5_flow_group *fg; void *match_criteria_addr;