From patchwork Sun Feb 26 09:09:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Talat Batheesh X-Patchwork-Id: 734204 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3vYDps09r0z9s8N; Wed, 1 Mar 2017 23:12:37 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="TOBRwLJd"; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1cj37R-00063w-Vw; Wed, 01 Mar 2017 12:12:34 +0000 Received: from mail-db5eur01on0065.outbound.protection.outlook.com ([104.47.2.65] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1chuqX-0007qT-QG for kernel-team@lists.canonical.com; Sun, 26 Feb 2017 09:10:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KG/n1oas+KRn+WyhD8gLikkSm/Ogm0gHqK2hDbcvh6U=; b=TOBRwLJd8nTceJFhNGpMEGnCjWI5HTQnX6ypeiOHtjEP37arVd7jIwf8xkHsVW3f4JSXy8W+D4k8zvnj1kRepdQESRAfgGInYwUCi77BkfjpmukLOUrep9ePYbfAb42j+7BpeLlR1q9/QSSroEZE75wvSJGQpg3tgs+fiiVLzuA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=talatb@mellanox.com; Received: from dev-h-vrt-005.mth.labs.mlnx (193.47.165.251) by HE1PR05MB1306.eurprd05.prod.outlook.com (10.162.250.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13; Sun, 26 Feb 2017 09:10:23 +0000 From: Talat Batheesh To: Subject: [PATCH 11/18] net/mlx5: Fix static checker warnings Date: Sun, 26 Feb 2017 11:09:56 +0200 Message-ID: <1488100203-31976-11-git-send-email-talatb@mellanox.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1488100203-31976-1-git-send-email-talatb@mellanox.com> References: <1488100203-31976-1-git-send-email-talatb@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM4PR02CA0026.eurprd02.prod.outlook.com (10.165.239.164) To HE1PR05MB1306.eurprd05.prod.outlook.com (10.162.250.151) X-MS-Office365-Filtering-Correlation-Id: 82520af4-1c55-429b-3222-08d45e274c4c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:HE1PR05MB1306; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1306; 3:MXyIfDCJFDC7Ec8oVhJcHu6Mjc1beygl/ILI/5I186XtN0kqTk/GouTH3tEwb0XvLe5F+eYrdfhVnwYeiviUPl171Ojw8LG0GrAnFsnLCKoP9vI924SQR+ncnIX6t6xrUZY2/6AffTr7HDkO6zqp60rtFqX0sDNpY4vbePuU8xArl3eqe6IYdWc0CqU2MBQNJP22usDYGJKeHWgJLWSG0sSCn/GInzJsO6yNLWidorcOD7rILgQLAn12DZOUPOz/zqEaJFliK5WwDpvAc8j7IX8m+uqL9fWAu4WSo/fzsew=; 25:JcDFDyn7TXoI4knEPa5oNZHRqlaHvQ37jJ56/rVC/9hek/WEtdn30AjgzGwMjxljZ9PZep6up6m3F8p2wFSF02tAgJ07a5hKv5KOpwrbf9aNRIdUzRn2IxIlnSwwDyLNJNHWD6dYPqnCwp2y4xVBOrxGZ8udwTpR3AyKYY5XVGipXvoXQjjuY+ISk4By7iBWZsK4wAMu1WWj/Twl6kE4+2nOTGJbmlSEgEVU89YD15hOun2mSqjrxRJlzmiXAM/MXXtVE+bv+0mWpxdrlfaSrVzb76q+BA0AUr4EMCd+hzGYebYkakIbFu/ryWu2k61RrGeWa966AA/gPx7eTH7uVQlApJpV1jLKBFYUYNzkqpVxKwEJce8WSDf1wfPnLOaARiCqvf4kyj0hXLnQRnhrxfHypESLPccPwaARPHiU58sUO0pB/4Lf5zpzvgnwzrrLI2l6I2LisAdVlI2TIDdFVg== X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1306; 31:zuh3dogE6fuyuvMIaxIq5PN4jzGFdX1FG1hjMCzpQqB8xX5wP8Kzfxf4VDw/0ha0VAGWnC2zBYRmcBJYT/W2LXHqrMnoQC3SfoW3uRK4gCcm+N8p11UpnPxWqfkxhBwwuHPSfqpLzffGEjJ43yh7OFVjkzQiON9hPxo0e3r8KknO5HreM5zyzobPyAbyYzp5/eALxoIdUzuywCOvX4szCaIWDctjBnrvCWs84nyOWsZInYMVkPLAptCaRmnGuiT8; 20:VrZ3eJayeQrcOpYdp2a54BouB/P6sZPCC1Mt4bDeKwdDPxSP6kaC0pyrJtwfcyhq3pWOtcVDh+S/Y033XVFVUNYiHVjv83aiHC6mWDhNAhTfgwh9qDqqUl9ixibLfAp9x8/O9sEkTATb2Fks89iRLXV/E+DRAN6nM0C+pOxJsf1LqWkbql0QuWL8rKhpZtrY4dDZ9MM2BiyrgjEA6v5AvqdjLpLNW4uYyUZ3UJrKZyQ+vEQrmUoM5ANITbHQVocn33dqVFTOJDqT6zI6JOjhzr3B4s/CU8ZqjNlt2p+Lp4WY1xJv2dxcp0BabTBQ+c+/Ev46IgsVkux9powQFi0vxOAupSZz0NCh6hHQXVVhGMPBfofoXVs1J3oeWIS3wafH0eWYApX4f+qh5Uf8c9skCt/vh5Y6Rx+7dB1yw4PgMkA0cd9OErkAbgL+uMR3MwRw5rH+N59qVjbkPCCmYr+RyAa6XVtoYjPENP1c6GFAwHmVGbN10l0/KB9KM5RYCEeN X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211254476889703)(24339691489775)(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148); SRVR:HE1PR05MB1306; BCL:0; PCL:0; RULEID:; SRVR:HE1PR05MB1306; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1306; 4:hnxfO0DthZD4tyDgzBxrrCSg06TvwYpNwuVfzAstr/2FgrArsOjoY5SPhakSwfywVa5x7qEgx8GFB5eE+oz/iG15S+8aXJDH+HM6GHxoIGznl+WoPDmxNcNkfb1TM1+Z88F5bxpG8fAoNQ8evA9umNcrCkDcTYMAM2fiRgnolyOELCBzG0Ll0T5iP+5Zd4JMcIx2bg0LMGqhLTMiW7tRIrOZPP4PSBfXUFUQ+GdLFxfAOlJNJz7jqtf13SiGuRP4WMAxjB5e+H/QhXlYcCfnFCvX7q9nnE24remQ60sobxp33/V+Km/33pjG/VaLEuMXiueYEPHFx7pMkGoo70MpjqjG6u1DTbI87eFtpAaZPTYH67Q/Nv02GuhRKjYFR6aTnO9+VbUkkxkl3+1qYgfS8HF6qDU7xuX7CdSGAPRrwA+O3qbfP5GqnPzb7bWvSSdh8zdEicPbLkCNW7bg+RHpawHRXk5VKiBUZ3zetkcGyV0YUXQflH8Z0zrUHTmnkPeVQ0DrAQe210D6q5wMsg2/9mxlHNJWe2MWnjAe/Oqxc9kr4Tkylo9QBd7o/rE3vcc3Oz5WQF5eJHUuC01iIz7zsTA10tXqim/+v4MmUyB6sFguBgwCrR3ksj2VR4sS+L2pWmJggtw0fB7LnomgEisJ3Si+OCeGYhD2FOnftY74hOaL9sUa718YJTenmwEtM0K6u9MyfJo27MspgdAXR2nyGNErLnDNNIA+1MoaEAIvNdUIER48MR7PI5+RgJLsxEn/ X-Forefront-PRVS: 0230B09AC4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39410400002)(39450400003)(39850400002)(39840400002)(199003)(189002)(68736007)(81166006)(8676002)(6512007)(81156014)(50226002)(3846002)(6116002)(50466002)(6506006)(48376002)(66066001)(6306002)(25786008)(47776003)(6666003)(2950100002)(5003940100001)(6916009)(6486002)(36756003)(5660300001)(101416001)(189998001)(92566002)(7736002)(107886003)(110136004)(33646002)(97736004)(105586002)(38730400002)(106356001)(2351001)(305945005)(76176999)(50986999)(4326007)(53936002)(2906002)(86362001)(575784001)(42186005)(450100001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB1306; H:dev-h-vrt-005.mth.labs.mlnx; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB1306; 23:vStoqHrUnuyQpqnxjDvhuJSSqmX+3ofZWudvEreil?= =?us-ascii?Q?e46uWarRZFOF2iH+PqIQNB0CtbAkTrSflyZqU1N+mS3wRl6fOp1zbcEkq0nw?= =?us-ascii?Q?/Yu3ii9MsgfFk2ZnXTDQW5qwTwZMuV6pla+7jjOUePsG62vl2W1q2+ewqdng?= =?us-ascii?Q?JlBWamCXJ2k/ekTX1CLXuCMAJxcbhHmlaEnx/oxSfY93UDmaBKUX+8ffoHxl?= =?us-ascii?Q?DNLCO255JzWXKnv5PzbPJeBzug9r8Xz//tZ8xFrYvM5BX+xIADlW13s10TFm?= =?us-ascii?Q?p59tFC+YHRvWRmx4h9Lw3P7QdqhrmTJTzSU6b9TzWdxN3mvpawxTXwOF/msl?= =?us-ascii?Q?7/F2t4S6xnGItpLNWYXwpZqHBc/uBqDMjs+5pBUCSxqwYNsjp3Hjl535FU5j?= =?us-ascii?Q?196f3aZkpLd6ORtf1X69/lqGUEbM93OWg8hmdQsenRvoiN4l/aXPhO09shmT?= =?us-ascii?Q?7yDocDjQAHkWLglw4igtgk/447EJnM2DD6WmkLYxOvK35GHJCOz1mBX7jGGe?= =?us-ascii?Q?38EZ4Apf8KRMUShg2iqbNpDuebtH5iWh9QFAXFepKxfe+VUQj46jYuiAGXb/?= =?us-ascii?Q?ecydZgLcvCSWMMTG+H9+Of/mZlJOZeEICFQYaLl5eFTxoxSPjE9eysd1Jkcz?= =?us-ascii?Q?RTeAkv9uLC1EyTjqNMf8VnlW10RpU7hnQPDKVFNuH2n6z3lEdqldm33W82kJ?= =?us-ascii?Q?rF9lxkZbn0/xs4JX4I2nSyqF8vlbRt7FMLuygfqtQBUNCiebTXr1n+FB8gIh?= =?us-ascii?Q?KIJijcK414DxD8bsHvNkMQy75DueOslt8reAij5Qg4i0qbRmhefD/zjPKTFS?= =?us-ascii?Q?c5Jr023OjKeYFMFT7d8TK9LJrQ0e+LCg+/kEG7cJYAsv1vh4x6uEjxlv2Tfw?= =?us-ascii?Q?vDWxM/Mj4JVKmbOMc01e8nQMPB/3oNfK4Tl5uUstEN2yGOTEXZtsvUL7Ka6e?= =?us-ascii?Q?DdsK1b1jmo3ne1st96JBdjbPoIwQdqTA/ZzLabXQavXlp1Q9gqbwMHrtVAQh?= =?us-ascii?Q?1J8YZE3U7+xpFSl0rDRCA3GCesj7lNkjW2U3QgEjjOGEdRXUfft7KtGFa4/Z?= =?us-ascii?Q?NBmj7xWM0/6MH/fCCiEx+hui8jdARUlTL3sFURFUgqRv/rV9qKHTOk8t8LI4?= =?us-ascii?Q?Uuuvxu9M3pRlNuz2BKtlDN3nGOop4fKh9xCxaLVN3hpWif0ZmKQUrU7IiGSl?= =?us-ascii?Q?9rxm2Upgsn2JadDDCwe1o7s1FVOaaz6Dq/bKgekOmt2ktBG08loxIM/IaQKO?= =?us-ascii?Q?68XZWTC0unqSqjAhvu0u++j8tU81DauFENd1iiN0bmcpKI+iJKiie92wIETI?= =?us-ascii?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1306; 6:LaicCM5AU5SO3/zhf/oxxxQ1mtc4xbboZTge6AcD6+zmW1MTqshA2GldjQ9ISXUlWNMHAfdQxMH04601U9rcZ4qNUhwKHb8J8JDxozIxJYEOrZAiT7yMkDwZaiAnJ0ZlgrQtuIy7rl9PzbdiQk4MAAHrST47AvQtem97o+B32UqIXYXF0KloOXN7BRWERoZmr8VHzxXLlxNPEfqp69hnO8h8uFiRAnr6lNB3zJMC9J/9xPt11vCdInXl1MLkUEy9RqfQwSv9dyQR01FyrdPAPNla95z5g4lH2txrQtExi8ysQIid+BdBAwqnxLS20hi7D7Lx0lSoZv4wd339uZHkzfvduJTuDNrBQlUhiWzR7WU6mVD8MAg21rLh6ObBy3t/kpfG2bUQbOK7/cZnx1TjH7ZfvV3dtMKmAJE6EIJz4pA=; 5:eCcG3+DDrTmXVliN/a0YdJNp8pArP3K5+OWrB5OZoyscaWykmVwzUz+LhnLm/SJ4bm3DwZ9pZvTWuCyJea32R+3YBRXJ1WQ7N7jM4NJLeaLgoYK4izpplC4ta4kZVftF8qFMwI+zspiWfAlveMZBGZ8oeNgpRY9MoQkxpsRuvqs=; 24:ZLAISzXxKKJWcP3zFgT8EKIASpEw3ZZ4hLCAKzE3tJfSBkThG1Bmw6yrml9yepRee+J6WU1PqK87SZ7Jon2eT8sbGJi9VgaJfVc1ULpMx5E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1306; 7:Igsi0sltt97qSC9yupqoflBTJ5NfHKtlqg6tHd1Ib1G4COkgvvha2MVI/2nn9hUEl0RcoeTZ8lpfbNOq/BkRwjebpaXoyZgdd2CoW56fhxbyte6cGSEeyVw6lyqhyXQ0H6is5FtvRpGzLSFhKCBOL1mmfFChatcw8o7YDC7j2K5cPyAzvWDxJtX8/0+pUdnmtJSNeXGacF432Ydq1SNyw9+jt2oYUOrYv8K94d9yyGh02xx3PBaHiWWrTb3HbhOOn73k2eSdspCjN9Xsz7sLbHPGlrapxhO65EHdIkvvChKlypleuLU0jZzha3hIZXkycbCbGYjG7aZFd9TMgROYWw== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2017 09:10:23.7985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1306 X-Mailman-Approved-At: Wed, 01 Mar 2017 12:12:14 +0000 Cc: talatb@mellanox.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com From: Or Gerlitz BugLink: https://bugs.launchpad.net/ubuntu/1668019 For some reason, sparse doesn't like using an expression of type (!x) with a bitwise | and &. In order to mitigate that, we use a local variable. This removes the following sparse complaints on the core driver (and similar ones on the IB driver too): drivers/net/ethernet/mellanox/mlx5/core/srq.c:83:9: warning: dubious: !x & y drivers/net/ethernet/mellanox/mlx5/core/srq.c:96:9: warning: dubious: !x & y drivers/net/ethernet/mellanox/mlx5/core/port.c:59:9: warning: dubious: !x & y drivers/net/ethernet/mellanox/mlx5/core/vport.c:561:9: warning: dubious: !x & y Signed-off-by: Or Gerlitz Signed-off-by: Matan Barak Reported-by: Bart Van Assche Signed-off-by: Saeed Mahameed (cherry picked from commit a61d5ce9cc56e2e41bbb1ad62ca7a16d7e7567bd) Signed-off-by: Talat Batheesh --- include/linux/mlx5/device.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/mlx5/device.h b/include/linux/mlx5/device.h index 52b4374..ea4fb0a 100644 --- a/include/linux/mlx5/device.h +++ b/include/linux/mlx5/device.h @@ -67,10 +67,11 @@ /* insert a value to a struct */ #define MLX5_SET(typ, p, fld, v) do { \ + u32 _v = v; \ BUILD_BUG_ON(__mlx5_st_sz_bits(typ) % 32); \ *((__be32 *)(p) + __mlx5_dw_off(typ, fld)) = \ cpu_to_be32((be32_to_cpu(*((__be32 *)(p) + __mlx5_dw_off(typ, fld))) & \ - (~__mlx5_dw_mask(typ, fld))) | (((v) & __mlx5_mask(typ, fld)) \ + (~__mlx5_dw_mask(typ, fld))) | (((_v) & __mlx5_mask(typ, fld)) \ << __mlx5_dw_bit_off(typ, fld))); \ } while (0)