From patchwork Wed Jul 13 08:45:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phidias Chiang X-Patchwork-Id: 647771 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3rqC8x6qjdz9s9Z; Wed, 13 Jul 2016 18:45:53 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1bNFni-0008Kv-UL; Wed, 13 Jul 2016 08:45:50 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1bNFna-0008Ji-81 for kernel-team@lists.ubuntu.com; Wed, 13 Jul 2016 08:45:42 +0000 Received: from 114-34-181-73.hinet-ip.hinet.net ([114.34.181.73] helo=ktx.tw) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1bNFnZ-0005Gj-Dl for kernel-team@lists.ubuntu.com; Wed, 13 Jul 2016 08:45:41 +0000 From: Phidias Chiang To: kernel-team@lists.ubuntu.com Subject: [Xenial][SRU][PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" Date: Wed, 13 Jul 2016 16:45:33 +0800 Message-Id: <1468399534-21152-2-git-send-email-phidias.chiang@canonical.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1468399534-21152-1-git-send-email-phidias.chiang@canonical.com> References: <1468399534-21152-1-git-send-email-phidias.chiang@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com From: Allen Hung BugLink: http://bugs.launchpad.net/bugs/1593124 This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection if device implements confidence usage") The commit enables palm rejection for Win8 Precision Touchpad devices but the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very properly. This quirk is originally designed for some WIn7 touchscreens. Use of this for a Win8 Precision Touchpad will cause unexpected pointer jumping problem. Cc: stable@vger.kernel.org # v4.5+ Reviewed-by: Benjamin Tissoires Tested-by: Andy Lutomirski # XPS 13 9350, BIOS 1.4.3 Signed-off-by: Allen Hung Signed-off-by: Jiri Kosina (cherry picked from commit 62630ea768869beeb1e514b0bf5607a0c9b93d12) Signed-off-by: Phidias Chiang --- drivers/hid/hid-multitouch.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index ecf2e85..c5ec4f9 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi, mt_store_field(usage, td, hi); return 1; case HID_DG_CONFIDENCE: - if (cls->name == MT_CLS_WIN_8 && - field->application == HID_DG_TOUCHPAD) { - cls->quirks &= ~MT_QUIRK_ALWAYS_VALID; - cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE; - } mt_store_field(usage, td, hi); return 1; case HID_DG_TIPSWITCH: