From patchwork Wed Mar 9 00:27:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Mostafa X-Patchwork-Id: 594577 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 075051401B5; Wed, 9 Mar 2016 11:30:06 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1adS0p-0006TQ-Lu; Wed, 09 Mar 2016 00:30:03 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1adRyF-0004WT-6R for kernel-team@lists.ubuntu.com; Wed, 09 Mar 2016 00:27:23 +0000 Received: from 1.general.kamal.us.vpn ([10.172.68.52] helo=fourier) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1adRyE-00030V-Lf; Wed, 09 Mar 2016 00:27:22 +0000 Received: from kamal by fourier with local (Exim 4.86) (envelope-from ) id 1adRyC-00078c-0S; Tue, 08 Mar 2016 16:27:20 -0800 From: Kamal Mostafa To: Eric Dumazet Subject: [3.19.y-ckt stable] Patch "af_unix: fix struct pid memory leak" has been added to the 3.19.y-ckt tree Date: Tue, 8 Mar 2016 16:27:18 -0800 Message-Id: <1457483238-27403-1-git-send-email-kamal@canonical.com> X-Mailer: git-send-email 2.7.0 X-Extended-Stable: 3.19 Cc: Rainer Weikusat , Kamal Mostafa , kernel-team@lists.ubuntu.com, "David S . Miller" , Dmitry Vyukov X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com This is a note to let you know that I have just added a patch titled af_unix: fix struct pid memory leak to the linux-3.19.y-queue branch of the 3.19.y-ckt extended stable tree which can be found at: http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.19.y-queue This patch is scheduled to be released in version 3.19.8-ckt16. If you, or anyone else, feels it should not be added to this tree, please reply to this email. For more information about the 3.19.y-ckt tree, see https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable Thanks. -Kamal ---8<------------------------------------------------------------ From e7a4e1d8561d91c0e71287ab6b803a055e344f5f Mon Sep 17 00:00:00 2001 From: Eric Dumazet Date: Sun, 24 Jan 2016 13:53:50 -0800 Subject: af_unix: fix struct pid memory leak commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b upstream. Dmitry reported a struct pid leak detected by a syzkaller program. Bug happens in unix_stream_recvmsg() when we break the loop when a signal is pending, without properly releasing scm. Fixes: b3ca9b02b007 ("net: fix multithreaded signal handling in unix recv routines") Reported-by: Dmitry Vyukov Signed-off-by: Eric Dumazet Cc: Rainer Weikusat Signed-off-by: David S. Miller [ luis: backported to 3.16: - use siocb->scm instead of &scm ] Signed-off-by: Luis Henriques Signed-off-by: Kamal Mostafa --- net/unix/af_unix.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.0 diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 59797d8..3a27d4c 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -2154,6 +2154,7 @@ again: if (signal_pending(current)) { err = sock_intr_errno(timeo); + scm_destroy(siocb->scm); goto out; }