From patchwork Wed Sep 24 09:00:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Whitcroft X-Patchwork-Id: 392819 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 737E8140095; Wed, 24 Sep 2014 19:01:38 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1XWiS7-0003gj-D8; Wed, 24 Sep 2014 09:01:35 +0000 Received: from mail-wi0-f175.google.com ([209.85.212.175]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1XWiRj-0003Uf-0r for kernel-team@lists.ubuntu.com; Wed, 24 Sep 2014 09:01:11 +0000 Received: by mail-wi0-f175.google.com with SMTP id r20so6455654wiv.14 for ; Wed, 24 Sep 2014 02:01:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bnY4B5COVNt82lZqarcljOC4SF5/AudSm3y6GW8HjbM=; b=OMA8Q+Jsg6WkLyui4PrRIQcSJoIAzxJbKb+eZhudM0YgyQ3nivjSDCdpDvfcF430pb NszrqdOU/9j9cDSbqnoTVfy0wx3kn1/IpbByyDyqrslVwxTW6adjZ6U9bJ3zpkUnuH13 vjcdGK77EifRzFR5WMKSwb2sN8cFvGdoYFlwM7FSfI6UMaWWIh1ZvNjv07qNkGDdWqKN J64s7jO9Q4gQ99PKFVEIuXCuVMvLb314tAfeeMaDlYOrAI7CZ3URvUds4M5jM5yY4gRR 1R1A+Ntd3CFJaBrvFfULgZeLGtHQAvQw2tI2g4Oz+SiSRGpQL2h66bPtxwheQBgoXbQj /emg== X-Gm-Message-State: ALoCoQljv4MIGklhcs8JyqnC5FNuZe+ZYyl8j9t/st9oi5x6WB90g6ouHuWaa6kvzswoRsfc9Q6q X-Received: by 10.180.98.227 with SMTP id el3mr10125640wib.13.1411549270869; Wed, 24 Sep 2014 02:01:10 -0700 (PDT) Received: from localhost ([2001:470:6973:2:78b9:724f:ec05:5c33]) by mx.google.com with ESMTPSA id nf2sm4241641wic.4.2014.09.24.02.01.09 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 24 Sep 2014 02:01:10 -0700 (PDT) From: Andy Whitcroft To: kernel-team@lists.ubuntu.com Subject: [PATCH 09/11] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure Date: Wed, 24 Sep 2014 10:00:45 +0100 Message-Id: <1411549247-6511-10-git-send-email-apw@canonical.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1411549247-6511-1-git-send-email-apw@canonical.com> References: <1411549247-6511-1-git-send-email-apw@canonical.com> Cc: Andy Whitcroft X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com From: "K. Y. Srinivasan" On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR. Correctly handle this. Note that there is sufficient sense information to support scsi error handling even in this case. Signed-off-by: K. Y. Srinivasan Reviewed-by: Hannes Reinecke Cc: Signed-off-by: Christoph Hellwig (cherry picked from commit 3533f8603d28b77c62d75ec899449a99bc6b77a1) BugLink: http://bugs.launchpad.net/bugs/1354397 Signed-off-by: Andy Whitcroft --- drivers/scsi/storvsc_drv.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index b529ae8..ed0f899 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -1018,6 +1018,13 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb, case ATA_12: set_host_byte(scmnd, DID_PASSTHROUGH); break; + /* + * On Some Windows hosts TEST_UNIT_READY command can return + * SRB_STATUS_ERROR, let the upper level code deal with it + * based on the sense information. + */ + case TEST_UNIT_READY: + break; default: set_host_byte(scmnd, DID_TARGET_FAILURE); }