From patchwork Wed Jul 3 20:24:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Bader X-Patchwork-Id: 256739 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 0E5092C00A6 for ; Thu, 4 Jul 2013 06:25:18 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UuTbz-0002e4-QR; Wed, 03 Jul 2013 20:25:11 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UuTbi-0002X6-Hy for kernel-team@lists.ubuntu.com; Wed, 03 Jul 2013 20:24:54 +0000 Received: from p5b2e2ef3.dip0.t-ipconnect.de ([91.46.46.243] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UuTbi-0008Fu-BO for kernel-team@lists.ubuntu.com; Wed, 03 Jul 2013 20:24:54 +0000 From: Stefan Bader To: kernel-team@lists.ubuntu.com Subject: [PATCH 3/5] tg3: missing break statement in tg3_get_5720_nvram_info() Date: Wed, 3 Jul 2013 22:24:46 +0200 Message-Id: <1372883088-8397-4-git-send-email-stefan.bader@canonical.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1372883088-8397-1-git-send-email-stefan.bader@canonical.com> References: <1372883088-8397-1-git-send-email-stefan.bader@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com From: Dan Carpenter There is a missing break statement so FLASH_5762_EEPROM_HD gets treated like FLASH_5762_EEPROM_LD. Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller BugLink: http://bugs.launchpad.net/bugs/1178899 (cherry-picked from commit 17e1a42f2e377ec5809af79eb651d9ed5958fb97 upstream) Signed-off-by: Stefan Bader --- drivers/net/ethernet/broadcom/tg3.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index dece073..dc4c7780 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -13761,8 +13761,10 @@ static void tg3_get_5720_nvram_info(struct tg3 *tp) switch (nvmpinstrp) { case FLASH_5762_EEPROM_HD: nvmpinstrp = FLASH_5720_EEPROM_HD; + break; case FLASH_5762_EEPROM_LD: nvmpinstrp = FLASH_5720_EEPROM_LD; + break; } }