diff mbox

[2/2] UBUNTU: [Config] build-in uinput module

Message ID 1282125271.46458.748451972634.2.gpush@pororo
State Accepted
Delegated to: Leann Ogasawara
Headers show

Commit Message

Jeremy Kerr Aug. 18, 2010, 9:54 a.m. UTC
The bluetooth userspace tools can use /dev/uinput to report events
from bluetooth input devices (eg volume up/down controls on a BT
headset).

However, the uinput module is not loaded automatically, as there is no
physical device to match on. Consequently, we don't have the uinput
device node present when the bluetooth daemon starts, and no synthesized
BT events are reported.

Instead of compiling uinput as a module, this change builds it into the
kernel, so it is always available.

BugLink: http://bugs.launchpad.net/bugs/584812

Signed-off-by: Jeremy Kerr <jeremy.kerr@canonical.com>

---
 debian.master/config/config.common.ports  |    2 +-
 debian.master/config/config.common.ubuntu |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Tim Gardner Aug. 18, 2010, 1:05 p.m. UTC | #1
On 08/18/2010 03:54 AM, Jeremy Kerr wrote:
> The bluetooth userspace tools can use /dev/uinput to report events
> from bluetooth input devices (eg volume up/down controls on a BT
> headset).
>
> However, the uinput module is not loaded automatically, as there is no
> physical device to match on. Consequently, we don't have the uinput
> device node present when the bluetooth daemon starts, and no synthesized
> BT events are reported.
>
> Instead of compiling uinput as a module, this change builds it into the
> kernel, so it is always available.
>
> BugLink: http://bugs.launchpad.net/bugs/584812
>
> Signed-off-by: Jeremy Kerr<jeremy.kerr@canonical.com>
>
> ---
>   debian.master/config/config.common.ports  |    2 +-
>   debian.master/config/config.common.ubuntu |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports
> index a983a52..95bb3c8 100644
> --- a/debian.master/config/config.common.ports
> +++ b/debian.master/config/config.common.ports
> @@ -1515,7 +1515,7 @@ CONFIG_INPUT_TWL4030_PWRBUTTON=m
>   CONFIG_INPUT_TWL4030_VIBRA=m
>   CONFIG_INPUT_WM831X_ON=m
>   CONFIG_INPUT_YEALINK=m
> -CONFIG_INPUT_UINPUT=m
> +CONFIG_INPUT_UINPUT=y
>   CONFIG_IOMMU_API=y
>   CONFIG_IOMMU_HELPER=y
>   CONFIG_IOSAPIC=y
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 9e40bac..7a84e2b 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -1966,7 +1966,7 @@ CONFIG_INPUT_SPARSEKMAP=m
>   CONFIG_INPUT_TABLET=y
>   CONFIG_INPUT_TWL4030_PWRBUTTON=m
>   CONFIG_INPUT_TWL4030_VIBRA=m
> -CONFIG_INPUT_UINPUT=m
> +CONFIG_INPUT_UINPUT=y
>   CONFIG_INPUT_WINBOND_CIR=m
>   CONFIG_INPUT_WISTRON_BTNS=m
>   CONFIG_INPUT_WM831X_ON=m
>

Again, the implication is that this patch is for Maverick. Should this 
config option be added to the enforcer so we don't lose it in subsequent 
releases?

Acked-by: Tim Gardner <tim.gardner@canonical.com>
Leann Ogasawara Aug. 19, 2010, 11:58 p.m. UTC | #2
Applied to Maverick linux master.

Thanks,
Leann

On Wed, 2010-08-18 at 17:54 +0800, Jeremy Kerr wrote:
> The bluetooth userspace tools can use /dev/uinput to report events
> from bluetooth input devices (eg volume up/down controls on a BT
> headset).
> 
> However, the uinput module is not loaded automatically, as there is no
> physical device to match on. Consequently, we don't have the uinput
> device node present when the bluetooth daemon starts, and no synthesized
> BT events are reported.
> 
> Instead of compiling uinput as a module, this change builds it into the
> kernel, so it is always available.
> 
> BugLink: http://bugs.launchpad.net/bugs/584812
> 
> Signed-off-by: Jeremy Kerr <jeremy.kerr@canonical.com>
> 
> ---
>  debian.master/config/config.common.ports  |    2 +-
>  debian.master/config/config.common.ubuntu |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports
> index a983a52..95bb3c8 100644
> --- a/debian.master/config/config.common.ports
> +++ b/debian.master/config/config.common.ports
> @@ -1515,7 +1515,7 @@ CONFIG_INPUT_TWL4030_PWRBUTTON=m
>  CONFIG_INPUT_TWL4030_VIBRA=m
>  CONFIG_INPUT_WM831X_ON=m
>  CONFIG_INPUT_YEALINK=m
> -CONFIG_INPUT_UINPUT=m
> +CONFIG_INPUT_UINPUT=y
>  CONFIG_IOMMU_API=y
>  CONFIG_IOMMU_HELPER=y
>  CONFIG_IOSAPIC=y
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 9e40bac..7a84e2b 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -1966,7 +1966,7 @@ CONFIG_INPUT_SPARSEKMAP=m
>  CONFIG_INPUT_TABLET=y
>  CONFIG_INPUT_TWL4030_PWRBUTTON=m
>  CONFIG_INPUT_TWL4030_VIBRA=m
> -CONFIG_INPUT_UINPUT=m
> +CONFIG_INPUT_UINPUT=y
>  CONFIG_INPUT_WINBOND_CIR=m
>  CONFIG_INPUT_WISTRON_BTNS=m
>  CONFIG_INPUT_WM831X_ON=m
>
diff mbox

Patch

diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports
index a983a52..95bb3c8 100644
--- a/debian.master/config/config.common.ports
+++ b/debian.master/config/config.common.ports
@@ -1515,7 +1515,7 @@  CONFIG_INPUT_TWL4030_PWRBUTTON=m
 CONFIG_INPUT_TWL4030_VIBRA=m
 CONFIG_INPUT_WM831X_ON=m
 CONFIG_INPUT_YEALINK=m
-CONFIG_INPUT_UINPUT=m
+CONFIG_INPUT_UINPUT=y
 CONFIG_IOMMU_API=y
 CONFIG_IOMMU_HELPER=y
 CONFIG_IOSAPIC=y
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 9e40bac..7a84e2b 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -1966,7 +1966,7 @@  CONFIG_INPUT_SPARSEKMAP=m
 CONFIG_INPUT_TABLET=y
 CONFIG_INPUT_TWL4030_PWRBUTTON=m
 CONFIG_INPUT_TWL4030_VIBRA=m
-CONFIG_INPUT_UINPUT=m
+CONFIG_INPUT_UINPUT=y
 CONFIG_INPUT_WINBOND_CIR=m
 CONFIG_INPUT_WISTRON_BTNS=m
 CONFIG_INPUT_WM831X_ON=m