From patchwork Tue Aug 3 15:34:11 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leann Ogasawara X-Patchwork-Id: 60771 X-Patchwork-Delegate: leann.ogasawara@canonical.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id E68AEB70A8 for ; Wed, 4 Aug 2010 01:34:26 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1OgJVU-0005Tu-LX; Tue, 03 Aug 2010 16:34:20 +0100 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1OgJVS-0005TM-Lf for kernel-team@lists.ubuntu.com; Tue, 03 Aug 2010 16:34:18 +0100 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1OgJVS-0002hd-KE; Tue, 03 Aug 2010 16:34:18 +0100 Received: from c-76-105-148-120.hsd1.or.comcast.net ([76.105.148.120] helo=[192.168.1.4]) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1OgJVS-00005G-6h; Tue, 03 Aug 2010 16:34:18 +0100 Subject: Re: Please cherry-pick audio patch for Dell Optiplex From: Leann Ogasawara To: David Henningsson In-Reply-To: <4C57CA36.5060309@canonical.com> References: <4C57CA36.5060309@canonical.com> Date: Tue, 03 Aug 2010 08:34:11 -0700 Message-ID: <1280849651.25461.10386.camel@emiko> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Cc: kernel-team@lists.ubuntu.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com On Tue, 2010-08-03 at 09:50 +0200, David Henningsson wrote: > I would like us to cherry-pick commit b08b1637ce from > git.kernel.org/linux/kernel/git/tiwai/sound-2.6.git, put it into > Maverick, test it there for a month or two and assuming no regressions, > I'll submit it to stable@kernel.org and it'll reach Lucid that way. It's > in Takashi's tree, so it will be in 2.6.36. > > If applied, it will fix playback on several Dell Optiplex machines and > some others. There is a theoretical risc for regressions for people > having ALC268 chips with broken BIOSes, but I believe it is very small, > but still that's why I would like some testing in Maverick first. > > (If the patch does not apply cleanly, apply 5d4abf93 first.) Hi David, Is there a bug in Launchpad open to track this issue? ie. is there confirmation that this indeed resolves the issue? Care to also add your SOB (signed-off-by) to this for Maverick? Also, I'm just inlining the patch in question below for ease of review: >From b08b1637ce1c0196970348bcabf40f04b6b3d58e Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Fri, 30 Jul 2010 14:08:25 +0200 Subject: [PATCH] ALSA: hda - Handle pin NID 0x1a on ALC259/269 The pin NID 0x1a should be handled as well as NID 0x1b. Also added comments. Signed-off-by: Takashi Iwai Signed-off-by: David Henningsson --- sound/pci/hda/patch_realtek.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4d3a6f0..ce6c3a9 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -13158,7 +13158,8 @@ static int alc268_new_analog_output(struct alc_spec *spec, hda_nid_t nid, dac = 0x02; break; case 0x15: - case 0x1b: + case 0x1a: /* ALC259/269 only */ + case 0x1b: /* ALC259/269 only */ case 0x21: /* ALC269vb has this pin, too */ dac = 0x03; break;