From patchwork Tue Jul 20 10:51:35 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Conklin X-Patchwork-Id: 59300 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id A7AB7B6EF7 for ; Tue, 20 Jul 2010 20:51:55 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1ObAQP-00081d-6J; Tue, 20 Jul 2010 11:51:49 +0100 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1ObAQF-0007za-6E for kernel-team@lists.ubuntu.com; Tue, 20 Jul 2010 11:51:39 +0100 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1ObAQF-0004e0-4l for ; Tue, 20 Jul 2010 11:51:39 +0100 Received: from [193.85.232.179] (helo=canonical.com) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1ObAQF-0002p7-1q for kernel-team@lists.ubuntu.com; Tue, 20 Jul 2010 11:51:39 +0100 From: Steve Conklin To: kernel-team@lists.ubuntu.com Subject: [Lucid SRU 5/5] x86, ptrace: Remove set_stopped_child_used_math() in [x]fpregs_set Date: Tue, 20 Jul 2010 12:51:35 +0200 Message-Id: <1279623095-7773-6-git-send-email-sconklin@canonical.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1279623095-7773-1-git-send-email-sconklin@canonical.com> References: <1279623095-7773-1-git-send-email-sconklin@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com From: Suresh Siddha BugLink: http://bugs.launchpad.net/bugs/607653 init_fpu() already ensures that the used_math() is set for the stopped child. Remove the redundant set_stopped_child_used_math() in [x]fpregs_set() Reported-by: Oleg Nesterov Signed-off-by: Suresh Siddha LKML-Reference: <20100222225240.642169080@sbs-t61.sc.intel.com> Acked-by: Rolan McGrath Signed-off-by: H. Peter Anvin From upstream commit 6dbbe14f21368a45aedba7eab0221857b8ad8d16 Signed-off-by: Steve Conklin --- arch/x86/kernel/i387.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/i387.c b/arch/x86/kernel/i387.c index 81e23bf..c01a2b8 100644 --- a/arch/x86/kernel/i387.c +++ b/arch/x86/kernel/i387.c @@ -209,8 +209,6 @@ int xfpregs_set(struct task_struct *target, const struct user_regset *regset, if (ret) return ret; - set_stopped_child_used_math(target); - ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &target->thread.xstate->fxsave, 0, -1); @@ -471,8 +469,6 @@ int fpregs_set(struct task_struct *target, const struct user_regset *regset, if (ret) return ret; - set_stopped_child_used_math(target); - if (!HAVE_HWFP) return fpregs_soft_set(target, regset, pos, count, kbuf, ubuf);