Message ID | 1273085040-29931-1-git-send-email-chase.douglas@canonical.com |
---|---|
State | Accepted |
Delegated to: | Stefan Bader |
Headers | show |
On Wed, May 5, 2010 at 2:44 PM, Chase Douglas <chase.douglas@canonical.com> wrote: > SRU Jusitification: > > Impact: Without this change, a flavour may be created without > POSIX ACL support in /dev. This prevents some devices from > functioning. > > How Addressed: The change adds an enforcement statement. > > Regression Potential: This is a build system change, so as > long as the kernel builds there is no regression. > > ===== > > Some /dev nodes, like /dev/dsp, require POSIX ACLs. This change > enforces this setting. > > BugLink: http://bugs.launchpad.net/bugs/575940 > > Signed-off-by: Chase Douglas <chase.douglas@canonical.com> > --- > debian/config/enforce | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/debian/config/enforce b/debian/config/enforce > index 8180e94..80be985 100644 > --- a/debian/config/enforce > +++ b/debian/config/enforce > @@ -30,6 +30,9 @@ value CONFIG_USB_DEVICEFS n > value CONFIG_DEVTMPFS y > value CONFIG_DEVTMPFS_MOUNT y > > +# some /dev nodes require POSIX ACLs, like /dev/dsp > +value CONFIG_TMPFS_POSIX_ACL y > + > # Ramdisk size should be a minimum of 64M > value CONFIG_BLK_DEV_RAM_SIZE 65536 > > -- > 1.7.0.4 Please consider for Maverick as well. Thanks, -- Chase
Looks quite reasonable. On 05/05/2010 08:44 PM, Chase Douglas wrote: > SRU Jusitification: > > Impact: Without this change, a flavour may be created without > POSIX ACL support in /dev. This prevents some devices from > functioning. > > How Addressed: The change adds an enforcement statement. > > Regression Potential: This is a build system change, so as > long as the kernel builds there is no regression. > > ===== > > Some /dev nodes, like /dev/dsp, require POSIX ACLs. This change > enforces this setting. > > BugLink: http://bugs.launchpad.net/bugs/575940 > > Signed-off-by: Chase Douglas <chase.douglas@canonical.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- > debian/config/enforce | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/debian/config/enforce b/debian/config/enforce > index 8180e94..80be985 100644 > --- a/debian/config/enforce > +++ b/debian/config/enforce > @@ -30,6 +30,9 @@ value CONFIG_USB_DEVICEFS n > value CONFIG_DEVTMPFS y > value CONFIG_DEVTMPFS_MOUNT y > > +# some /dev nodes require POSIX ACLs, like /dev/dsp > +value CONFIG_TMPFS_POSIX_ACL y > + > # Ramdisk size should be a minimum of 64M > value CONFIG_BLK_DEV_RAM_SIZE 65536 >
On Wed, May 05, 2010 at 02:44:00PM -0400, Chase Douglas wrote: > SRU Jusitification: > > Impact: Without this change, a flavour may be created without > POSIX ACL support in /dev. This prevents some devices from > functioning. > > How Addressed: The change adds an enforcement statement. > > Regression Potential: This is a build system change, so as > long as the kernel builds there is no regression. > > ===== > > Some /dev nodes, like /dev/dsp, require POSIX ACLs. This change > enforces this setting. > > BugLink: http://bugs.launchpad.net/bugs/575940 > > Signed-off-by: Chase Douglas <chase.douglas@canonical.com> > --- > debian/config/enforce | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/debian/config/enforce b/debian/config/enforce > index 8180e94..80be985 100644 > --- a/debian/config/enforce > +++ b/debian/config/enforce > @@ -30,6 +30,9 @@ value CONFIG_USB_DEVICEFS n > value CONFIG_DEVTMPFS y > value CONFIG_DEVTMPFS_MOUNT y > > +# some /dev nodes require POSIX ACLs, like /dev/dsp > +value CONFIG_TMPFS_POSIX_ACL y > + > # Ramdisk size should be a minimum of 64M > value CONFIG_BLK_DEV_RAM_SIZE 65536 Seems to match the current settings on the main branches. Acked-by: Andy Whitcroft <apw@canonical.com> -apw
Applied to Lucid master
Applied to Maverick master. Thanks, Leann
===== Some /dev nodes, like /dev/dsp, require POSIX ACLs. This change enforces this setting. BugLink: http://bugs.launchpad.net/bugs/575940 Signed-off-by: Chase Douglas <chase.douglas@canonical.com> --- debian/config/enforce | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/debian/config/enforce b/debian/config/enforce index 8180e94..80be985 100644 --- a/debian/config/enforce +++ b/debian/config/enforce @@ -30,6 +30,9 @@ value CONFIG_USB_DEVICEFS n value CONFIG_DEVTMPFS y value CONFIG_DEVTMPFS_MOUNT y +# some /dev nodes require POSIX ACLs, like /dev/dsp +value CONFIG_TMPFS_POSIX_ACL y + # Ramdisk size should be a minimum of 64M value CONFIG_BLK_DEV_RAM_SIZE 65536