mbox series

[v1,0/2,SRU,J:linux-bluefield] mmc: dw_mmc-bluefield:

Message ID cover.1720642165.git.limings@nvidia.com
Headers show
Series mmc: dw_mmc-bluefield: | expand

Message

Liming Sun July 10, 2024, 8:26 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2072675

SRU Justification:

[Impact]
This is a cherry-pick fix from mmc upstream branch below to support
BF2 eMMC HW reset.
https://kernel.googlesource.com/pub/scm/linux/kernel/git/ulfh/mmc

[Fix]
BlueField-2 eMMC RST_N register is implemented as secure, thus the
default hw_reset() implementation won't work. This patch provides
platform specific hw_reset() which sends SMC call to ATF to update
the same RST_N register.

[Test Case]
Same functionality and testing as on BlueField-2 SoC.

[Regression Potential]
Same behavior from user perspective.

Liming Sun (2):
  [SRU][J:linux-bluefield] mmc: dw_mmc: Add support for platform
    specific eMMC HW reset
  [SRU][J:linux-bluefield] mmc: dw_mmc-bluefield: Add support for eMMC
    HW reset

 drivers/mmc/host/dw_mmc-bluefield.c | 18 +++++++++++++++++-
 drivers/mmc/host/dw_mmc.c           |  6 ++++++
 drivers/mmc/host/dw_mmc.h           |  2 ++
 3 files changed, 25 insertions(+), 1 deletion(-)

Comments

Manuel Diewald July 11, 2024, 2:31 p.m. UTC | #1 
On Wed, Jul 10, 2024 at 04:26:43PM -0400, Liming Sun wrote:
> BugLink: https://bugs.launchpad.net/bugs/2072675
> 
> SRU Justification:
> 
> [Impact]
> This is a cherry-pick fix from mmc upstream branch below to support
> BF2 eMMC HW reset.
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/ulfh/mmc
> 
> [Fix]
> BlueField-2 eMMC RST_N register is implemented as secure, thus the
> default hw_reset() implementation won't work. This patch provides
> platform specific hw_reset() which sends SMC call to ATF to update
> the same RST_N register.
> 
> [Test Case]
> Same functionality and testing as on BlueField-2 SoC.
> 
> [Regression Potential]
> Same behavior from user perspective.
> 
> Liming Sun (2):
>   [SRU][J:linux-bluefield] mmc: dw_mmc: Add support for platform
>     specific eMMC HW reset
>   [SRU][J:linux-bluefield] mmc: dw_mmc-bluefield: Add support for eMMC
>     HW reset
> 
>  drivers/mmc/host/dw_mmc-bluefield.c | 18 +++++++++++++++++-
>  drivers/mmc/host/dw_mmc.c           |  6 ++++++
>  drivers/mmc/host/dw_mmc.h           |  2 ++
>  3 files changed, 25 insertions(+), 1 deletion(-)
> 
> -- 
> 2.30.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Jammy needs to be nominated as the affected series in the tracking bug.

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Bartlomiej Zolnierkiewicz July 12, 2024, 9:36 a.m. UTC | #2 
On Wed, Jul 10, 2024 at 10:28 PM Liming Sun <limings@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2072675
>
> SRU Justification:
>
> [Impact]
> This is a cherry-pick fix from mmc upstream branch below to support
> BF2 eMMC HW reset.
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/ulfh/mmc
>
> [Fix]
> BlueField-2 eMMC RST_N register is implemented as secure, thus the
> default hw_reset() implementation won't work. This patch provides
> platform specific hw_reset() which sends SMC call to ATF to update
> the same RST_N register.
>
> [Test Case]
> Same functionality and testing as on BlueField-2 SoC.
>
> [Regression Potential]
> Same behavior from user perspective.
>
> Liming Sun (2):
>   [SRU][J:linux-bluefield] mmc: dw_mmc: Add support for platform
>     specific eMMC HW reset
>   [SRU][J:linux-bluefield] mmc: dw_mmc-bluefield: Add support for eMMC
>     HW reset
>
>  drivers/mmc/host/dw_mmc-bluefield.c | 18 +++++++++++++++++-
>  drivers/mmc/host/dw_mmc.c           |  6 ++++++
>  drivers/mmc/host/dw_mmc.h           |  2 ++
>  3 files changed, 25 insertions(+), 1 deletion(-)
>

Hi Liming,

Please resubmit as v2 with your additional Signed-off-by added
(besides being a commit author you're also a submitter of a
cherry-pick).

Also please add "mmc" in the cherry-pick line so we know which tree
the commit comes from (and that it is not upstream).

So S-o-B path for the first patch should look like:

Reviewed-by: David Thompson <davthompson@nvidia.com>
Signed-off-by: Liming Sun <limings@nvidia.com>
Link: https://lore.kernel.org/r/3df02ffa8bdaa74f5261c8914d2545b97fb3478a.1718213918.git.limings@nvidia.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
(cherry picked from commit f21adcb86653e2b2784bbc0f180c33
2b50c404df mmc)
Signed-off-by: Liming Sun <limings@nvidia.com>

Similarly for the second patch:

Reviewed-by: David Thompson <davthompson@nvidia.com>
Signed-off-by: Liming Sun <limings@nvidia.com>
Link: https://lore.kernel.org/r/2c459196c6867e325f9386ec0559efea464cfdd6.1718213918.git.limings@nvidia.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
(cherry picked from commit c17aecf85800ac91ec67fd71341075
26a4bab3b0 mmc)
Signed-off-by: Liming Sun <limings@nvidia.com>

--
Best regards,
Bartlomiej