mbox series

[SRU,J:linux-bluefield,v1,0/2] mlxbf_gige: replace SAUCE patch for pause frame counters

Message ID cover.1711563241.git.davthompson@nvidia.com
Headers show
Series mlxbf_gige: replace SAUCE patch for pause frame counters | expand

Message

David Thompson March 27, 2024, 6:25 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2059279

SRU Justification:

[Impact]
The support for mlxbf_gige pause frame counters was added to Jammy
via a SAUCE patch. After upstream review, a small issue was fixed
that makes the SAUCE patch different from the upstream commit.

[Fix]
The fix is to replace the SAUCE patch in the Jammy repo with
the upstream equivalent.

[Test Case]
* Boot BF platform and bring up "oob_net0" interface
* Execute the command "ethtool -I -a oob_net0" to get baseline stats
* Send heavy traffic into "oob_net0" interface
* Re-run the above ethtool command, noting the pause frame counters

[Regression Potential]
There is low potential for regression as this brings in upstream content.

[Other]
None

David Thompson (2):
  Revert "UBUNTU: SAUCE: mlxbf_gige: add support to display pause frame counters"
  mlxbf_gige: add support to display pause frame counters

 .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  | 19 ++++++++-----------
 .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     | 16 ++++++++++++----
 2 files changed, 20 insertions(+), 15 deletions(-)

Comments

Bartlomiej Zolnierkiewicz March 29, 2024, 5:31 p.m. UTC | #1 
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>

On Wed, Mar 27, 2024 at 7:26 PM David Thompson <davthompson@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2059279
>
> SRU Justification:
>
> [Impact]
> The support for mlxbf_gige pause frame counters was added to Jammy
> via a SAUCE patch. After upstream review, a small issue was fixed
> that makes the SAUCE patch different from the upstream commit.
>
> [Fix]
> The fix is to replace the SAUCE patch in the Jammy repo with
> the upstream equivalent.
>
> [Test Case]
> * Boot BF platform and bring up "oob_net0" interface
> * Execute the command "ethtool -I -a oob_net0" to get baseline stats
> * Send heavy traffic into "oob_net0" interface
> * Re-run the above ethtool command, noting the pause frame counters
>
> [Regression Potential]
> There is low potential for regression as this brings in upstream content.
>
> [Other]
> None
>
> David Thompson (2):
>   Revert "UBUNTU: SAUCE: mlxbf_gige: add support to display pause frame counters"
>   mlxbf_gige: add support to display pause frame counters
>
>  .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  | 19 ++++++++-----------
>  .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     | 16 ++++++++++++----
>  2 files changed, 20 insertions(+), 15 deletions(-)
>
Andrei Gherzan April 3, 2024, 3:30 p.m. UTC | #2 
On 24/03/27 02:25PM, David Thompson wrote:
> BugLink: https://bugs.launchpad.net/bugs/2059279
> 
> SRU Justification:
> 
> [Impact]
> The support for mlxbf_gige pause frame counters was added to Jammy
> via a SAUCE patch. After upstream review, a small issue was fixed
> that makes the SAUCE patch different from the upstream commit.
> 
> [Fix]
> The fix is to replace the SAUCE patch in the Jammy repo with
> the upstream equivalent.
> 
> [Test Case]
> * Boot BF platform and bring up "oob_net0" interface
> * Execute the command "ethtool -I -a oob_net0" to get baseline stats
> * Send heavy traffic into "oob_net0" interface
> * Re-run the above ethtool command, noting the pause frame counters
> 
> [Regression Potential]
> There is low potential for regression as this brings in upstream content.
> 
> [Other]
> None
> 
> David Thompson (2):
>   Revert "UBUNTU: SAUCE: mlxbf_gige: add support to display pause frame counters"
>   mlxbf_gige: add support to display pause frame counters
> 
>  .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  | 19 ++++++++-----------
>  .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     | 16 ++++++++++++----
>  2 files changed, 20 insertions(+), 15 deletions(-)

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Bartlomiej Zolnierkiewicz April 4, 2024, 9:54 a.m. UTC | #3 
Applied to jammy:linux-bluefield/master-next. Thanks.

--
Best regards,
Bartlomiej

On Wed, Mar 27, 2024 at 7:26 PM David Thompson <davthompson@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2059279
>
> SRU Justification:
>
> [Impact]
> The support for mlxbf_gige pause frame counters was added to Jammy
> via a SAUCE patch. After upstream review, a small issue was fixed
> that makes the SAUCE patch different from the upstream commit.
>
> [Fix]
> The fix is to replace the SAUCE patch in the Jammy repo with
> the upstream equivalent.
>
> [Test Case]
> * Boot BF platform and bring up "oob_net0" interface
> * Execute the command "ethtool -I -a oob_net0" to get baseline stats
> * Send heavy traffic into "oob_net0" interface
> * Re-run the above ethtool command, noting the pause frame counters
>
> [Regression Potential]
> There is low potential for regression as this brings in upstream content.
>
> [Other]
> None
>
> David Thompson (2):
>   Revert "UBUNTU: SAUCE: mlxbf_gige: add support to display pause frame counters"
>   mlxbf_gige: add support to display pause frame counters
>
>  .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  | 19 ++++++++-----------
>  .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     | 16 ++++++++++++----
>  2 files changed, 20 insertions(+), 15 deletions(-)
>