From patchwork Wed Apr 12 19:35:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liming Sun X-Patchwork-Id: 1768248 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=GgqA+VFV; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PxXxZ0yw7z1yhV for ; Thu, 13 Apr 2023 05:35:45 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1pmgFn-0005Tl-9h; Wed, 12 Apr 2023 19:35:39 +0000 Received: from mail-dm6nam12on2072.outbound.protection.outlook.com ([40.107.243.72] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1pmgFl-0005TZ-9l for kernel-team@lists.ubuntu.com; Wed, 12 Apr 2023 19:35:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ekfzrEuVDbhMOov3sFEJEWQkB6CkRlLB0TEUDDFSrbnLcE1bxEQ/YOi3fG/8WLan/INCrkeMiFtPL1zb3KbuvCbQorHCCXHr6QdtTe10KXNfUdl5vsc8RQBl3N8RjMRP1LdIM5K50jtbMdRX3BnkZyaEKt7i719IkNOlnkV2XBCJrg/GXw4SPnuLt0WK1SsHmjMLfzzCU/II8P4BSEy0g+EbgI2jzN1kveZoO8UGuLD0S3mYcVJESzAcsHyRCvgUqNZNTJUOywvYGT+tBxCjoJX8jBt8UHCzjty51847q2mVJJOAA+j8oyfMLkDL68uSTbtBsRqUe2YKAv2eOW9RAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8i3WHllsIX4TT8F4M1Qt9/OxpBP1rM28em/9H/WfHyk=; b=fwOUunNXfMo3h/2XTy1LK9SkPI0W8YHWlPXg05Si8RIkMMYy5vcF6zyMYTgKVU0XG/dT8J37EQ6iDa0IcBati17xZGzlx+wpVFWAbt31SKs9OJl3+U2Nu1HFU3zs5s8wMAHpL+iIjgqfOjwPwewgDnAmJwO8doyVcDtcuitfmHb3dezjDXHWGEHdFmTE90Jx/yaRrk9yDtUrHimE8Lok7IZDy0s2GYbcnhvYOt3yq2Uci1K7eVhdbtNUcxbCpJ37bQxiLRIrIvke3zjp89L1m+BRLDi6qvI0oddKbYIu3nU9Lt1Vo5KhuW0DHiajdLN3gsYkpf7uypaEaYft0DXDLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8i3WHllsIX4TT8F4M1Qt9/OxpBP1rM28em/9H/WfHyk=; b=GgqA+VFVGj6GC87OCfBX8GTag7wU72dq91Fgp68D15A76Td0Cilqan4+2z1+c62RWDiEtUif93xWCtZcihvNWAwLP886gBTe6bBNQKv9SilA3/JlduJY9JFIOHqPcJ8dDdqFVj7rbUsFNYZXzpjUwqIcAkdZPki0MFqm01UKQ/QpIwKhbjwhq0fSToSqUxtU54y4TjRAbPwuQUN1ar92bGaVhdCai+vYPduDWI2cRKtMIIgvUJqOWvT7wWKVbdskk6p9nIHvHjbPLlO4BxJZfVzCkNHUhCgf+hG1YfwEMeOv+MXvWH0+ASqPohm3AvClsjqKlNdVjDpe6NPUuttsOg== Received: from MW4PR04CA0032.namprd04.prod.outlook.com (2603:10b6:303:6a::7) by MN0PR12MB5905.namprd12.prod.outlook.com (2603:10b6:208:379::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Wed, 12 Apr 2023 19:35:34 +0000 Received: from CO1NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6a:cafe::25) by MW4PR04CA0032.outlook.office365.com (2603:10b6:303:6a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Wed, 12 Apr 2023 19:35:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT056.mail.protection.outlook.com (10.13.175.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Wed, 12 Apr 2023 19:35:33 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 12 Apr 2023 12:35:16 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 12 Apr 2023 12:35:16 -0700 Received: from vdi.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Wed, 12 Apr 2023 12:35:15 -0700 From: Liming Sun To: Subject: [PATCH v1 0/1] [SRU][J:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: mlxbf-tmfifo: fix potential race Date: Wed, 12 Apr 2023 15:35:01 -0400 Message-ID: X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT056:EE_|MN0PR12MB5905:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e56d2aa-654b-4b2b-8390-08db3b8d1550 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ywhOOx9RGEUTlmHmDnqqtYhYoTNl+pBOZQcN4VNnghcFQd388+dMxvzP/CZo0NwQ+y0o5u+H6hYgWKsnYWvP61Ndg/zrSzcwU+a6+W7VNwyS3XaMAXT2bhsDl6EHFHOqQKVoPkpxOCDBrGgkhTzaP+nVDcPPTBG58l+QZWQSHBiF2RkwclUDXLk3aj1Ech8TYCqkQaoX9P0fWa5FCXBevOGrGx9OkKtnhEN74KWG07sju0aDikqN3+Zdj4YlzPd6zpIAQoZ75pyvPAbsYFfhtjmA6cfeJwlPCgmpyXg+FBjyh3wuwmkveRVpCWPWJJGOYv9zUW0Tr6DVSjz4SlNyqQ4GUt0Igu24Uq6X766j25n+WqZP/FDHfhFi73ueoYHeDEQ30afZRRXHjDTZI6cwAzRcy8sYzcKbAXTpxX9K271pvjiVcCebHsNHA9/p3uDLAeo/fyp1AnE++ib+jtvJoKOdlo8qi5k4CHb2cRQ5WWXsR4xjdOyS0xvAnK0WO17X1XRzHr9x9wbv0CKXfPYNbJszhJPPZs0KodgXxnfLh0k+DhLCicckzi3CQjrKpSI63JRbGaLP+IDWzE1nrTrQNSbenlHMDwjc+PtxRt+42b6gOqnWdCp34lBE1r36KA5j8TF9G4yubG/jclO6NVtRzo2NKsjijeCfZeeQB6DIKu3qJissZbxD44rhjyXeuhYypc9hHHyIZSDhuUl9XkyAiEU8YH44Ga6PbmXHM+jOa/mK/trklwya5mMP+MBv1KvIfYvQtlbqrJlsHCCfGJowDiKYyBHds5HzlwTbXzvEwltnDxV0BA6+Nd1JQGN97xm4x1tHUmHPW0T6Sz+2IPdgvA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(346002)(396003)(376002)(136003)(451199021)(46966006)(40470700004)(36840700001)(316002)(82310400005)(26005)(82740400003)(34020700004)(36860700001)(356005)(7636003)(6916009)(8676002)(86362001)(70586007)(70206006)(478600001)(4326008)(47076005)(426003)(336012)(186003)(2616005)(36756003)(41300700001)(2906002)(83380400001)(7696005)(40460700003)(4744005)(40480700001)(8936002)(6666004)(107886003)(5660300002)(966005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 19:35:33.5989 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e56d2aa-654b-4b2b-8390-08db3b8d1550 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5905 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Liming Sun Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2016039 SRU Justification: [Impact] This change is needed to avoid potential race of accessing the 'vq' pointer [Fix] The fix adds memory barrier for the is_ready flag and the 'vq' pointer access in mlxbf_tmfifo_virtio_find_vqs(), so updated in vq will be visible before accessing this pointer. [Test Case] Same functionality and testing as on BlueField-1/2/3. No functionality change. [Regression Potential] Same behavior from user perspective Liming Sun (1): mlxbf-tmfifo: fix potential race drivers/platform/mellanox/mlxbf-tmfifo.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) Acked-by: Bartlomiej Zolnierkiewicz