mbox series

[0/1,linux-5.15] trace events WARN

Message ID cover.1661651934.git.kjlx@templeofstupid.com
Headers show
Series trace events WARN | expand

Message

Krister Johansen Aug. 28, 2022, 2:02 a.m. UTC 
Dear Ubuntu Kernel Team:

I'm requesting a cherry-pick of a patch that has been merged to both Linus's
tree and the 5.15 stable branches.  It showed up for my team on
linux-aws-5.15.0-1015, but I believe that it's common to all 5.15-based
releases.

This bug results in a WARN about an incorrect reference count if a program that
is configuring uprobes receives a signal before it can complete the uprobe
setup.  I believe that I have followed the KernelPatches procedure documented
here (https://wiki.ubuntu.com/Kernel/Dev/KernelPatches).  I've tested this patch
on an Ubuntu 5.15 branch as well as mainline.

The issue is tracked in Launchpad as bug 1987232
(https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1987232)

The impact for my team is that we see this WARN many times a day and it does get
picked up by our logging that tracks potential kernel problems.  If you'd be
willing to target this at an upcoming 5.15 SRU release ahead of adopting the
stable release that it's in right now, I'd be much obliged.

Sincerely,

-K

Steven Rostedt (Google) (1):
  tracing/perf: Fix double put of trace event when init fails

 kernel/trace/trace_event_perf.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Tim Gardner Aug. 29, 2022, 12:37 p.m. UTC | #1 
On 8/27/22 20:02, Krister Johansen wrote:
> Dear Ubuntu Kernel Team:
> 
> I'm requesting a cherry-pick of a patch that has been merged to both Linus's
> tree and the 5.15 stable branches.  It showed up for my team on
> linux-aws-5.15.0-1015, but I believe that it's common to all 5.15-based
> releases.
> 
> This bug results in a WARN about an incorrect reference count if a program that
> is configuring uprobes receives a signal before it can complete the uprobe
> setup.  I believe that I have followed the KernelPatches procedure documented
> here (https://wiki.ubuntu.com/Kernel/Dev/KernelPatches).  I've tested this patch
> on an Ubuntu 5.15 branch as well as mainline.
> 
> The issue is tracked in Launchpad as bug 1987232
> (https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1987232)
> 
> The impact for my team is that we see this WARN many times a day and it does get
> picked up by our logging that tracks potential kernel problems.  If you'd be
> willing to target this at an upcoming 5.15 SRU release ahead of adopting the
> stable release that it's in right now, I'd be much obliged.
> 
> Sincerely,
> 
> -K
> 
> Steven Rostedt (Google) (1):
>    tracing/perf: Fix double put of trace event when init fails
> 
>   kernel/trace/trace_event_perf.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

Will also be included with v5.15.63 (whenever that gets applied)
Stefan Bader Sept. 14, 2022, 1:19 p.m. UTC | #2 
On 28.08.22 04:02, Krister Johansen wrote:
> Dear Ubuntu Kernel Team:
> 
> I'm requesting a cherry-pick of a patch that has been merged to both Linus's
> tree and the 5.15 stable branches.  It showed up for my team on
> linux-aws-5.15.0-1015, but I believe that it's common to all 5.15-based
> releases.
> 
> This bug results in a WARN about an incorrect reference count if a program that
> is configuring uprobes receives a signal before it can complete the uprobe
> setup.  I believe that I have followed the KernelPatches procedure documented
> here (https://wiki.ubuntu.com/Kernel/Dev/KernelPatches).  I've tested this patch
> on an Ubuntu 5.15 branch as well as mainline.
> 
> The issue is tracked in Launchpad as bug 1987232
> (https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1987232)
> 
> The impact for my team is that we see this WARN many times a day and it does get
> picked up by our logging that tracks potential kernel problems.  If you'd be
> willing to target this at an upcoming 5.15 SRU release ahead of adopting the
> stable release that it's in right now, I'd be much obliged.
> 
> Sincerely,
> 
> -K
> 
> Steven Rostedt (Google) (1):
>    tracing/perf: Fix double put of trace event when init fails
> 
>   kernel/trace/trace_event_perf.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 

Applied to jammy:linux/master-next. Thanks.

-Stefan