mbox series

[SRU,Bionic,Cosmic,0/1] s390/qeth: use vzalloc for QUERY OAT buffer

Message ID cover.1537258865.git.joseph.salisbury@canonical.com
Headers show
Series s390/qeth: use vzalloc for QUERY OAT buffer | expand

Message

Joseph Salisbury Sept. 20, 2018, 9:31 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1793086

== SRU Justification ==
IBM reports the qethqoat tool fails.  qeth_query_oat_command() currently 
allocates the kernel buffer for the SIOC_QETH_QUERY_OAT ioctl with kzalloc.

This commit will cause the use of vzalloc() instead of kzalloc(), backing 
the allocation with non-contiguous memory.

Xenial also needs this commit, but requres a slightly different
backport.  It's SRU will be sent separate.

== Fix ==
aec45e857c55 ("s390/qeth: use vzalloc for QUERY OAT buffer")

== Regression Potential ==
Low, limited to s390.

== Test Case ==
IBM verified testing of this commit up-front.

Wenjia Zhang (1):
  s390/qeth: use vzalloc for QUERY OAT buffer

 drivers/s390/net/qeth_core_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Stefan Bader Oct. 1, 2018, 3:27 p.m. UTC | #1
On 20.09.2018 11:31, Joseph Salisbury wrote:
> BugLink: https://bugs.launchpad.net/bugs/1793086
> 
> == SRU Justification ==
> IBM reports the qethqoat tool fails.  qeth_query_oat_command() currently 
> allocates the kernel buffer for the SIOC_QETH_QUERY_OAT ioctl with kzalloc.
> 
> This commit will cause the use of vzalloc() instead of kzalloc(), backing 
> the allocation with non-contiguous memory.
> 
> Xenial also needs this commit, but requres a slightly different
> backport.  It's SRU will be sent separate.
> 
> == Fix ==
> aec45e857c55 ("s390/qeth: use vzalloc for QUERY OAT buffer")
> 
> == Regression Potential ==
> Low, limited to s390.
> 
> == Test Case ==
> IBM verified testing of this commit up-front.
> 
> Wenjia Zhang (1):
>   s390/qeth: use vzalloc for QUERY OAT buffer
> 
>  drivers/s390/net/qeth_core_main.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
Applied to bionic/master-next. Thanks.

-Stefan
Thadeu Lima de Souza Cascardo Oct. 2, 2018, 12:06 p.m. UTC | #2
Applied to cosmic master-next. Unstable already has it.

Thanks.
Cascardo.

Applied-to: cosmic/master-next