From patchwork Mon Nov 5 18:21:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Heimes X-Patchwork-Id: 993298 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42pgxl3pLZz9sN6; Tue, 6 Nov 2018 05:22:03 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1gJjVb-0006vz-Vn; Mon, 05 Nov 2018 18:21:55 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1gJjVa-0006vs-OH for kernel-team@lists.ubuntu.com; Mon, 05 Nov 2018 18:21:54 +0000 Received: from mail-lf1-f71.google.com ([209.85.167.71]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gJjVa-0005EQ-GF for kernel-team@lists.ubuntu.com; Mon, 05 Nov 2018 18:21:54 +0000 Received: by mail-lf1-f71.google.com with SMTP id g1-v6so1170211lfl.23 for ; Mon, 05 Nov 2018 10:21:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=p75k2HbMLIapHTE/yUCPWY7WjYP6M2i6TsfTSPXTnnk=; b=MM3CNb6W0/tmJ/iUvfBQBeSDnWSOL4uZwP/ThgqHVhcfjUJzoHLcStZVZQwDy6tSHG MC3/4CkKUWqcqY5BkSn4EB4+CEWvJx3cgo+do/lUP6dhkeX/CO0xsJDV++L6fhVzoGUt Rt/6RvJSuZ7HgXsn2ZGzyawKAPArLS0CIdxZ2W2lMLESNavZA5o+B+wfBYuPK9tUrrt9 Vr8pFHzMj70kMkeNC5pXx8+9tqippXI1+Sl8f582xlBmlX4bjDoBw/ViWeiFZ7gSfPI+ iXZKsuowjlTmAtEqYz2thE5lK7jVzpIZjcpq7BKLi22jBeQ0qwO82oS2/k7k9z8jbj7E oFqA== X-Gm-Message-State: AGRZ1gKSremBqBIYuSTut8bdUQqLFmgQWXpzQHwF814kqwPU+IgeXn+8 h7MtRIdivUqsoVltA5m8Pnusg2QH0rPLzfz5KWL9uT8OIxSjkARhXvDJTEVssiXb91qNQyAmSCw MUEOi+BEXXOJZYHhIMJ5XSCE27cIVviedx+psQkDEfsjpRVEk+WUyT9i0tQ== X-Received: by 2002:a2e:9a56:: with SMTP id k22-v6mr11353280ljj.17.1541442113190; Mon, 05 Nov 2018 10:21:53 -0800 (PST) X-Google-Smtp-Source: AJdET5cwDkvV7ezc7GJcbl8zkiL2xesUc7fk5jHWA0lcSKIFSPlJjQOPvPQwsaqAcEw1Wq72Jnm1g7W8vZ0SZFINCUQ= X-Received: by 2002:a2e:9a56:: with SMTP id k22-v6mr11353271ljj.17.1541442112831; Mon, 05 Nov 2018 10:21:52 -0800 (PST) MIME-Version: 1.0 From: Frank Heimes Date: Mon, 5 Nov 2018 19:21:41 +0100 Message-ID: Subject: [SRU][Cosmic][Bionic][Xenial][PATCH 0/1] Fixes for LP1801686 To: kernel-team@lists.ubuntu.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: http://bugs.launchpad.net/bugs/1801686 == SRU Justification == Description: qdio: reset old sbal_state flags Symptom: af_iucv socket using HiperSockets may stall. Problem: When allocating a new AOB fails, handle_outbound() is still capable of transmitting the selected buffer (just without async completion). But if a previous transfer on this queue slot used async completion, its sbal_state flags field is still set to QDIO_OUTBUF_STATE_FLAG_PENDING. So when the upper layer driver sees this stale flag, it expects an async completion that never happens. Solution: Unconditionally clear the buffer's flags field. == Fix == 64e03ff72623b8c2ea89ca3cb660094e019ed4ae ("s390/qdio: reset old sbal_state flags") == Regression Potential == Low, because: - s390x only - further limited to qeth driver (OSA Express networking) - changes are limited to two files and 6 lines - arch/s390/include/asm/qdio.h b/arch/s390/include/asm/qdio.h - drivers/s390/cio/qdio_main.c b/drivers/s390/cio/qdio_main.c - error was identified at IBM/customer, fix was created there and tested upfront - (changes are upstream in 4.20 (according to bug description, but in 4.19 according to 'git tag'), hence will make it automatically into 'disco') == Test Case == Test case / reproduction: Error inject and then simulate out-of-memory situation.