mbox series

[0/9] UBUNTU: [Packaging] Refactor and test generate-control

Message ID 20241007160727.46074-1-agathe.porte@canonical.com
Headers show
Series UBUNTU: [Packaging] Refactor and test generate-control | expand

Message

Agathe Porte Oct. 7, 2024, 4:06 p.m. UTC 
The goal of this patch set is to introduce some Python testing for the
generate-control script (which becomes generate_control.py).

Agathe Porte (9):
  UBUNTU: [Packaging] generate-control: use stdin and stdout
  UBUNTU: [Packaging] introduce debian/scripts/test-generate-control.sh
  UBUNTU: [Packaging] generate-control: fix 'os' imported but unused
  UBUNTU: [Packaging] generate-control: reformat using black
  UBUNTU: [Packaging] generate-control: split into functions
  UBUNTU: [Packaging] generate-control: use full path to
    parameterise-ancillaries in comment
  UBUNTU: [Packaging] generate-control: rename to generate_control.py
  UBUNTU: [Packaging] generate_control.py: pass everything by argument
  UBUNTU: [Packaging] introduce test_generate_control.py

 debian/rules                            |   2 +-
 debian/scripts/generate-control         | 141 ---------------
 debian/scripts/generate_control.py      | 223 ++++++++++++++++++++++++
 debian/scripts/test-generate-control.sh |  17 ++
 debian/scripts/test_generate_control.py | 134 ++++++++++++++
 5 files changed, 375 insertions(+), 142 deletions(-)
 delete mode 100755 debian/scripts/generate-control
 create mode 100755 debian/scripts/generate_control.py
 create mode 100755 debian/scripts/test-generate-control.sh
 create mode 100644 debian/scripts/test_generate_control.py

Comments

Stefan Bader Oct. 8, 2024, 8:17 a.m. UTC | #1 
On 07.10.24 18:06, Agathe Porte wrote:
> The goal of this patch set is to introduce some Python testing for the
> generate-control script (which becomes generate_control.py).
> 
> Agathe Porte (9):
>    UBUNTU: [Packaging] generate-control: use stdin and stdout
>    UBUNTU: [Packaging] introduce debian/scripts/test-generate-control.sh
>    UBUNTU: [Packaging] generate-control: fix 'os' imported but unused
>    UBUNTU: [Packaging] generate-control: reformat using black
>    UBUNTU: [Packaging] generate-control: split into functions
>    UBUNTU: [Packaging] generate-control: use full path to
>      parameterise-ancillaries in comment
>    UBUNTU: [Packaging] generate-control: rename to generate_control.py
>    UBUNTU: [Packaging] generate_control.py: pass everything by argument
>    UBUNTU: [Packaging] introduce test_generate_control.py
> 
>   debian/rules                            |   2 +-
>   debian/scripts/generate-control         | 141 ---------------
>   debian/scripts/generate_control.py      | 223 ++++++++++++++++++++++++
>   debian/scripts/test-generate-control.sh |  17 ++
>   debian/scripts/test_generate_control.py | 134 ++++++++++++++
>   5 files changed, 375 insertions(+), 142 deletions(-)
>   delete mode 100755 debian/scripts/generate-control
>   create mode 100755 debian/scripts/generate_control.py
>   create mode 100755 debian/scripts/test-generate-control.sh
>   create mode 100644 debian/scripts/test_generate_control.py
> 

This (hopefully) should be targeting unstable to start happening in O+1

-Stefan
Agathe Porte Oct. 8, 2024, 8:28 a.m. UTC | #2 
Hello,

On 08/10/2024 10:17, Stefan Bader wrote:
> On 07.10.24 18:06, Agathe Porte wrote:
>> The goal of this patch set is to introduce some Python testing for the
>> generate-control script (which becomes generate_control.py).
> This (hopefully) should be targeting unstable to start happening in O+1

Correct, I forgot to add [unstable] in the subject for this one.

Agathe.
Agathe Porte Oct. 8, 2024, 8:48 a.m. UTC | #3 
2024-10-07 18:08 CEST, Agathe Porte:
> The goal of this patch set is to introduce some Python testing for the
> generate-control script (which becomes generate_control.py).
> 
> Agathe Porte (9):
>   UBUNTU: [Packaging] generate-control: use stdin and stdout
>   UBUNTU: [Packaging] introduce debian/scripts/test-generate-control.sh
>   UBUNTU: [Packaging] generate-control: fix 'os' imported but unused
>   UBUNTU: [Packaging] generate-control: reformat using black
>   UBUNTU: [Packaging] generate-control: split into functions
>   UBUNTU: [Packaging] generate-control: use full path to
>     parameterise-ancillaries in comment
>   UBUNTU: [Packaging] generate-control: rename to generate_control.py
>   UBUNTU: [Packaging] generate_control.py: pass everything by argument
>   UBUNTU: [Packaging] introduce test_generate_control.py
> 
>  debian/rules                            |   2 +-
>  debian/scripts/generate-control         | 141 ---------------
>  debian/scripts/generate_control.py      | 223 ++++++++++++++++++++++++
>  debian/scripts/test-generate-control.sh |  17 ++
>  debian/scripts/test_generate_control.py | 134 ++++++++++++++
>  5 files changed, 375 insertions(+), 142 deletions(-)
>  delete mode 100755 debian/scripts/generate-control
>  create mode 100755 debian/scripts/generate_control.py
>  create mode 100755 debian/scripts/test-generate-control.sh
>  create mode 100644 debian/scripts/test_generate_control.py

Will send v2 with proper subject to match people’s email filters and
make sure this is read by unstable folks.