| Message ID | 20240906175919.773606-1-vinicius.peixoto@canonical.com |
|---|---|
| Headers | show |
| Series | net: mana: Fix RX buf alloc_size alignment and atomic op panic | expand |
This patch has been into v6.11-rc4 and so was picked up by Ubuntu-6.11.0-{4,5,6}
so I don't think applying it to oracular is useful, it will be picked up on next rebase.
For J/N : Acked-by: Thibault Ferrante <thibault.ferrante@canonical.com>
On 06-09-2024 19:59, Vinicius Peixoto wrote:
> BugLink: https://bugs.launchpad.net/bugs/2079854
>
> [Impact]
>
> Microsoft has requested us to backport the following bugfix:
>
> 32316f676b4e ("net: mana: Fix RX buf alloc_size alignment and atomic op panic")
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=32316f676b4e
>
> [Fix]
>
> Clean-cherry pick to the trees (oracular/noble/jammy) containing the
> following break commit:
> 80f6215b450e ("net: mana: Add support for jumbo frame")
>
> [Test plan]
>
> Compile tested only.
>
> [Where problems could occur]
>
> This is a minor adjustment to the allocated size for MANA RX buffers,
> fixing the alignment of the resulting SKB in order to improve performance
> and avoid alignment faults during atomic operations on ARM64. As such,
> the regression risk seems to be low (especially considering the allocated
> size for the buffer will end up being bigger, not smaller), but any issues
> here would impact the reception of network packets in MANA.
>
> [Other info]
>
> SF #00394982
>
> v1 -> v2:
> - Fix cover letter subject
>
> Haiyang Zhang (1):
> net: mana: Fix RX buf alloc_size alignment and atomic op panic
>
> drivers/net/ethernet/microsoft/mana/mana_en.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Vinicius Peixoto kirjoitti 6.9.2024 klo 20.59: > BugLink: https://bugs.launchpad.net/bugs/2079854 > > [Impact] > > Microsoft has requested us to backport the following bugfix: > > 32316f676b4e ("net: mana: Fix RX buf alloc_size alignment and atomic op panic") > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=32316f676b4e > > [Fix] > > Clean-cherry pick to the trees (oracular/noble/jammy) containing the > following break commit: > 80f6215b450e ("net: mana: Add support for jumbo frame") > > [Test plan] > > Compile tested only. > > [Where problems could occur] > > This is a minor adjustment to the allocated size for MANA RX buffers, > fixing the alignment of the resulting SKB in order to improve performance > and avoid alignment faults during atomic operations on ARM64. As such, > the regression risk seems to be low (especially considering the allocated > size for the buffer will end up being bigger, not smaller), but any issues > here would impact the reception of network packets in MANA. > > [Other info] > > SF #00394982 > > v1 -> v2: > - Fix cover letter subject > > Haiyang Zhang (1): > net: mana: Fix RX buf alloc_size alignment and atomic op panic > > drivers/net/ethernet/microsoft/mana/mana_en.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > As Thibault mentioned, this is already in oracular:linux.
On 9/6/24 12:59 PM, Vinicius Peixoto wrote: > BugLink: https://bugs.launchpad.net/bugs/2079854 > > [Impact] > > Microsoft has requested us to backport the following bugfix: > > 32316f676b4e ("net: mana: Fix RX buf alloc_size alignment and atomic op panic") > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=32316f676b4e > > [Fix] > > Clean-cherry pick to the trees (oracular/noble/jammy) containing the > following break commit: > 80f6215b450e ("net: mana: Add support for jumbo frame") > > [Test plan] > > Compile tested only. > > [Where problems could occur] > > This is a minor adjustment to the allocated size for MANA RX buffers, > fixing the alignment of the resulting SKB in order to improve performance > and avoid alignment faults during atomic operations on ARM64. As such, > the regression risk seems to be low (especially considering the allocated > size for the buffer will end up being bigger, not smaller), but any issues > here would impact the reception of network packets in MANA. > > [Other info] > > SF #00394982 > > v1 -> v2: > - Fix cover letter subject > > Haiyang Zhang (1): > net: mana: Fix RX buf alloc_size alignment and atomic op panic > > drivers/net/ethernet/microsoft/mana/mana_en.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >
On 9/6/24 12:59 PM, Vinicius Peixoto wrote: > BugLink: https://bugs.launchpad.net/bugs/2079854 > > [Impact] > > Microsoft has requested us to backport the following bugfix: > > 32316f676b4e ("net: mana: Fix RX buf alloc_size alignment and atomic op panic") > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=32316f676b4e > > [Fix] > > Clean-cherry pick to the trees (oracular/noble/jammy) containing the > following break commit: > 80f6215b450e ("net: mana: Add support for jumbo frame") > > [Test plan] > > Compile tested only. > > [Where problems could occur] > > This is a minor adjustment to the allocated size for MANA RX buffers, > fixing the alignment of the resulting SKB in order to improve performance > and avoid alignment faults during atomic operations on ARM64. As such, > the regression risk seems to be low (especially considering the allocated > size for the buffer will end up being bigger, not smaller), but any issues > here would impact the reception of network packets in MANA. > > [Other info] > > SF #00394982 > > v1 -> v2: > - Fix cover letter subject > > Haiyang Zhang (1): > net: mana: Fix RX buf alloc_size alignment and atomic op panic > > drivers/net/ethernet/microsoft/mana/mana_en.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Dropped my signature... Acked-by: John Cabaj <john.cabaj@canonical.com>
On 9/6/24 12:59 PM, Vinicius Peixoto wrote: > BugLink: https://bugs.launchpad.net/bugs/2079854 > > [Impact] > > Microsoft has requested us to backport the following bugfix: > > 32316f676b4e ("net: mana: Fix RX buf alloc_size alignment and atomic op panic") > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=32316f676b4e > > [Fix] > > Clean-cherry pick to the trees (oracular/noble/jammy) containing the > following break commit: > 80f6215b450e ("net: mana: Add support for jumbo frame") > > [Test plan] > > Compile tested only. > > [Where problems could occur] > > This is a minor adjustment to the allocated size for MANA RX buffers, > fixing the alignment of the resulting SKB in order to improve performance > and avoid alignment faults during atomic operations on ARM64. As such, > the regression risk seems to be low (especially considering the allocated > size for the buffer will end up being bigger, not smaller), but any issues > here would impact the reception of network packets in MANA. > > [Other info] > > SF #00394982 > > v1 -> v2: > - Fix cover letter subject > > Haiyang Zhang (1): > net: mana: Fix RX buf alloc_size alignment and atomic op panic > > drivers/net/ethernet/microsoft/mana/mana_en.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Applied to noble:linux-azure and jammy:linux-azure master-next branches. John
BugLink: https://bugs.launchpad.net/bugs/2079854 [Impact] Microsoft has requested us to backport the following bugfix: 32316f676b4e ("net: mana: Fix RX buf alloc_size alignment and atomic op panic") https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=32316f676b4e [Fix] Clean-cherry pick to the trees (oracular/noble/jammy) containing the following break commit: 80f6215b450e ("net: mana: Add support for jumbo frame") [Test plan] Compile tested only. [Where problems could occur] This is a minor adjustment to the allocated size for MANA RX buffers, fixing the alignment of the resulting SKB in order to improve performance and avoid alignment faults during atomic operations on ARM64. As such, the regression risk seems to be low (especially considering the allocated size for the buffer will end up being bigger, not smaller), but any issues here would impact the reception of network packets in MANA. [Other info] SF #00394982 v1 -> v2: - Fix cover letter subject Haiyang Zhang (1): net: mana: Fix RX buf alloc_size alignment and atomic op panic drivers/net/ethernet/microsoft/mana/mana_en.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)