mbox series

[SRU,N,0/2] x86/vmware: Add TDX hypercall support

Message ID 20240830094540.2417681-1-thibault.ferrante@canonical.com
Headers show
Series x86/vmware: Add TDX hypercall support | expand

Message

Thibault Ferrante Aug. 30, 2024, 9:45 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2077729

[ Impact ]

VMware hypercalls use I/O port, VMCALL or VMMCALL instructions.
Add __tdx_hypercall path to support TDX guests.

[ Fix ]

Part of 6.11.
Require a another upstream commit.
Clean cherry-pick from upstream:
- 34bf25e820a x86/vmware: Introduce VMware hypercall API
- 57b7b6acb41 x86/vmware: Add TDX hypercall support

[ Test Plan ]

Compiled.

[ Where problems could occur ]

 Only added new interfaces, may change VM behavior related to VMware.

Alexey Makhalov (2):
  x86/vmware: Introduce VMware hypercall API
  x86/vmware: Add TDX hypercall support

 arch/x86/include/asm/vmware.h | 324 ++++++++++++++++++++++++++++++++--
 arch/x86/kernel/cpu/vmware.c  | 122 ++++++++++++-
 2 files changed, 424 insertions(+), 22 deletions(-)

Comments

Stefan Bader Sept. 25, 2024, 2:09 p.m. UTC | #1 
On 30.08.24 11:45, Thibault Ferrante wrote:
> BugLink: https://bugs.launchpad.net/bugs/2077729
> 
> [ Impact ]
> 
> VMware hypercalls use I/O port, VMCALL or VMMCALL instructions.
> Add __tdx_hypercall path to support TDX guests.
> 
> [ Fix ]
> 
> Part of 6.11.
> Require a another upstream commit.
> Clean cherry-pick from upstream:
> - 34bf25e820a x86/vmware: Introduce VMware hypercall API
> - 57b7b6acb41 x86/vmware: Add TDX hypercall support
> 
> [ Test Plan ]
> 
> Compiled.

We need something better than that. Though adding new interfaces sounds 
harmless it can have a bad outcome when running on ESX and having added 
it in a buggy way.

> 
> [ Where problems could occur ]
> 
>   Only added new interfaces, may change VM behavior related to VMware.
> 
> Alexey Makhalov (2):
>    x86/vmware: Introduce VMware hypercall API
>    x86/vmware: Add TDX hypercall support
> 
>   arch/x86/include/asm/vmware.h | 324 ++++++++++++++++++++++++++++++++--
>   arch/x86/kernel/cpu/vmware.c  | 122 ++++++++++++-
>   2 files changed, 424 insertions(+), 22 deletions(-)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Manuel Diewald Sept. 27, 2024, 8:36 a.m. UTC | #2 
On Fri, Aug 30, 2024 at 11:45:38AM +0200, Thibault Ferrante wrote:
> BugLink: https://bugs.launchpad.net/bugs/2077729
> 
> [ Impact ]
> 
> VMware hypercalls use I/O port, VMCALL or VMMCALL instructions.
> Add __tdx_hypercall path to support TDX guests.
> 
> [ Fix ]
> 
> Part of 6.11.
> Require a another upstream commit.
> Clean cherry-pick from upstream:
> - 34bf25e820a x86/vmware: Introduce VMware hypercall API
> - 57b7b6acb41 x86/vmware: Add TDX hypercall support
> 
> [ Test Plan ]
> 
> Compiled.
> 
> [ Where problems could occur ]
> 
>  Only added new interfaces, may change VM behavior related to VMware.
> 
> Alexey Makhalov (2):
>   x86/vmware: Introduce VMware hypercall API
>   x86/vmware: Add TDX hypercall support
> 
>  arch/x86/include/asm/vmware.h | 324 ++++++++++++++++++++++++++++++++--
>  arch/x86/kernel/cpu/vmware.c  | 122 ++++++++++++-
>  2 files changed, 424 insertions(+), 22 deletions(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Stefan Bader Sept. 27, 2024, 9:04 a.m. UTC | #3 
On 30.08.24 11:45, Thibault Ferrante wrote:
> BugLink: https://bugs.launchpad.net/bugs/2077729
> 
> [ Impact ]
> 
> VMware hypercalls use I/O port, VMCALL or VMMCALL instructions.
> Add __tdx_hypercall path to support TDX guests.
> 
> [ Fix ]
> 
> Part of 6.11.
> Require a another upstream commit.
> Clean cherry-pick from upstream:
> - 34bf25e820a x86/vmware: Introduce VMware hypercall API
> - 57b7b6acb41 x86/vmware: Add TDX hypercall support
> 
> [ Test Plan ]
> 
> Compiled.
> 
> [ Where problems could occur ]
> 
>   Only added new interfaces, may change VM behavior related to VMware.
> 
> Alexey Makhalov (2):
>    x86/vmware: Introduce VMware hypercall API
>    x86/vmware: Add TDX hypercall support
> 
>   arch/x86/include/asm/vmware.h | 324 ++++++++++++++++++++++++++++++++--
>   arch/x86/kernel/cpu/vmware.c  | 122 ++++++++++++-
>   2 files changed, 424 insertions(+), 22 deletions(-)
> 

Applied to noble:linux/master-next. Thanks.

-Stefan