mbox series

[0/1,aws,v2] net: ena: Fix redundant device NUMA node override

Message ID 20240724122625.376350-1-philip.cox@canonical.com
Headers show
Series net: ena: Fix redundant device NUMA node override | expand

Message

Philip Cox July 24, 2024, 12:26 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2067516



SRU Justification:

[Impact]

We discovered a network packets per second (PPS) performance issue in one of our upcoming EC2 instance platform on Graviton.The issue is addressed by setting a value for the numa_cma parameter. While this parameter is supported in 24.04, the parameter is not available in 22.04 or 20.04 today, which could impact customers running 22.04 or 20.04 on the new EC2 platform.

[Fix]

We are requesting that the following changes be backported to 24.04 to fix a performance issue with NUMA node overrides for AWS EC2 ENA adapaters: https://github.com/torvalds/linux/commit/2dc8b1e7177d4f49f492ce648440caf2de0c366



[Test Plan]
aws tested

[Where problems could occur]
The patch changes how the driver uses shared memory NUMA node id advertised by the underlying device.

If any newly written code assumes the old behaviour, errors could arise. 

[Other info]
sf# 00385923

Comments

Manuel Diewald July 24, 2024, 7:29 p.m. UTC | #1
On Wed, Jul 24, 2024 at 03:26:24PM +0300, Philip Cox wrote:
> 
> BugLink: https://bugs.launchpad.net/bugs/2067516
> 
> 
> 
> SRU Justification:
> 
> [Impact]
> 
> We discovered a network packets per second (PPS) performance issue in one of our upcoming EC2 instance platform on Graviton.The issue is addressed by setting a value for the numa_cma parameter. While this parameter is supported in 24.04, the parameter is not available in 22.04 or 20.04 today, which could impact customers running 22.04 or 20.04 on the new EC2 platform.
> 
> [Fix]
> 
> We are requesting that the following changes be backported to 24.04 to fix a performance issue with NUMA node overrides for AWS EC2 ENA adapaters: https://github.com/torvalds/linux/commit/2dc8b1e7177d4f49f492ce648440caf2de0c366
> 
> 
> 
> [Test Plan]
> aws tested
> 
> [Where problems could occur]
> The patch changes how the driver uses shared memory NUMA node id advertised by the underlying device.
> 
> If any newly written code assumes the old behaviour, errors could arise. 
> 
> [Other info]
> sf# 00385923
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Kevin Becker July 24, 2024, 9:03 p.m. UTC | #2
On Wed, Jul 24, 2024 at 8:28 AM Philip Cox <philip.cox@canonical.com> wrote:
>
>
> BugLink: https://bugs.launchpad.net/bugs/2067516
>
>
>
> SRU Justification:
>
> [Impact]
>
> We discovered a network packets per second (PPS) performance issue in one of our upcoming EC2 instance platform on Graviton.The issue is addressed by setting a value for the numa_cma parameter. While this parameter is supported in 24.04, the parameter is not available in 22.04 or 20.04 today, which could impact customers running 22.04 or 20.04 on the new EC2 platform.
>
> [Fix]
>
> We are requesting that the following changes be backported to 24.04 to fix a performance issue with NUMA node overrides for AWS EC2 ENA adapaters: https://github.com/torvalds/linux/commit/2dc8b1e7177d4f49f492ce648440caf2de0c366
>
>
>
> [Test Plan]
> aws tested
>
> [Where problems could occur]
> The patch changes how the driver uses shared memory NUMA node id advertised by the underlying device.
>
> If any newly written code assumes the old behaviour, errors could arise.
>
> [Other info]
> sf# 00385923
>
>
> --

Acked-by: Kevin Becker <kevin.becker@canonical.com>
Philip Cox July 25, 2024, 6:06 p.m. UTC | #3
On Wed, 2024-07-24 at 15:26 +0300, Philip Cox wrote:
> 
> BugLink: https://bugs.launchpad.net/bugs/2067516
> 
> 
> 
> SRU Justification:
> 
> [Impact]
> 
> We discovered a network packets per second (PPS) performance issue in
> one of our upcoming EC2 instance platform on Graviton.The issue is
> addressed by setting a value for the numa_cma parameter. While this
> parameter is supported in 24.04, the parameter is not available in
> 22.04 or 20.04 today, which could impact customers running 22.04 or
> 20.04 on the new EC2 platform.
> 
> [Fix]
> 
> We are requesting that the following changes be backported to 24.04
> to fix a performance issue with NUMA node overrides for AWS EC2 ENA
> adapaters:
> https://github.com/torvalds/linux/commit/2dc8b1e7177d4f49f492ce648440caf2de0c366
> 
> 
> 
> [Test Plan]
> aws tested
> 
> [Where problems could occur]
> The patch changes how the driver uses shared memory NUMA node id
> advertised by the underlying device.
> 
> If any newly written code assumes the old behaviour, errors could
> arise. 
> 
> [Other info]
> sf# 00385923
>