mbox series

[0/1,n:linux-aws] aws: Backport CMA pool per numa functionality for 22.04 and 20.04

Message ID 20240723100342.54379-1-philip.cox@canonical.com
Headers show
Series aws: Backport CMA pool per numa functionality for 22.04 and 20.04 | expand

Message

Philip Cox July 23, 2024, 10:03 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2069352


SRU Justification:

[Impact]

We discovered a network packets per second (PPS) performance issue in one of our upcoming EC2 instance platform on Graviton.The issue is addressed by setting a value for the numa_cma parameter. While this parameter is supported in 24.04, the parameter is not available in 22.04 or 20.04 today, which could impact customers running 22.04 or 20.04 on the new EC2 platform.

[Fix]

We are requesting that the following changes be backported to 24.04 to fix a performance issue with NUMA node overrides for AWS EC2 ENA adapaters: https://github.com/torvalds/linux/commit/2dc8b1e7177d4f49f492ce648440caf2de0c366



[Test Plan]
aws tested

[Where problems could occur]
The patch changes how the driver uses shared memory NUMA node id advertised by the underlying device.

If any newly written code assumes the old behaviour, errors could arise.

[Other info]
sf# 00385923


--

Shay Agroskin (1):
  net: ena: Fix redundant device NUMA node override

 drivers/net/ethernet/amazon/ena/ena_com.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

Comments

Manuel Diewald July 24, 2024, 9:03 a.m. UTC | #1 
On Tue, Jul 23, 2024 at 01:03:41PM +0300, Philip Cox wrote:
> BugLink: https://bugs.launchpad.net/bugs/2069352
> 

I believe the correct BugLink is: https://bugs.launchpad.net/bugs/2067516

> 
> SRU Justification:
> 
> [Impact]
> 
> We discovered a network packets per second (PPS) performance issue in one of our upcoming EC2 instance platform on Graviton.The issue is addressed by setting a value for the numa_cma parameter. While this parameter is supported in 24.04, the parameter is not available in 22.04 or 20.04 today, which could impact customers running 22.04 or 20.04 on the new EC2 platform.
> 
> [Fix]
> 
> We are requesting that the following changes be backported to 24.04 to fix a performance issue with NUMA node overrides for AWS EC2 ENA adapaters: https://github.com/torvalds/linux/commit/2dc8b1e7177d4f49f492ce648440caf2de0c366

I understand that this addresses the request for fixing NUMA node
overrides in noble. However, the impact is describing changes that need
to be backported to focal and jammy, which this fix doesn't provide. The
launchpad bug also only targets noble, though. This is slightly
confusing, could you clarify this? I assume the bug should also affect
focal + jammy and you will submit the requested backports at a later
point in time?

> 
> 
> 
> [Test Plan]
> aws tested
> 
> [Where problems could occur]
> The patch changes how the driver uses shared memory NUMA node id advertised by the underlying device.
> 
> If any newly written code assumes the old behaviour, errors could arise.
> 
> [Other info]
> sf# 00385923
> 
> 
> --
> 
> Shay Agroskin (1):
>   net: ena: Fix redundant device NUMA node override
> 
>  drivers/net/ethernet/amazon/ena/ena_com.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team