mbox series

[SRU,N,0/2] Fix e1000e hang after suspend

Message ID 20240718085717.1088963-1-aaron.ma@canonical.com
Headers show
Series Fix e1000e hang after suspend | expand

Message

Aaron Ma July 18, 2024, 8:57 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2073358

[Impact]
Intel e1000e driver will be hang after suspend due to:
861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue")

[Fix]
Adjust the smbus logic during suspend to fix the issue.
Upstream fix:
bfd546a552e1 e1000e: move force SMBUS near the end of enable_ulp function
76a0a3f9cc2f e1000e: fix force smbus during suspend flow

[Test]
Bug reporter tested on hardware, e1000e works fine after suspend.

[Where problems could occur]
It may break e1000e driver.

Hui Wang (1):
  e1000e: move force SMBUS near the end of enable_ulp function

Vitaly Lifshits (1):
  e1000e: fix force smbus during suspend flow

 drivers/net/ethernet/intel/e1000e/ich8lan.c | 55 +++++++++++++++++++++
 drivers/net/ethernet/intel/e1000e/netdev.c  | 18 -------
 2 files changed, 55 insertions(+), 18 deletions(-)

Comments

Thibault Ferrante July 18, 2024, 2:32 p.m. UTC | #1 
On 18-07-2024 10:57, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2073358
> 
> [Impact]
> Intel e1000e driver will be hang after suspend due to:
> 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue")
> 
> [Fix]
> Adjust the smbus logic during suspend to fix the issue.
> Upstream fix:
> bfd546a552e1 e1000e: move force SMBUS near the end of enable_ulp function
> 76a0a3f9cc2f e1000e: fix force smbus during suspend flow
> 
> [Test]
> Bug reporter tested on hardware, e1000e works fine after suspend.
> 
> [Where problems could occur]
> It may break e1000e driver.
> 
> Hui Wang (1):
>    e1000e: move force SMBUS near the end of enable_ulp function
> 
> Vitaly Lifshits (1):
>    e1000e: fix force smbus during suspend flow
> 
>   drivers/net/ethernet/intel/e1000e/ich8lan.c | 55 +++++++++++++++++++++
>   drivers/net/ethernet/intel/e1000e/netdev.c  | 18 -------
>   2 files changed, 55 insertions(+), 18 deletions(-)
> 
Acked-by: Thibault Ferrante <thibault.ferrante@canonical.com>

SRU template needs to be copied to the launchpad bug.
--
Thibault
Noah Wager July 19, 2024, 10:04 p.m. UTC | #2 
On Thu, Jul 18, 2024 at 04:57:15PM +0800, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2073358
> 
> [Impact]
> Intel e1000e driver will be hang after suspend due to:
> 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue")
> 
> [Fix]
> Adjust the smbus logic during suspend to fix the issue.
> Upstream fix:
> bfd546a552e1 e1000e: move force SMBUS near the end of enable_ulp function
> 76a0a3f9cc2f e1000e: fix force smbus during suspend flow
> 
> [Test]
> Bug reporter tested on hardware, e1000e works fine after suspend.
> 
> [Where problems could occur]
> It may break e1000e driver.
> 
> Hui Wang (1):
>   e1000e: move force SMBUS near the end of enable_ulp function
> 
> Vitaly Lifshits (1):
>   e1000e: fix force smbus during suspend flow
> 
>  drivers/net/ethernet/intel/e1000e/ich8lan.c | 55 +++++++++++++++++++++
>  drivers/net/ethernet/intel/e1000e/netdev.c  | 18 -------
>  2 files changed, 55 insertions(+), 18 deletions(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Noah Wager <noah.wager@canonical.com>
Andrei Gherzan July 22, 2024, 12:44 p.m. UTC | #3 
On 24/07/18 04:57pm, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2073358
> 
> [Impact]
> Intel e1000e driver will be hang after suspend due to:
> 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue")
> 
> [Fix]
> Adjust the smbus logic during suspend to fix the issue.
> Upstream fix:
> bfd546a552e1 e1000e: move force SMBUS near the end of enable_ulp function
> 76a0a3f9cc2f e1000e: fix force smbus during suspend flow
> 
> [Test]
> Bug reporter tested on hardware, e1000e works fine after suspend.
> 
> [Where problems could occur]
> It may break e1000e driver.
> 
> Hui Wang (1):
>   e1000e: move force SMBUS near the end of enable_ulp function
> 
> Vitaly Lifshits (1):
>   e1000e: fix force smbus during suspend flow
> 
>  drivers/net/ethernet/intel/e1000e/ich8lan.c | 55 +++++++++++++++++++++
>  drivers/net/ethernet/intel/e1000e/netdev.c  | 18 -------
>  2 files changed, 55 insertions(+), 18 deletions(-)

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Roxana Nicolescu July 26, 2024, 9:39 a.m. UTC | #4 
On 18/07/2024 10:57, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2073358
>
> [Impact]
> Intel e1000e driver will be hang after suspend due to:
> 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue")
>
> [Fix]
> Adjust the smbus logic during suspend to fix the issue.
> Upstream fix:
> bfd546a552e1 e1000e: move force SMBUS near the end of enable_ulp function
> 76a0a3f9cc2f e1000e: fix force smbus during suspend flow
>
> [Test]
> Bug reporter tested on hardware, e1000e works fine after suspend.
>
> [Where problems could occur]
> It may break e1000e driver.
>
> Hui Wang (1):
>    e1000e: move force SMBUS near the end of enable_ulp function
>
> Vitaly Lifshits (1):
>    e1000e: fix force smbus during suspend flow
>
>   drivers/net/ethernet/intel/e1000e/ich8lan.c | 55 +++++++++++++++++++++
>   drivers/net/ethernet/intel/e1000e/netdev.c  | 18 -------
>   2 files changed, 55 insertions(+), 18 deletions(-)
>
Applied to noble:linux master-next branch. Thanks!