mbox series

[SRU,N,0/1] Fix no sound on matebook D14 AMD on v6.8

Message ID 20240715125147.978292-1-aaron.ma@canonical.com
Headers show
Series Fix no sound on matebook D14 AMD on v6.8 | expand

Message

Aaron Ma July 15, 2024, 12:51 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2073049

[Impact]
Huawei MateBook D14 AMD got no sound after commit:
4af565de9f8c ("ASoC: amd: acp: fix for acp pdm configuration check")
which is introduced in v6.8.5 stable updates.

[Fix]
Invokes platform specific acp pin configuration check functions.
Upstream fix:
09068d624c490 ("ASoC: amd: acp: fix for acp platform device creation failure")

[Test]
Bug reporter tested on hardware, sound output OK.
Also verified on ThinkPad T14 AMD, sound output OK too.

[Where problems could occur]
It may break sound output of AMD platforms.


Vijendar Mukunda (1):
  ASoC: amd: acp: fix for acp platform device creation failure

 sound/soc/amd/acp/acp-legacy-common.c | 96 ++++++++++++++++++++++-----
 sound/soc/amd/acp/acp-pci.c           |  9 ++-
 sound/soc/amd/acp/amd.h               | 10 ++-
 sound/soc/amd/acp/chip_offset_byte.h  |  1 +
 4 files changed, 95 insertions(+), 21 deletions(-)

Comments

Manuel Diewald July 15, 2024, 1:43 p.m. UTC | #1
On Mon, Jul 15, 2024 at 08:51:46PM +0800, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2073049
> 
> [Impact]
> Huawei MateBook D14 AMD got no sound after commit:
> 4af565de9f8c ("ASoC: amd: acp: fix for acp pdm configuration check")
> which is introduced in v6.8.5 stable updates.
> 
> [Fix]
> Invokes platform specific acp pin configuration check functions.
> Upstream fix:
> 09068d624c490 ("ASoC: amd: acp: fix for acp platform device creation failure")
> 
> [Test]
> Bug reporter tested on hardware, sound output OK.
> Also verified on ThinkPad T14 AMD, sound output OK too.
> 
> [Where problems could occur]
> It may break sound output of AMD platforms.
> 
> 
> Vijendar Mukunda (1):
>   ASoC: amd: acp: fix for acp platform device creation failure
> 
>  sound/soc/amd/acp/acp-legacy-common.c | 96 ++++++++++++++++++++++-----
>  sound/soc/amd/acp/acp-pci.c           |  9 ++-
>  sound/soc/amd/acp/amd.h               | 10 ++-
>  sound/soc/amd/acp/chip_offset_byte.h  |  1 +
>  4 files changed, 95 insertions(+), 21 deletions(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Kevin Becker July 16, 2024, 7:03 p.m. UTC | #2
On Mon, Jul 15, 2024 at 8:52 AM Aaron Ma <aaron.ma@canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2073049
>
> [Impact]
> Huawei MateBook D14 AMD got no sound after commit:
> 4af565de9f8c ("ASoC: amd: acp: fix for acp pdm configuration check")
> which is introduced in v6.8.5 stable updates.
>
> [Fix]
> Invokes platform specific acp pin configuration check functions.
> Upstream fix:
> 09068d624c490 ("ASoC: amd: acp: fix for acp platform device creation failure")
>
> [Test]
> Bug reporter tested on hardware, sound output OK.
> Also verified on ThinkPad T14 AMD, sound output OK too.
>
> [Where problems could occur]
> It may break sound output of AMD platforms.
>
>
> Vijendar Mukunda (1):
>   ASoC: amd: acp: fix for acp platform device creation failure
>
>  sound/soc/amd/acp/acp-legacy-common.c | 96 ++++++++++++++++++++++-----
>  sound/soc/amd/acp/acp-pci.c           |  9 ++-
>  sound/soc/amd/acp/amd.h               | 10 ++-
>  sound/soc/amd/acp/chip_offset_byte.h  |  1 +
>  4 files changed, 95 insertions(+), 21 deletions(-)
>
> --

Acked-by: Kevin Becker <kevin.becker@canonical.com>
Stefan Bader July 19, 2024, 9:34 a.m. UTC | #3
On 15.07.24 14:51, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2073049
> 
> [Impact]
> Huawei MateBook D14 AMD got no sound after commit:
> 4af565de9f8c ("ASoC: amd: acp: fix for acp pdm configuration check")
> which is introduced in v6.8.5 stable updates.
> 
> [Fix]
> Invokes platform specific acp pin configuration check functions.
> Upstream fix:
> 09068d624c490 ("ASoC: amd: acp: fix for acp platform device creation failure")
> 
> [Test]
> Bug reporter tested on hardware, sound output OK.
> Also verified on ThinkPad T14 AMD, sound output OK too.
> 
> [Where problems could occur]
> It may break sound output of AMD platforms.
> 
> 
> Vijendar Mukunda (1):
>    ASoC: amd: acp: fix for acp platform device creation failure
> 
>   sound/soc/amd/acp/acp-legacy-common.c | 96 ++++++++++++++++++++++-----
>   sound/soc/amd/acp/acp-pci.c           |  9 ++-
>   sound/soc/amd/acp/amd.h               | 10 ++-
>   sound/soc/amd/acp/chip_offset_byte.h  |  1 +
>   4 files changed, 95 insertions(+), 21 deletions(-)
> 

Applied to noble:linux/master-next. Thanks.

-Stefan