mbox series

[SRU,J:linux-bluefield,0/1] Fix ct crash

Message ID 20240710130453.3242707-1-danielj@nvidia.com
Headers show
Series Fix ct crash | expand

Message

Daniel Jurgens July 10, 2024, 1:04 p.m. UTC 
From: Daniel Jurgens <danielj@mellanox.com>

BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2071715

SRU Justification:

[Impact]
	- Resolve NULL pointer exception writing CT stats.

[Fix]
	- Set the net field in nf_flow_table

[Test Case]
	- Run CT tests before applying and observe crash.
	- After applying the test passes.

[Regression Potential]
	- No potential, this patch sets a previous NULL field.

Vlad Buslov (1):
  net/sched: act_ct: set 'net' pointer when creating new nf_flow_table

 net/sched/act_ct.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Bartlomiej Zolnierkiewicz July 10, 2024, 3:24 p.m. UTC | #1 
On Wed, Jul 10, 2024 at 3:07 PM Daniel Jurgens <danielj@nvidia.com> wrote:
>
> From: Daniel Jurgens <danielj@mellanox.com>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2071715
>
> SRU Justification:
>
> [Impact]
>         - Resolve NULL pointer exception writing CT stats.
>
> [Fix]
>         - Set the net field in nf_flow_table
>
> [Test Case]
>         - Run CT tests before applying and observe crash.
>         - After applying the test passes.
>
> [Regression Potential]
>         - No potential, this patch sets a previous NULL field.
>
> Vlad Buslov (1):
>   net/sched: act_ct: set 'net' pointer when creating new nf_flow_table
>
>  net/sched/act_ct.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>

There are 2 minor issues with the patch:
- cherry-pick line should be just before your S-o-B line
- shortened version of the bug URL should be used
but both can be fixed while applying the patch.

Thank you for the fix!

--
Best regards,
Bartlomiej
Agathe Porte July 10, 2024, 4:02 p.m. UTC | #2 
2024-07-10 15:07 CEST, Daniel Jurgens:
> From: Daniel Jurgens <danielj@mellanox.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2071715
> 
> SRU Justification:
> 
> [Impact]
> 	- Resolve NULL pointer exception writing CT stats.
> 
> [Fix]
> 	- Set the net field in nf_flow_table
> 
> [Test Case]
> 	- Run CT tests before applying and observe crash.
> 	- After applying the test passes.
> 
> [Regression Potential]
> 	- No potential, this patch sets a previous NULL field.
> 
> Vlad Buslov (1):
>   net/sched: act_ct: set 'net' pointer when creating new nf_flow_table
> 
>  net/sched/act_ct.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Acked-by: Agathe Porte <agathe.porte@canonical.com>
Bartlomiej Zolnierkiewicz July 11, 2024, 7:35 a.m. UTC | #3 
Applied to jammy:linux-bluefield/master-next. Thanks.

[ This was applied on the top of the master-next branch and not before
commit d6226e30830b49e68e2f92f25b33437c2f61388f ("netfilter:
nf_flow_table: count pending offload workqueue tasks") due to the way
in which derivative kernels are maintained and constructed. The
cherry-pick line was moved to the correct place and the BugLink URL
was shortened while applying. ]

--
Best regards,
Bartlomiej

On Wed, Jul 10, 2024 at 3:07 PM Daniel Jurgens <danielj@nvidia.com> wrote:
>
> From: Daniel Jurgens <danielj@mellanox.com>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2071715
>
> SRU Justification:
>
> [Impact]
>         - Resolve NULL pointer exception writing CT stats.
>
> [Fix]
>         - Set the net field in nf_flow_table
>
> [Test Case]
>         - Run CT tests before applying and observe crash.
>         - After applying the test passes.
>
> [Regression Potential]
>         - No potential, this patch sets a previous NULL field.
>
> Vlad Buslov (1):
>   net/sched: act_ct: set 'net' pointer when creating new nf_flow_table
>
>  net/sched/act_ct.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>