From patchwork Thu Jul 4 06:43:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1956633 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WF6Yz25Ttz1xpP for ; Thu, 4 Jul 2024 16:44:06 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1sPGCE-0001OM-1V; Thu, 04 Jul 2024 06:43:58 +0000 Received: from mail-ot1-f41.google.com ([209.85.210.41]) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1sPGCC-0001O5-VZ for kernel-team@lists.ubuntu.com; Thu, 04 Jul 2024 06:43:57 +0000 Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-701f227c256so162092a34.3 for ; Wed, 03 Jul 2024 23:43:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720075435; x=1720680235; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KKREziDXdrIb/r5GoCMNEB6W/Qvrrn5uVgS6bf2ai8E=; b=d6ko+5D7DipwaXqt0qApHSNZc9pV5KTa0obkN/872C49j5E8pqkboJIA5cp5BZD2op ZtJFmsVX/mxTDwsjtYaRn19UynONNlUfNs3i47W9brIkWBA+XTRGYP9bWks7OcbqM+iP DyTYsVFpY68zjyVpEA+jXKBjNF13NOi6pV0Zm/0zzJ36REUzCSCZCnvpwb2EYw9lRWk4 y6CsxhWVJrpvrJpjLjIlhU+A04rTcjQlCsRQ07s989kVkfGaqnq7oLu68rhS9113ZTkr fXk5IV3xcX1jmfApmxJhzj6BVPNhSruPPHpl6TVRaPLLHRNIvPCuDAz0nC43ngG6dxD3 ZIsw== X-Gm-Message-State: AOJu0YzwtrQ7+JObJOk6qnlm8y6Qva9PvxF4TQFvEJnhYhgtvMC3KLfY Sa0IAQZj9g1R5SR5TtLnH/qVc4ZjnC7jN6TU+R1bGMsXXcNP2QVE3nNJ1Q== X-Google-Smtp-Source: AGHT+IHUMpfQgaGTWUfp2/X22nAScx6ji809/1Hvwei2inL3kakDyurjKugQGWlCz1yHpISoz9YwZw== X-Received: by 2002:a9d:4f15:0:b0:700:d37f:3517 with SMTP id 46e09a7af769-7034a73a416mr910197a34.8.1720075435098; Wed, 03 Jul 2024 23:43:55 -0700 (PDT) Received: from localhost (220-135-95-34.hinet-ip.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6d3efeddsm9115842a12.88.2024.07.03.23.43.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 23:43:54 -0700 (PDT) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/1][SRU][N] a critical typo in the code managing the ASPM settings for PCI Express devices Date: Thu, 4 Jul 2024 14:43:51 +0800 Message-ID: <20240704064352.42124-1-acelan.kao@canonical.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.210.41; envelope-from=acelan@gmail.com; helo=mail-ot1-f41.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: "Chia-Lin Kao (AceLan)" BugLink: https://bugs.launchpad.net/bugs/2071889 [Impact] The typo in the original code led to the PCI_EXP_LNKCTL register values being swapped between the parent PCI device and its child device. It may lead to incorrect power state, device malfunction on system resume, or potential data loss or system stability issues. [Fix] Kaiheng submitted a patch to fix the issue and has been included in v6.9 mainline kernel. f3d049b35b01 PCI/ASPM: Restore parent state to parent, child state to child [Test] There is no test cases for the issue now. [Where problems may occur] It fixes the typo and should not introduce any regression. Kai-Heng Feng (1): PCI/ASPM: Restore parent state to parent, child state to child drivers/pci/pcie/aspm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Guoqing Jiang Acked-by: Andrei Gherzan Acked-by: Paolo Pisati