| Message ID | 20240704064352.42124-1-acelan.kao@canonical.com |
|---|---|
| Headers | show |
| Series | a critical typo in the code managing the ASPM settings for PCI Express devices | expand |
On 7/4/24 14:43, AceLan Kao wrote: > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/2071889 > > [Impact] > The typo in the original code led to the PCI_EXP_LNKCTL register values > being swapped between the parent PCI device and its child device. > It may lead to incorrect power state, device malfunction on system > resume, or potential data loss or system stability issues. > > [Fix] > Kaiheng submitted a patch to fix the issue and has been included in v6.9 > mainline kernel. > f3d049b35b01 PCI/ASPM: Restore parent state to parent, child state to child > > [Test] > There is no test cases for the issue now. > > [Where problems may occur] > It fixes the typo and should not introduce any regression. > > Kai-Heng Feng (1): > PCI/ASPM: Restore parent state to parent, child state to child > > drivers/pci/pcie/aspm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Guoqing Jiang <guoqing.jiang@canonical.com>
On 24/07/04 02:43pm, AceLan Kao wrote: > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/2071889 > > [Impact] > The typo in the original code led to the PCI_EXP_LNKCTL register values > being swapped between the parent PCI device and its child device. > It may lead to incorrect power state, device malfunction on system > resume, or potential data loss or system stability issues. > > [Fix] > Kaiheng submitted a patch to fix the issue and has been included in v6.9 > mainline kernel. > f3d049b35b01 PCI/ASPM: Restore parent state to parent, child state to child > > [Test] > There is no test cases for the issue now. > > [Where problems may occur] > It fixes the typo and should not introduce any regression. > > Kai-Heng Feng (1): > PCI/ASPM: Restore parent state to parent, child state to child > > drivers/pci/pcie/aspm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
On Thu, Jul 04, 2024 at 02:43:51PM +0800, AceLan Kao wrote: > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/2071889 Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
On 04.07.24 08:43, AceLan Kao wrote: > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/2071889 > > [Impact] > The typo in the original code led to the PCI_EXP_LNKCTL register values > being swapped between the parent PCI device and its child device. > It may lead to incorrect power state, device malfunction on system > resume, or potential data loss or system stability issues. > > [Fix] > Kaiheng submitted a patch to fix the issue and has been included in v6.9 > mainline kernel. > f3d049b35b01 PCI/ASPM: Restore parent state to parent, child state to child > > [Test] > There is no test cases for the issue now. > > [Where problems may occur] > It fixes the typo and should not introduce any regression. > > Kai-Heng Feng (1): > PCI/ASPM: Restore parent state to parent, child state to child > > drivers/pci/pcie/aspm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied to noble:linux/master-next. Thanks. -Stefan
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> BugLink: https://bugs.launchpad.net/bugs/2071889 [Impact] The typo in the original code led to the PCI_EXP_LNKCTL register values being swapped between the parent PCI device and its child device. It may lead to incorrect power state, device malfunction on system resume, or potential data loss or system stability issues. [Fix] Kaiheng submitted a patch to fix the issue and has been included in v6.9 mainline kernel. f3d049b35b01 PCI/ASPM: Restore parent state to parent, child state to child [Test] There is no test cases for the issue now. [Where problems may occur] It fixes the typo and should not introduce any regression. Kai-Heng Feng (1): PCI/ASPM: Restore parent state to parent, child state to child drivers/pci/pcie/aspm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)