mbox series

[0/1,SRU,Noble] ALSA: hda/realtek: fix mute/micmute LEDs don't work on EliteBook 645/665 G11

Message ID 20240701085426.346643-1-dirk.su@canonical.com
Headers show
Series ALSA: hda/realtek: fix mute/micmute LEDs don't work on EliteBook 645/665 G11 | expand

Message

Dirk Su July 1, 2024, 8:54 a.m. UTC
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2071296

[Impact]
The mic mute/audio mute LEDS are not work on EliteBook 645/665 G11

[Fix]
It needs the specific quirk for the hardware layout.
Thus, add the quirks to make it works.

[Test]
After applying the quirk, the audio/mic mute LEDs are working good.

[Where problems could occur]
If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).

Dirk Su (1):
  ALSA: hda/realtek: fix mute/micmute LEDs don't work for EliteBook
    645/665 G11.

 sound/pci/hda/patch_realtek.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Paolo Pisati July 1, 2024, 9:38 a.m. UTC | #1
On Mon, Jul 01, 2024 at 04:54:25PM +0800, Dirk Su wrote:
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2071296

Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
Chris Chiu July 1, 2024, 12:26 p.m. UTC | #2
On Mon, Jul 1, 2024 at 4:55 PM Dirk Su <dirk.su@canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2071296
>
> [Impact]
> The mic mute/audio mute LEDS are not work on EliteBook 645/665 G11
>
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
>
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
>
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
>
> Dirk Su (1):
>   ALSA: hda/realtek: fix mute/micmute LEDs don't work for EliteBook
>     645/665 G11.
>
>  sound/pci/hda/patch_realtek.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> --
> 2.34.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Chris Chiu <chris.chiu@canonical.com>
Stefan Bader July 4, 2024, 6:21 p.m. UTC | #3
On 01.07.24 10:54, Dirk Su wrote:
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2071296
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on EliteBook 645/665 G11
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Dirk Su (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs don't work for EliteBook
>      645/665 G11.
> 
>   sound/pci/hda/patch_realtek.c | 3 +++
>   1 file changed, 3 insertions(+)
> 

The submitted patch is not from upstream, despite what its markup 
claims. This will be immediately rejected in future submissions! For 
this time I replaced the submission with

commit 3cd59d8ef8df7d7a079f54d56502dae8f716b39b linux-next

Applied to noble:linux/master-next. Thanks.

-Stefan