mbox series

[SRU,J,0/1] CVE-2024-26952

Message ID 20240626211427.21379-1-bethany.jamison@canonical.com
Headers show
Series CVE-2024-26952 | expand

Message

Bethany Jamison June 26, 2024, 9:14 p.m. UTC
[Impact]

ksmbd: fix potencial out-of-bounds when buffer offset is invalid

I found potencial out-of-bounds when buffer offset fields of a few requests
is invalid. This patch set the minimum value of buffer offset field to
->Buffer offset to validate buffer length.

[Fix]

Noble:	released
Jammy:	Backport - context conflicts from neighboring lines, shouldn't
	affect the fix so I applied the fix changes as given
Focal:	not affected
Bionic:	not affected
Xenial:	not affected
Trusty: not affected

[Test Case]

Compile and boot tested

[Where problems could occur]

This fix affects those who use the KSMBD server, an issue with this fix
would be visible to the user via unexpected system behavior or a system
crash.

Namjae Jeon (1):
  ksmbd: fix potencial out-of-bounds when buffer offset is invalid

 fs/ksmbd/smb2misc.c | 22 +++++++++++++++------
 fs/ksmbd/smb2pdu.c  | 48 ++++++++++++++++++++++++---------------------
 2 files changed, 42 insertions(+), 28 deletions(-)

Comments

Manuel Diewald June 28, 2024, 3:01 p.m. UTC | #1
On Wed, Jun 26, 2024 at 04:14:26PM -0500, Bethany Jamison wrote:
> [Impact]
> 
> ksmbd: fix potencial out-of-bounds when buffer offset is invalid
> 
> I found potencial out-of-bounds when buffer offset fields of a few requests
> is invalid. This patch set the minimum value of buffer offset field to
> ->Buffer offset to validate buffer length.
> 
> [Fix]
> 
> Noble:	released
> Jammy:	Backport - context conflicts from neighboring lines, shouldn't
> 	affect the fix so I applied the fix changes as given
> Focal:	not affected
> Bionic:	not affected
> Xenial:	not affected
> Trusty: not affected
> 
> [Test Case]
> 
> Compile and boot tested
> 
> [Where problems could occur]
> 
> This fix affects those who use the KSMBD server, an issue with this fix
> would be visible to the user via unexpected system behavior or a system
> crash.
> 
> Namjae Jeon (1):
>   ksmbd: fix potencial out-of-bounds when buffer offset is invalid
> 
>  fs/ksmbd/smb2misc.c | 22 +++++++++++++++------
>  fs/ksmbd/smb2pdu.c  | 48 ++++++++++++++++++++++++---------------------
>  2 files changed, 42 insertions(+), 28 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Stefan Bader July 4, 2024, 4:40 p.m. UTC | #2
On 26.06.24 23:14, Bethany Jamison wrote:
> [Impact]
> 
> ksmbd: fix potencial out-of-bounds when buffer offset is invalid
> 
> I found potencial out-of-bounds when buffer offset fields of a few requests
> is invalid. This patch set the minimum value of buffer offset field to
> ->Buffer offset to validate buffer length.
> 
> [Fix]
> 
> Noble:	released
> Jammy:	Backport - context conflicts from neighboring lines, shouldn't
> 	affect the fix so I applied the fix changes as given
> Focal:	not affected
> Bionic:	not affected
> Xenial:	not affected
> Trusty: not affected
> 
> [Test Case]
> 
> Compile and boot tested
> 
> [Where problems could occur]
> 
> This fix affects those who use the KSMBD server, an issue with this fix
> would be visible to the user via unexpected system behavior or a system
> crash.
> 
> Namjae Jeon (1):
>    ksmbd: fix potencial out-of-bounds when buffer offset is invalid
> 
>   fs/ksmbd/smb2misc.c | 22 +++++++++++++++------
>   fs/ksmbd/smb2pdu.c  | 48 ++++++++++++++++++++++++---------------------
>   2 files changed, 42 insertions(+), 28 deletions(-)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader July 4, 2024, 5:18 p.m. UTC | #3
On 26.06.24 23:14, Bethany Jamison wrote:
> [Impact]
> 
> ksmbd: fix potencial out-of-bounds when buffer offset is invalid
> 
> I found potencial out-of-bounds when buffer offset fields of a few requests
> is invalid. This patch set the minimum value of buffer offset field to
> ->Buffer offset to validate buffer length.
> 
> [Fix]
> 
> Noble:	released
> Jammy:	Backport - context conflicts from neighboring lines, shouldn't
> 	affect the fix so I applied the fix changes as given
> Focal:	not affected
> Bionic:	not affected
> Xenial:	not affected
> Trusty: not affected
> 
> [Test Case]
> 
> Compile and boot tested
> 
> [Where problems could occur]
> 
> This fix affects those who use the KSMBD server, an issue with this fix
> would be visible to the user via unexpected system behavior or a system
> crash.
> 
> Namjae Jeon (1):
>    ksmbd: fix potencial out-of-bounds when buffer offset is invalid
> 
>   fs/ksmbd/smb2misc.c | 22 +++++++++++++++------
>   fs/ksmbd/smb2pdu.c  | 48 ++++++++++++++++++++++++---------------------
>   2 files changed, 42 insertions(+), 28 deletions(-)
> 

Applied to jammy:linux/master-next. Thanks.

-Stefan