mbox series

[0/4,SRU,Noble] handle broken ACPI MIPI DisCo data

Message ID 20240625072033.3410543-1-vicamo.yang@canonical.com
Headers show
Series handle broken ACPI MIPI DisCo data | expand

Message

You-Sheng Yang June 25, 2024, 7:20 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2070251

[Impact]

Multiple early IPU6 platforms may not have formal MIPI DisCo data
embedded in ACPI, and they may confuse latter driver and fail device
probing:

  ov01a10 i2c-OVTI01A0:00: can't get clock frequency
  ov01a10 i2c-OVTI01A0:00: failed to check hwcfg: -22
  ov01a10: probe of i2c-OVTI01A0:00 failed with error -22

[Fix]

A few commits from mainline kernel up to v6.10-rc5.

[Test Case]

Camera sensor device should then be probed correctly.

[Where problems could occur]

These fixes are based on MIPI DisCo support that is only available since
v6.8. For older kernels, the ipu6-drivers either has no hwcfg checking
implemented, or patched with DMI info to skip it.

[Other Info]

While the patches are from v6.10-rc5, only Noble and OEM-6.8 will be
nominated for fixing.

Hans de Goede (1):
  ACPI: scan: Ignore camera graph port nodes on all Dell Tiger, Alder
    and Raptor Lake models

Sakari Ailus (3):
  ACPI: utils: Make acpi_handle_path() not static
  ACPI: property: Ignore bad graph port nodes on Dell XPS 9315
  ACPI: property: Polish ignoring bad data nodes

 drivers/acpi/internal.h       |  5 +++
 drivers/acpi/mipi-disco-img.c | 81 +++++++++++++++++++++++++++++++++++
 drivers/acpi/property.c       |  3 ++
 drivers/acpi/utils.c          |  2 +-
 include/linux/acpi.h          |  1 +
 5 files changed, 91 insertions(+), 1 deletion(-)

Comments

Timo Aaltonen June 27, 2024, 3:05 p.m. UTC | #1
You-Sheng Yang kirjoitti 25.6.2024 klo 10.20:
> BugLink: https://bugs.launchpad.net/bugs/2070251
> 
> [Impact]
> 
> Multiple early IPU6 platforms may not have formal MIPI DisCo data
> embedded in ACPI, and they may confuse latter driver and fail device
> probing:
> 
>    ov01a10 i2c-OVTI01A0:00: can't get clock frequency
>    ov01a10 i2c-OVTI01A0:00: failed to check hwcfg: -22
>    ov01a10: probe of i2c-OVTI01A0:00 failed with error -22
> 
> [Fix]
> 
> A few commits from mainline kernel up to v6.10-rc5.
> 
> [Test Case]
> 
> Camera sensor device should then be probed correctly.
> 
> [Where problems could occur]
> 
> These fixes are based on MIPI DisCo support that is only available since
> v6.8. For older kernels, the ipu6-drivers either has no hwcfg checking
> implemented, or patched with DMI info to skip it.
> 
> [Other Info]
> 
> While the patches are from v6.10-rc5, only Noble and OEM-6.8 will be
> nominated for fixing.
> 
> Hans de Goede (1):
>    ACPI: scan: Ignore camera graph port nodes on all Dell Tiger, Alder
>      and Raptor Lake models
> 
> Sakari Ailus (3):
>    ACPI: utils: Make acpi_handle_path() not static
>    ACPI: property: Ignore bad graph port nodes on Dell XPS 9315
>    ACPI: property: Polish ignoring bad data nodes
> 
>   drivers/acpi/internal.h       |  5 +++
>   drivers/acpi/mipi-disco-img.c | 81 +++++++++++++++++++++++++++++++++++
>   drivers/acpi/property.c       |  3 ++
>   drivers/acpi/utils.c          |  2 +-
>   include/linux/acpi.h          |  1 +
>   5 files changed, 91 insertions(+), 1 deletion(-)
> 

part of the mipi/ipu6 maze, and required for oem-6.5->hwe-6.8 transition, so

Acked-by: Timo Aaltonen <timo.aaltonen@canonical.com>

--
t
Manuel Diewald June 28, 2024, 3:36 p.m. UTC | #2
On Tue, Jun 25, 2024 at 03:20:29PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2070251
> 
> [Impact]
> 
> Multiple early IPU6 platforms may not have formal MIPI DisCo data
> embedded in ACPI, and they may confuse latter driver and fail device
> probing:
> 
>   ov01a10 i2c-OVTI01A0:00: can't get clock frequency
>   ov01a10 i2c-OVTI01A0:00: failed to check hwcfg: -22
>   ov01a10: probe of i2c-OVTI01A0:00 failed with error -22
> 
> [Fix]
> 
> A few commits from mainline kernel up to v6.10-rc5.
> 
> [Test Case]
> 
> Camera sensor device should then be probed correctly.
> 
> [Where problems could occur]
> 
> These fixes are based on MIPI DisCo support that is only available since
> v6.8. For older kernels, the ipu6-drivers either has no hwcfg checking
> implemented, or patched with DMI info to skip it.
> 
> [Other Info]
> 
> While the patches are from v6.10-rc5, only Noble and OEM-6.8 will be
> nominated for fixing.
> 
> Hans de Goede (1):
>   ACPI: scan: Ignore camera graph port nodes on all Dell Tiger, Alder
>     and Raptor Lake models
> 
> Sakari Ailus (3):
>   ACPI: utils: Make acpi_handle_path() not static
>   ACPI: property: Ignore bad graph port nodes on Dell XPS 9315
>   ACPI: property: Polish ignoring bad data nodes
> 
>  drivers/acpi/internal.h       |  5 +++
>  drivers/acpi/mipi-disco-img.c | 81 +++++++++++++++++++++++++++++++++++
>  drivers/acpi/property.c       |  3 ++
>  drivers/acpi/utils.c          |  2 +-
>  include/linux/acpi.h          |  1 +
>  5 files changed, 91 insertions(+), 1 deletion(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Chris Chiu July 4, 2024, 4:04 a.m. UTC | #3
On Tue, Jun 25, 2024 at 3:21 PM You-Sheng Yang
<vicamo.yang@canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2070251
>
> [Impact]
>
> Multiple early IPU6 platforms may not have formal MIPI DisCo data
> embedded in ACPI, and they may confuse latter driver and fail device
> probing:
>
>   ov01a10 i2c-OVTI01A0:00: can't get clock frequency
>   ov01a10 i2c-OVTI01A0:00: failed to check hwcfg: -22
>   ov01a10: probe of i2c-OVTI01A0:00 failed with error -22
>
> [Fix]
>
> A few commits from mainline kernel up to v6.10-rc5.
>
> [Test Case]
>
> Camera sensor device should then be probed correctly.
>
> [Where problems could occur]
>
> These fixes are based on MIPI DisCo support that is only available since
> v6.8. For older kernels, the ipu6-drivers either has no hwcfg checking
> implemented, or patched with DMI info to skip it.
>
> [Other Info]
>
> While the patches are from v6.10-rc5, only Noble and OEM-6.8 will be
> nominated for fixing.
>
> Hans de Goede (1):
>   ACPI: scan: Ignore camera graph port nodes on all Dell Tiger, Alder
>     and Raptor Lake models
>
> Sakari Ailus (3):
>   ACPI: utils: Make acpi_handle_path() not static
>   ACPI: property: Ignore bad graph port nodes on Dell XPS 9315
>   ACPI: property: Polish ignoring bad data nodes
>
>  drivers/acpi/internal.h       |  5 +++
>  drivers/acpi/mipi-disco-img.c | 81 +++++++++++++++++++++++++++++++++++
>  drivers/acpi/property.c       |  3 ++
>  drivers/acpi/utils.c          |  2 +-
>  include/linux/acpi.h          |  1 +
>  5 files changed, 91 insertions(+), 1 deletion(-)
>
> --
> 2.43.0
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Chris Chiu <chris.chiu@canonical.com>
Andrei Gherzan July 4, 2024, 9:01 a.m. UTC | #4
On 24/06/25 03:20pm, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2070251
> 
> [Impact]
> 
> Multiple early IPU6 platforms may not have formal MIPI DisCo data
> embedded in ACPI, and they may confuse latter driver and fail device
> probing:
> 
>   ov01a10 i2c-OVTI01A0:00: can't get clock frequency
>   ov01a10 i2c-OVTI01A0:00: failed to check hwcfg: -22
>   ov01a10: probe of i2c-OVTI01A0:00 failed with error -22
> 
> [Fix]
> 
> A few commits from mainline kernel up to v6.10-rc5.
> 
> [Test Case]
> 
> Camera sensor device should then be probed correctly.
> 
> [Where problems could occur]
> 
> These fixes are based on MIPI DisCo support that is only available since
> v6.8. For older kernels, the ipu6-drivers either has no hwcfg checking
> implemented, or patched with DMI info to skip it.
> 
> [Other Info]
> 
> While the patches are from v6.10-rc5, only Noble and OEM-6.8 will be
> nominated for fixing.
> 
> Hans de Goede (1):
>   ACPI: scan: Ignore camera graph port nodes on all Dell Tiger, Alder
>     and Raptor Lake models
> 
> Sakari Ailus (3):
>   ACPI: utils: Make acpi_handle_path() not static
>   ACPI: property: Ignore bad graph port nodes on Dell XPS 9315
>   ACPI: property: Polish ignoring bad data nodes
> 
>  drivers/acpi/internal.h       |  5 +++
>  drivers/acpi/mipi-disco-img.c | 81 +++++++++++++++++++++++++++++++++++
>  drivers/acpi/property.c       |  3 ++
>  drivers/acpi/utils.c          |  2 +-
>  include/linux/acpi.h          |  1 +
>  5 files changed, 91 insertions(+), 1 deletion(-)

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Stefan Bader July 4, 2024, 5:56 p.m. UTC | #5
On 25.06.24 09:20, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2070251
> 
> [Impact]
> 
> Multiple early IPU6 platforms may not have formal MIPI DisCo data
> embedded in ACPI, and they may confuse latter driver and fail device
> probing:
> 
>    ov01a10 i2c-OVTI01A0:00: can't get clock frequency
>    ov01a10 i2c-OVTI01A0:00: failed to check hwcfg: -22
>    ov01a10: probe of i2c-OVTI01A0:00 failed with error -22
> 
> [Fix]
> 
> A few commits from mainline kernel up to v6.10-rc5.
> 
> [Test Case]
> 
> Camera sensor device should then be probed correctly.
> 
> [Where problems could occur]
> 
> These fixes are based on MIPI DisCo support that is only available since
> v6.8. For older kernels, the ipu6-drivers either has no hwcfg checking
> implemented, or patched with DMI info to skip it.
> 
> [Other Info]
> 
> While the patches are from v6.10-rc5, only Noble and OEM-6.8 will be
> nominated for fixing.
> 
> Hans de Goede (1):
>    ACPI: scan: Ignore camera graph port nodes on all Dell Tiger, Alder
>      and Raptor Lake models
> 
> Sakari Ailus (3):
>    ACPI: utils: Make acpi_handle_path() not static
>    ACPI: property: Ignore bad graph port nodes on Dell XPS 9315
>    ACPI: property: Polish ignoring bad data nodes
> 
>   drivers/acpi/internal.h       |  5 +++
>   drivers/acpi/mipi-disco-img.c | 81 +++++++++++++++++++++++++++++++++++
>   drivers/acpi/property.c       |  3 ++
>   drivers/acpi/utils.c          |  2 +-
>   include/linux/acpi.h          |  1 +
>   5 files changed, 91 insertions(+), 1 deletion(-)
> 

Applied to noble:linux/master-next. Thanks.

-Stefan