| Message ID | 20240625065307.11681-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | RFIM and SAGV Linux Support for G10 models | expand |
On Tue, Jun 25, 2024 at 2:53 PM Hui Wang <hui.wang@canonical.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/2070158 > > [Impact] > This is a feature request from HP, RFIM is for frequency, SAGV is for voltage. > They are used as dynamic switching to reduce RF noise. RFIM is already > supported in the kernel, this patchset adds the SAGV feature. > > [Fix] > Cherry-pick 6 commits from mainline kernel > > [Test] > Enable the SAGV from the BIOS, booting with the patched kernel, after booting > up, run 'systemctl status dtt.service', we will get: service is enabled and > service is running > run 'cat /sys/kernel/debug/dri/0000:00:02.0/i915_sagv_status', we will get: > SAGV available: Yes > SAGV status: enabled > > [Where problems could occur] > Because the fix is for i915, it is likely introduce regression on graphic, > but this possibility is very low. These 6 commits are merged to > mainline kernel from v6.10-rc1, so far there is no regression reported > on them. And we tested the patched kernel on different Intel machines, all > worked well. > > Stanislav Lisovskiy (4): > drm/i915/display: Add meaningful traces for QGV point info error > handling > drm/i915/display: Extract code required to calculate max qgv/psf gv > point > drm/i915/display: Disable SAGV on bw init, to force QGV point > recalculation > drm/i915/display: handle systems with duplicate psf gv points > > Vinod Govindapillai (2): > drm/i915/display: extract code to prepare qgv points mask > drm/i915/display: force qgv check after the hw state readout > > drivers/gpu/drm/i915/display/intel_bw.c | 160 ++++++++++++++----- > drivers/gpu/drm/i915/display/intel_bw.h | 6 + > drivers/gpu/drm/i915/display/skl_watermark.c | 2 +- > drivers/gpu/drm/i915/display/skl_watermark.h | 1 + > drivers/gpu/drm/i915/soc/intel_dram.c | 2 + > 5 files changed, 129 insertions(+), 42 deletions(-) > > -- > 2.34.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team Acked-by: Chris Chiu <chris.chiu@canonical.com>
Hui Wang kirjoitti 25.6.2024 klo 9.53: > BugLink: https://bugs.launchpad.net/bugs/2070158 > > [Impact] > This is a feature request from HP, RFIM is for frequency, SAGV is for voltage. > They are used as dynamic switching to reduce RF noise. RFIM is already > supported in the kernel, this patchset adds the SAGV feature. > > [Fix] > Cherry-pick 6 commits from mainline kernel > > [Test] > Enable the SAGV from the BIOS, booting with the patched kernel, after booting > up, run 'systemctl status dtt.service', we will get: service is enabled and > service is running > run 'cat /sys/kernel/debug/dri/0000:00:02.0/i915_sagv_status', we will get: > SAGV available: Yes > SAGV status: enabled > > [Where problems could occur] > Because the fix is for i915, it is likely introduce regression on graphic, > but this possibility is very low. These 6 commits are merged to > mainline kernel from v6.10-rc1, so far there is no regression reported > on them. And we tested the patched kernel on different Intel machines, all > worked well. > > Stanislav Lisovskiy (4): > drm/i915/display: Add meaningful traces for QGV point info error > handling > drm/i915/display: Extract code required to calculate max qgv/psf gv > point > drm/i915/display: Disable SAGV on bw init, to force QGV point > recalculation > drm/i915/display: handle systems with duplicate psf gv points > > Vinod Govindapillai (2): > drm/i915/display: extract code to prepare qgv points mask > drm/i915/display: force qgv check after the hw state readout > > drivers/gpu/drm/i915/display/intel_bw.c | 160 ++++++++++++++----- > drivers/gpu/drm/i915/display/intel_bw.h | 6 + > drivers/gpu/drm/i915/display/skl_watermark.c | 2 +- > drivers/gpu/drm/i915/display/skl_watermark.h | 1 + > drivers/gpu/drm/i915/soc/intel_dram.c | 2 + > 5 files changed, 129 insertions(+), 42 deletions(-) > Acked-by: Timo Aaltonen <timo.aaltonen@canonical.com> the part of "where problems could occur" says "it's likely to break" and "possibility is low".. please decide :)
On 25.06.24 08:53, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/2070158 > > [Impact] > This is a feature request from HP, RFIM is for frequency, SAGV is for voltage. > They are used as dynamic switching to reduce RF noise. RFIM is already > supported in the kernel, this patchset adds the SAGV feature. > > [Fix] > Cherry-pick 6 commits from mainline kernel > > [Test] > Enable the SAGV from the BIOS, booting with the patched kernel, after booting > up, run 'systemctl status dtt.service', we will get: service is enabled and > service is running > run 'cat /sys/kernel/debug/dri/0000:00:02.0/i915_sagv_status', we will get: > SAGV available: Yes > SAGV status: enabled > > [Where problems could occur] > Because the fix is for i915, it is likely introduce regression on graphic, > but this possibility is very low. These 6 commits are merged to > mainline kernel from v6.10-rc1, so far there is no regression reported > on them. And we tested the patched kernel on different Intel machines, all > worked well. > > Stanislav Lisovskiy (4): > drm/i915/display: Add meaningful traces for QGV point info error > handling > drm/i915/display: Extract code required to calculate max qgv/psf gv > point > drm/i915/display: Disable SAGV on bw init, to force QGV point > recalculation > drm/i915/display: handle systems with duplicate psf gv points > > Vinod Govindapillai (2): > drm/i915/display: extract code to prepare qgv points mask > drm/i915/display: force qgv check after the hw state readout > > drivers/gpu/drm/i915/display/intel_bw.c | 160 ++++++++++++++----- > drivers/gpu/drm/i915/display/intel_bw.h | 6 + > drivers/gpu/drm/i915/display/skl_watermark.c | 2 +- > drivers/gpu/drm/i915/display/skl_watermark.h | 1 + > drivers/gpu/drm/i915/soc/intel_dram.c | 2 + > 5 files changed, 129 insertions(+), 42 deletions(-) > Applied to noble:linux/master-next. Thanks. -Stefan
BugLink: https://bugs.launchpad.net/bugs/2070158 [Impact] This is a feature request from HP, RFIM is for frequency, SAGV is for voltage. They are used as dynamic switching to reduce RF noise. RFIM is already supported in the kernel, this patchset adds the SAGV feature. [Fix] Cherry-pick 6 commits from mainline kernel [Test] Enable the SAGV from the BIOS, booting with the patched kernel, after booting up, run 'systemctl status dtt.service', we will get: service is enabled and service is running run 'cat /sys/kernel/debug/dri/0000:00:02.0/i915_sagv_status', we will get: SAGV available: Yes SAGV status: enabled [Where problems could occur] Because the fix is for i915, it is likely introduce regression on graphic, but this possibility is very low. These 6 commits are merged to mainline kernel from v6.10-rc1, so far there is no regression reported on them. And we tested the patched kernel on different Intel machines, all worked well. Stanislav Lisovskiy (4): drm/i915/display: Add meaningful traces for QGV point info error handling drm/i915/display: Extract code required to calculate max qgv/psf gv point drm/i915/display: Disable SAGV on bw init, to force QGV point recalculation drm/i915/display: handle systems with duplicate psf gv points Vinod Govindapillai (2): drm/i915/display: extract code to prepare qgv points mask drm/i915/display: force qgv check after the hw state readout drivers/gpu/drm/i915/display/intel_bw.c | 160 ++++++++++++++----- drivers/gpu/drm/i915/display/intel_bw.h | 6 + drivers/gpu/drm/i915/display/skl_watermark.c | 2 +- drivers/gpu/drm/i915/display/skl_watermark.h | 1 + drivers/gpu/drm/i915/soc/intel_dram.c | 2 + 5 files changed, 129 insertions(+), 42 deletions(-)