From patchwork Wed Jun 12 01:33:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1946598 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VzSkB2Qkyz20Pb for ; Wed, 12 Jun 2024 11:33:53 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1sHCrq-0000ZY-Hm; Wed, 12 Jun 2024 01:33:38 +0000 Received: from mail-pl1-f174.google.com ([209.85.214.174]) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1sHCrp-0000ZQ-IT for kernel-team@lists.ubuntu.com; Wed, 12 Jun 2024 01:33:37 +0000 Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f6b0a40721so45667115ad.2 for ; Tue, 11 Jun 2024 18:33:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718156015; x=1718760815; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YGo+mGILuDMsw1Cro6XQNvH+vb+T3X6ULC7iCNeq0YI=; b=rP4AUnBuZMNmbHSm340ZT/yrrRFy77bZ+EZvhN9jFxxps2jypn5uTyyQ8v4sZqiMrT JXQmepTEx7TeoI/tqTA0pTTvNcYCbJRW1c7c3rVSgjtzcSnkrXWCYdN6RdQSxLIITki5 bY+aRc/zu2DzCAQXFMFKw60ks7RU8ckvGwiQYAbmWGHW2OuAFtm/j/y+ZahCoyr+yRd+ Pxd7xS2ItMmjwQjVrz+urB8sEO0UZZtEVQpiIH+0q4YtTx4c0J26kf7ij7hb5SzCXWXG w43jI43cvUk4zkZhGvuxTBVJIUjpSezD4AzEqu7XOrG4uuHQ7Gvh5A5G81HZtPUaRhb/ ZdSw== X-Gm-Message-State: AOJu0YyPYg48pasfW+NJxDPcnNJlTWPMwn1NtL3VnpXDkF6OcAD3uRkD bA/2LnKJMr98eqo8sFpHcS/ISnEaaydLMHAP47Rv3iXvhPYwKfl4uozqMg== X-Google-Smtp-Source: AGHT+IHrafieh1jIAF+X2xDcnJUdSz1Z5Oxt0SUgnsd6WcuiL5//P7cKNy4yoFo4i7qp1iWop4Annw== X-Received: by 2002:a17:902:eccc:b0:1f8:3c9e:3b92 with SMTP id d9443c01a7336-1f83c9e3cf9mr3385985ad.23.1718156015139; Tue, 11 Jun 2024 18:33:35 -0700 (PDT) Received: from localhost (220-135-95-34.hinet-ip.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f7064c0fd2sm56329735ad.38.2024.06.11.18.33.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 18:33:34 -0700 (PDT) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/2][SRU][N] rtw89_8852ce - Lost WIFI connection after suspend Date: Wed, 12 Jun 2024 09:33:31 +0800 Message-Id: <20240612013333.1608029-1-acelan.kao@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.214.174; envelope-from=acelan@gmail.com; helo=mail-pl1-f174.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: "Chia-Lin Kao (AceLan)" BugLink: https://bugs.launchpad.net/bugs/2065128 [Impact] Lost WIFI connection after suspend. While this happen, the WIFI module couldn't detect any AP, re-enable module and reboot OS without any help. There only way to get it back is cold boot. [Fix] Realtek provides a fix which has been included in rtw maintainer's tree https://lore.kernel.org/linux-wireless/20240426061200.44262-1-pkshih@realtek.com/T/#mbfcb37c2fdc85ba280743f2b07fbf1fa8719eb79 The commits has been included in v6.10-rc1 4e5957101d42 wifi: rtw89: 8852c: refine power sequence to imporve power consumption 535c045da60f wifi: rtw89: reset AFEDIG register in power off sequence [Test case] 1. Boot into OS 2. open terminal to keep checking dmesg or check the wifi connection from GUI 3. suspend/resume multiple times 4. check the wifi connection [Where problems could occur] What the 2 commits should be safe and won't introduce any regression. 1. Reset AFEDIG register before BB reset in power off sequence 2. Adjust power and clock parameters Chia-Yuan Li (1): wifi: rtw89: 8852c: refine power sequence to imporve power consumption Chin-Yen Lee (1): wifi: rtw89: reset AFEDIG register in power off sequence drivers/net/wireless/realtek/rtw89/rtw8851b.c | 1 + drivers/net/wireless/realtek/rtw89/rtw8852b.c | 2 ++ drivers/net/wireless/realtek/rtw89/rtw8852c.c | 12 ++++++++++-- 3 files changed, 13 insertions(+), 2 deletions(-) Acked-by: Chris Chiu Acked-by: Timo Aaltonen Acked-by: Paolo Pisati