mbox series

[0/2,SRU,N] rtw89_8852ce - Lost WIFI connection after suspend

Message ID 20240612013333.1608029-1-acelan.kao@canonical.com
Headers show
Series rtw89_8852ce - Lost WIFI connection after suspend | expand

Message

AceLan Kao June 12, 2024, 1:33 a.m. UTC
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/2065128

[Impact]
Lost WIFI connection after suspend.
While this happen, the WIFI module couldn't detect any AP, re-enable module and reboot OS without any help.
There only way to get it back is cold boot.

[Fix]
Realtek provides a fix which has been included in rtw maintainer's tree
https://lore.kernel.org/linux-wireless/20240426061200.44262-1-pkshih@realtek.com/T/#mbfcb37c2fdc85ba280743f2b07fbf1fa8719eb79

The commits has been included in v6.10-rc1
4e5957101d42 wifi: rtw89: 8852c: refine power sequence to imporve power consumption
535c045da60f wifi: rtw89: reset AFEDIG register in power off sequence

[Test case]
1. Boot into OS
2. open terminal to keep checking dmesg or check the wifi connection from GUI
3. suspend/resume multiple times
4. check the wifi connection

[Where problems could occur]
What the 2 commits should be safe and won't introduce any regression.
1. Reset AFEDIG register before BB reset in power off sequence
2. Adjust power and clock parameters

Chia-Yuan Li (1):
  wifi: rtw89: 8852c: refine power sequence to imporve power consumption

Chin-Yen Lee (1):
  wifi: rtw89: reset AFEDIG register in power off sequence

 drivers/net/wireless/realtek/rtw89/rtw8851b.c |  1 +
 drivers/net/wireless/realtek/rtw89/rtw8852b.c |  2 ++
 drivers/net/wireless/realtek/rtw89/rtw8852c.c | 12 ++++++++++--
 3 files changed, 13 insertions(+), 2 deletions(-)

Comments

Chris Chiu June 12, 2024, 5:34 a.m. UTC | #1
On Wed, Jun 12, 2024 at 9:34 AM AceLan Kao <acelan.kao@canonical.com> wrote:
>
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
>
> BugLink: https://bugs.launchpad.net/bugs/2065128
>
> [Impact]
> Lost WIFI connection after suspend.
> While this happen, the WIFI module couldn't detect any AP, re-enable module and reboot OS without any help.
> There only way to get it back is cold boot.
>
> [Fix]
> Realtek provides a fix which has been included in rtw maintainer's tree
> https://lore.kernel.org/linux-wireless/20240426061200.44262-1-pkshih@realtek.com/T/#mbfcb37c2fdc85ba280743f2b07fbf1fa8719eb79
>
> The commits has been included in v6.10-rc1
> 4e5957101d42 wifi: rtw89: 8852c: refine power sequence to imporve power consumption
> 535c045da60f wifi: rtw89: reset AFEDIG register in power off sequence
>
> [Test case]
> 1. Boot into OS
> 2. open terminal to keep checking dmesg or check the wifi connection from GUI
> 3. suspend/resume multiple times
> 4. check the wifi connection
>
> [Where problems could occur]
> What the 2 commits should be safe and won't introduce any regression.
> 1. Reset AFEDIG register before BB reset in power off sequence
> 2. Adjust power and clock parameters
>
> Chia-Yuan Li (1):
>   wifi: rtw89: 8852c: refine power sequence to imporve power consumption
>
> Chin-Yen Lee (1):
>   wifi: rtw89: reset AFEDIG register in power off sequence
>
>  drivers/net/wireless/realtek/rtw89/rtw8851b.c |  1 +
>  drivers/net/wireless/realtek/rtw89/rtw8852b.c |  2 ++
>  drivers/net/wireless/realtek/rtw89/rtw8852c.c | 12 ++++++++++--
>  3 files changed, 13 insertions(+), 2 deletions(-)
>
> --
> 2.34.1
>

Acked-by: Chris Chiu <chris.chiu@canonical.com>

>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Timo Aaltonen June 12, 2024, 7:52 a.m. UTC | #2
AceLan Kao kirjoitti 12.6.2024 klo 4.33:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2065128
> 
> [Impact]
> Lost WIFI connection after suspend.
> While this happen, the WIFI module couldn't detect any AP, re-enable module and reboot OS without any help.
> There only way to get it back is cold boot.
> 
> [Fix]
> Realtek provides a fix which has been included in rtw maintainer's tree
> https://lore.kernel.org/linux-wireless/20240426061200.44262-1-pkshih@realtek.com/T/#mbfcb37c2fdc85ba280743f2b07fbf1fa8719eb79
> 
> The commits has been included in v6.10-rc1
> 4e5957101d42 wifi: rtw89: 8852c: refine power sequence to imporve power consumption
> 535c045da60f wifi: rtw89: reset AFEDIG register in power off sequence
> 
> [Test case]
> 1. Boot into OS
> 2. open terminal to keep checking dmesg or check the wifi connection from GUI
> 3. suspend/resume multiple times
> 4. check the wifi connection
> 
> [Where problems could occur]
> What the 2 commits should be safe and won't introduce any regression.
> 1. Reset AFEDIG register before BB reset in power off sequence
> 2. Adjust power and clock parameters
> 
> Chia-Yuan Li (1):
>    wifi: rtw89: 8852c: refine power sequence to imporve power consumption
> 
> Chin-Yen Lee (1):
>    wifi: rtw89: reset AFEDIG register in power off sequence
> 
>   drivers/net/wireless/realtek/rtw89/rtw8851b.c |  1 +
>   drivers/net/wireless/realtek/rtw89/rtw8852b.c |  2 ++
>   drivers/net/wireless/realtek/rtw89/rtw8852c.c | 12 ++++++++++--
>   3 files changed, 13 insertions(+), 2 deletions(-)
> 

Acked-by: Timo Aaltonen <timo.aaltonen@canonical.com>
Paolo Pisati June 12, 2024, 8:53 a.m. UTC | #3
On Wed, Jun 12, 2024 at 09:33:31AM +0800, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2065128

Clean cherry-picks.

Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
Roxana Nicolescu June 17, 2024, 9:03 a.m. UTC | #4
On 12/06/2024 03:33, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
>
> BugLink: https://bugs.launchpad.net/bugs/2065128
>
> [Impact]
> Lost WIFI connection after suspend.
> While this happen, the WIFI module couldn't detect any AP, re-enable module and reboot OS without any help.
> There only way to get it back is cold boot.
>
> [Fix]
> Realtek provides a fix which has been included in rtw maintainer's tree
> https://lore.kernel.org/linux-wireless/20240426061200.44262-1-pkshih@realtek.com/T/#mbfcb37c2fdc85ba280743f2b07fbf1fa8719eb79
>
> The commits has been included in v6.10-rc1
> 4e5957101d42 wifi: rtw89: 8852c: refine power sequence to imporve power consumption
> 535c045da60f wifi: rtw89: reset AFEDIG register in power off sequence
>
> [Test case]
> 1. Boot into OS
> 2. open terminal to keep checking dmesg or check the wifi connection from GUI
> 3. suspend/resume multiple times
> 4. check the wifi connection
>
> [Where problems could occur]
> What the 2 commits should be safe and won't introduce any regression.
> 1. Reset AFEDIG register before BB reset in power off sequence
> 2. Adjust power and clock parameters
>
> Chia-Yuan Li (1):
>    wifi: rtw89: 8852c: refine power sequence to imporve power consumption
>
> Chin-Yen Lee (1):
>    wifi: rtw89: reset AFEDIG register in power off sequence
>
>   drivers/net/wireless/realtek/rtw89/rtw8851b.c |  1 +
>   drivers/net/wireless/realtek/rtw89/rtw8852b.c |  2 ++
>   drivers/net/wireless/realtek/rtw89/rtw8852c.c | 12 ++++++++++--
>   3 files changed, 13 insertions(+), 2 deletions(-)
>
Applied to noble:linux master-next branch. Thanks!