From patchwork Tue May 28 15:53:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mitchell Augustin X-Patchwork-Id: 1940634 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VpcVz6dnBz20Q9 for ; Wed, 29 May 2024 01:53:31 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1sBz8f-0004z4-8A; Tue, 28 May 2024 15:53:25 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1sBz8b-0004wh-Gb for kernel-team@lists.ubuntu.com; Tue, 28 May 2024 15:53:21 +0000 Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4361C3F339 for ; Tue, 28 May 2024 15:53:21 +0000 (UTC) Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-3d1c7b5c0beso766482b6e.2 for ; Tue, 28 May 2024 08:53:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716911600; x=1717516400; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CUkVm8UYNiDJpWHC0lvLn6rNMF/i4QNra3CjufKANgY=; b=mKh1sgbDx6XWdBtG5zxMHlX1gUjaOxqJ4uvIK7zk4RFC4gdNaBzlNY/v8FKfE+rvap S+b3k/Sziz7g8aIZJtKA9bujBKT5oKj82Vhhr4wJX2lpfbl5jTWphfVUPvZIdSlf3e2T cex539J0IEZ78gbK8lSTNmZfLgpQbHzeOLKDjDb/WIFtmglwXaSBoKCd4lFf6fubuivt uGTGDKoDyOzUfZURGseFinnPoFmgQNLP9wJp7sqCtqYOdxabQKcmTI/OKRO7aBqKdwmv gFX+TF21tfq/jwJjONSs+zzLIa9zN3GtBchJEXk6glNgAn4CjQxKRyy14DiEfEUmNbf4 upKA== X-Gm-Message-State: AOJu0Yw7aak3eoCebEhT1Jha27Nj35jXrhCmpoStUAZ9YwmT5m4yfq27 LJ8cjtZgwYVh7D1zVgQDT+Z8c5YAURNDHp9+bfE2T7OdlToaylQ4xTDZSjRED+1OJeMUoeZyzDc k4bGbeJrfpzm5wQUDNCU8F6vqjPAo1udJilTpUfaABNAxy0q4Yn8qKc1tj/o8myShYAEynjTX3F 4nXGvMeMt8yA== X-Received: by 2002:a05:6808:170f:b0:3c9:c755:a192 with SMTP id 5614622812f47-3d1a774aaf0mr17115753b6e.57.1716911599762; Tue, 28 May 2024 08:53:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGp+++6GZuRn0KfiHi5i4xaC6W7rxcOGWI0aEZ4UZNfYEL8XkIujW4QxUpESWOMvWiKHbeVqA== X-Received: by 2002:a05:6808:170f:b0:3c9:c755:a192 with SMTP id 5614622812f47-3d1a774aaf0mr17115737b6e.57.1716911599404; Tue, 28 May 2024 08:53:19 -0700 (PDT) Received: from localhost (sub10810.htc.net. [216.114.108.10]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ac070c2f9csm45225066d6.27.2024.05.28.08.53.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 08:53:19 -0700 (PDT) From: mitchell.augustin@canonical.com To: kernel-team@lists.ubuntu.com Subject: [SRU][Noble][PATCH v2 0/1] UBUNTU: [Config]: Configure TPM drivers as builtins for arm64 in annotations Date: Tue, 28 May 2024 10:53:18 -0500 Message-Id: <20240528155318.249309-1-mitchell.augustin@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Mitchell Augustin BugLink: https://bugs.launchpad.net/bugs/2037688 [Impact] On Grace systems, the IMA driver emits the following log: ima: No TPM chip found, activating TPM-bypass! This occurs because the IMA driver initializes before we are able to detect the TPM. This will always be the case when the drivers required to communicate with the TPM, spi_tegra210_quad and tpm_tis_spi, are built as modules. [Test case] This change has been applied to the kernel in the following PPA, and both the 64k and 4k page size variants have been verified to allow the TPM to load as expected on our Grace machine: https://launchpad.net/~mitchellaugustin/+archive/ubuntu/grace-tpm-config-patch-4-24 [Fix] Having these drivers as built-ins ensures that the TPM is available before the IMA driver initializes. [Regression potential] The only potential regression I could expect is the increased binary size due to the additional modules being built-in Mitchell Augustin (1): UBUNTU: [Config]: Configure TPM drivers as builtins for arm64 in annotations debian.master/config/annotations | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Jacob Martin Acked-by: Thibault Ferrante