mbox series

[SRU,N,0/1] Fix inaudible HDMI/DP audio on USB-C MST dock

Message ID 20240528032047.396520-1-kai.heng.feng@canonical.com
Headers show
Series Fix inaudible HDMI/DP audio on USB-C MST dock | expand

Message

Kai-Heng Feng May 28, 2024, 3:20 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2064689

[Impact]
HDMI/DP audio isn't working on Dell's USB-C dock.

[Fix]
Leave Maud/Naud as is, since the hardware programmed the right value
already.

[Test]
HDMI/DP audio always comes out from the USB-C dock after the fix is
applied.

[Where problems could occur]
DP/HDMI audio _might_ stop working.

However, the commit has been in mainline and OEM kernel for quite a
while, the absence of regression report is a good sign.

Chaitanya Kumar Borah (1):
  drm/i915/audio: Fix audio time stamp programming for DP

 drivers/gpu/drm/i915/display/intel_audio.c | 113 ++-------------------
 1 file changed, 8 insertions(+), 105 deletions(-)

Comments

Thibault Ferrante May 28, 2024, 9:23 a.m. UTC | #1 
On 28-05-2024 05:20, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2064689
> 
> [Impact]
> HDMI/DP audio isn't working on Dell's USB-C dock.
> 
> [Fix]
> Leave Maud/Naud as is, since the hardware programmed the right value
> already.
> 
> [Test]
> HDMI/DP audio always comes out from the USB-C dock after the fix is
> applied.
> 
> [Where problems could occur]
> DP/HDMI audio _might_ stop working.
> 
> However, the commit has been in mainline and OEM kernel for quite a
> while, the absence of regression report is a good sign.
> 
> Chaitanya Kumar Borah (1):
>    drm/i915/audio: Fix audio time stamp programming for DP
> 
>   drivers/gpu/drm/i915/display/intel_audio.c | 113 ++-------------------
>   1 file changed, 8 insertions(+), 105 deletions(-)
> 
Acked-by: Thibault Ferrante <thibault.ferrante@canonical.com>

--
Thibault
Paolo Pisati May 28, 2024, 9:48 a.m. UTC | #2 
On Tue, May 28, 2024 at 11:20:46AM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2064689

Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
Andrei Gherzan May 28, 2024, 11:53 a.m. UTC | #3 
On 24/05/28 11:20am, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2064689
> 
> [Impact]
> HDMI/DP audio isn't working on Dell's USB-C dock.
> 
> [Fix]
> Leave Maud/Naud as is, since the hardware programmed the right value
> already.
> 
> [Test]
> HDMI/DP audio always comes out from the USB-C dock after the fix is
> applied.
> 
> [Where problems could occur]
> DP/HDMI audio _might_ stop working.
> 
> However, the commit has been in mainline and OEM kernel for quite a
> while, the absence of regression report is a good sign.
> 
> Chaitanya Kumar Borah (1):
>   drm/i915/audio: Fix audio time stamp programming for DP
> 
>  drivers/gpu/drm/i915/display/intel_audio.c | 113 ++-------------------
>  1 file changed, 8 insertions(+), 105 deletions(-)

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Stefan Bader May 31, 2024, 3:36 p.m. UTC | #4 
On 28.05.24 05:20, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2064689
> 
> [Impact]
> HDMI/DP audio isn't working on Dell's USB-C dock.
> 
> [Fix]
> Leave Maud/Naud as is, since the hardware programmed the right value
> already.
> 
> [Test]
> HDMI/DP audio always comes out from the USB-C dock after the fix is
> applied.
> 
> [Where problems could occur]
> DP/HDMI audio _might_ stop working.
> 
> However, the commit has been in mainline and OEM kernel for quite a
> while, the absence of regression report is a good sign.
> 
> Chaitanya Kumar Borah (1):
>    drm/i915/audio: Fix audio time stamp programming for DP
> 
>   drivers/gpu/drm/i915/display/intel_audio.c | 113 ++-------------------
>   1 file changed, 8 insertions(+), 105 deletions(-)
> 

Applied to noble:linux/master-next. Thanks.

-Stefan