From patchwork Mon May 20 22:01:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asmaa Mnebhi X-Patchwork-Id: 1937142 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vjs3P49Nmz1ydW for ; Tue, 21 May 2024 08:01:37 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1s9B4T-0003JW-NM; Mon, 20 May 2024 22:01:29 +0000 Received: from mail-dm6nam04on2045.outbound.protection.outlook.com ([40.107.102.45] helo=NAM04-DM6-obe.outbound.protection.outlook.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1s9B4Q-0003JG-Bb for kernel-team@lists.ubuntu.com; Mon, 20 May 2024 22:01:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lagdpEmEUgBCLL09wiwNop+aifXisWOSMpBJglJiG/9/7l8nLsLqLF66GFfWAsiAJAWUWgFRxyGtFfDDxT/v41X74PmJnVYTIARdBEodt94FHJL2QghItXem5UqIq74p6MoCnYGGuRiPk6qzy+ZwHdEFaWrbcP7Bnkm2Fpuuh4n8cleDbFT4sKz6zC2bv/ujo1njc3As//6rU+Yphl6v/6w7xsjlSHHMR40vSlsxhZ+19hHDJfv+5Yui2e281fmoOf8N+bKqB1uk8dzdhumSw8Xul3GxXraCIDrVi7bIS+Jq+a51pm68oHRLZZOkLLN37Pr7ohhL9B4Ipiwot98y1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PW65CZv3nqX9CqAj/hdbFx7zYk/i8ef9nzS7V1AVQMI=; b=NWubZfX3KFWZ+7Nlplilk86AzhIeV9kr7yCVDu1ObAyoYAy9hzMobI6dFOJyX25tVbTZ4IJ8cl0HU5Nyjh1DLPchbxqKpANp+e0W1HeHsC/OOKq98IvINUdP4eYg8zd6mjG/L8EOUQt3mxvgmiJ/n1ZZsXuj/v6mViaWxz945flTdfPb34HsLDdE1WQg9U6cFqfT0yF+36q9ZtYBAbBhC1xmhWRkX0LLka8+1j0sCxS0Unw9JVt+b5b1Cer8DPPPtC5lY5juE1R5hG/KD2nc1dTnhln+MA3F43rg6i10/sPlYDnDE4t91VdlNgAJ53RwCgvu6PdCFhu3o4ds5EH/nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) Received: from CH2PR18CA0022.namprd18.prod.outlook.com (2603:10b6:610:4f::32) by CY8PR12MB8411.namprd12.prod.outlook.com (2603:10b6:930:6e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.34; Mon, 20 May 2024 22:01:21 +0000 Received: from CH3PEPF0000000D.namprd04.prod.outlook.com (2603:10b6:610:4f:cafe::9f) by CH2PR18CA0022.outlook.office365.com (2603:10b6:610:4f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36 via Frontend Transport; Mon, 20 May 2024 22:01:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CH3PEPF0000000D.mail.protection.outlook.com (10.167.244.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.14 via Frontend Transport; Mon, 20 May 2024 22:01:20 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 20 May 2024 15:01:07 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 20 May 2024 15:01:06 -0700 Received: from vdi.nvidia.com (10.127.8.14) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 20 May 2024 15:01:06 -0700 From: Asmaa Mnebhi To: Subject: [SRU][J:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: gpio-mlxbf3: During reboot test, ipmb driver fails to load intermittently Date: Mon, 20 May 2024 18:01:03 -0400 Message-ID: <20240520220104.3602-1-asmaa@nvidia.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000D:EE_|CY8PR12MB8411:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a177cd1-d7d2-4de1-0ee0-08dc791861ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|82310400017|376005|36860700004; X-Microsoft-Antispam-Message-Info: iT1VlotilC3xV9YKDRwf1r3qCoFYpXXSusrGHiNeAznennu3wjjSGBJlBvdTEd9IMA+Lmwsf15b+mjA89CLi7RN7ln/s9zLYc4Cxbp6WYzi2qv3hIrrW0u3HRymE61YmLqVuXYdR5t5P+KsLeBjg520sdzJO+XbZNDlOeaiGXlHjKgC5LdC9aJRLi1Fhu1T1QtbyEkI7GQS2BWEZAvA+d+79GdIBPANxjNtIAlT8tV+i6OJ0vFXoTQKP8SRj8A32f5ub0FtzUCh4iLGlj69C8ojukx+mBdTmorbhfvCYJETZ3F17HdGHHvAUCX08bR8+K9SuepfZHJDgQICdR3sAgcH/UFTstAx+GEpCIjMtdGsy1w7aUv7LkF2oQx7d350NaW5QR7lxR8iADQb30WzkZoR+ol5iIJaHQWJF/F0BLdg9+L3kBp96aHfl6eND6JxVJqsY8kzlCQ4Iy5Om5cbYXnoovCps2CLr9Sf/YBg+AppOipZX30IT4EvelRU+WXu927vKuivvYxaQGB72EZyyWjSnU1csV7xdeJXAA0IvwC8WlU9HRZMTHovXm27d96Q8jn2xPhpz8f7JTh65MtyvlRLCZgmlA+hXTrSomCY182vXCNVYcXzy9Ge6/F2KBiLM/eVVsJD9jTTI/hIl54Cyv+1nkS8VWDUdYb9WUvAIOrr11cDl5p0upzyRlRLmDXaONonHYJrecltRk0wxYUbEXFdiE2ELMPGZiPyUaqqwdWWawwuCoFGiO7ntCsAaEF6shN4vn83knLDpIdJ6f9W5N5N8pg944Ha7P6gGvON8b+wB93QSKBWB0Ki2xct0PWMfmvea95alxk92ursetcnc588bxcJ8SBMIMqqMMQgunkDS+fVN1zc7QIfmyprl/4fHTBgE/cvekCBiL+Np4apPr5wfGvFak3kvt1n9fTSTTXWlFIuOjiTEq6D48aGm8NMscXhwlGt7pUqP3KCZSGqpglysankK0bSx81qXILmBkyolUz5DXCDLaniF+r+nr3bjmbCPOhzwt8N6I44RXxW+8a7BMyP3U5kLT1VSFgaxf29BlYjnoTUr2p1UDMNQ4gtHsCxLBBoceVnSbHIf2l1/K/yATga30waAnDTlqYqF7QsclCwAwYfRyjmHt/Mpkk7XEAgkI+Nnq0+5z6opsKIvvMdJ7a84U2zRcwaPDvgQd+zGL/tpl/u1PN+hHg9VBwimHHl3mfdBCJ1JUyX/mog+1mO1dQD6x5eIK+fkMbeKBFaLgPWi+wq4xFMALSegiE3Lk530kaVuKRRLRsZ57RRRmF3ryFhfRc/9MlFLxmlMsrYu7iUi6qBufrUS2huxtVMz2G8GazYIstRNBEAtK8WYse8/wvajBrQMvDQVQp27Vms= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400017)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 22:01:20.7528 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a177cd1-d7d2-4de1-0ee0-08dc791861ee X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8411 Received-SPF: softfail client-ip=40.107.102.45; envelope-from=asmaa@nvidia.com; helo=NAM04-DM6-obe.outbound.protection.outlook.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Asmaa Mnebhi Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2066198 SRU Justification: [Impact] The ipmb driver failing to load is just the result of i2c-mlxbf not receiving interrupts. In fact, any driver dependent on the i2c-mlxbf driver will not work. How to reproduce this issue? - modprobe gpio-mlxbf3 - modprobe pwr-mlxbf - modprobe mlxbf-gige -> this calls into the gpio driver which enables the PHY interrupt (gpio10) - reboot linux -> graceful reboot does not remove modules so it doesn't disable the PHY interrupt via mlxbf3_gpio_irq_disable. Hence, the interrupt remains enabled. - In anolis, we don't enforce the dependency between gpio-mlxbf3 and mlxbf-gige. So the next time linux boots and loads the driver in this order, we encounter the issue: - modprobe mlxbf-gige. The gige driver uses polling in the case where it loads before the gpio driver. Note that the interrupt at GPIO10 is still enabled at this point so if the interrupt triggers, there is nothing to clear it. - modprobe gpio-mlxbf3 - modprobe i2c-mlxbf. The interrupt wouldn't work here because it is shared with the gpio interrupts which was not cleared. [Fix] * The solution is to add a shutdown function to the gpio driver to clear and disable all interrupts. * Also make sure to clear the interrupt after disabling it in the disable irq function. [Test Case] * Do the reboot test (2000-3000 iterations) * Check that all following drivers are loaded without errors: gpio-mlxbf3, pwr_mlxbf, mlxbf-gige, i2c-mlxbf * check that the ipmb drivers are loaded and functional (send ipmb command to the bmc and vice versa) [Regression Potential] * No known regression. Acked-by: Tim Gardner Acked-by: Bartlomiej Zolnierkiewicz