| Message ID | 20240506082208.4711-1-aaron.ma@canonical.com |
|---|---|
| Headers | show |
| Series | Fix I2C HID device failure when initialize touchpad | expand |
Missed Noble tag in subject, v2 is coming. Aaron On 5/6/24 4:22 PM, Aaron Ma wrote: > BugLink: https://bugs.launchpad.net/bugs/2061040 > > [Impact] > Sensel haptic pad doesn't work on boot. > Error log: > i2c_hid_acpi i2c-SNSL0028:00: device did not ack reset within 1000 ms > hid-generic 0018:2C2F:0028.0001: unknown main item tag 0x0 > > [Fix] > This issue is a regression of commit from v6.8-rc1 : > commit: af93a167eda9 ("HID: i2c-hid: Move i2c_hid_finish_hwreset() to after reading the report-descriptor") > Fix commit: ea36bf1827462 ("HID: i2c-hid: Revert to await reset ACK before reading report descriptor") > > [Test] > Tested on hardware, touchpad works after boot. > > [Where problems could occur] > It may break HID input. > > It is a regression on 6.8-rc1, SRU for Noble only. > > Kenny Levinsen (1): > HID: i2c-hid: Revert to await reset ACK before reading report > descriptor > > drivers/hid/i2c-hid/i2c-hid-core.c | 29 ++++++++--------------------- > 1 file changed, 8 insertions(+), 21 deletions(-) >
On 5/7/24 05:13, Aaron Ma wrote: > Missed Noble tag in subject, v2 is coming. > > Aaron > > On 5/6/24 4:22 PM, Aaron Ma wrote: >> BugLink: https://bugs.launchpad.net/bugs/2061040 >> >> [Impact] >> Sensel haptic pad doesn't work on boot. >> Error log: >> i2c_hid_acpi i2c-SNSL0028:00: device did not ack reset within 1000 ms >> hid-generic 0018:2C2F:0028.0001: unknown main item tag 0x0 >> >> [Fix] >> This issue is a regression of commit from v6.8-rc1 : >> commit: af93a167eda9 ("HID: i2c-hid: Move i2c_hid_finish_hwreset() to >> after reading the report-descriptor") >> Fix commit: ea36bf1827462 ("HID: i2c-hid: Revert to await reset ACK >> before reading report descriptor") >> >> [Test] >> Tested on hardware, touchpad works after boot. >> >> [Where problems could occur] >> It may break HID input. >> >> It is a regression on 6.8-rc1, SRU for Noble only. >> >> Kenny Levinsen (1): >> HID: i2c-hid: Revert to await reset ACK before reading report >> descriptor >> >> drivers/hid/i2c-hid/i2c-hid-core.c | 29 ++++++++--------------------- >> 1 file changed, 8 insertions(+), 21 deletions(-) >> > > Terminate the thread
BugLink: https://bugs.launchpad.net/bugs/2061040 [Impact] Sensel haptic pad doesn't work on boot. Error log: i2c_hid_acpi i2c-SNSL0028:00: device did not ack reset within 1000 ms hid-generic 0018:2C2F:0028.0001: unknown main item tag 0x0 [Fix] This issue is a regression of commit from v6.8-rc1 : commit: af93a167eda9 ("HID: i2c-hid: Move i2c_hid_finish_hwreset() to after reading the report-descriptor") Fix commit: ea36bf1827462 ("HID: i2c-hid: Revert to await reset ACK before reading report descriptor") [Test] Tested on hardware, touchpad works after boot. [Where problems could occur] It may break HID input. It is a regression on 6.8-rc1, SRU for Noble only. Kenny Levinsen (1): HID: i2c-hid: Revert to await reset ACK before reading report descriptor drivers/hid/i2c-hid/i2c-hid-core.c | 29 ++++++++--------------------- 1 file changed, 8 insertions(+), 21 deletions(-)