From patchwork Wed May 1 12:34:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Righi X-Patchwork-Id: 1930158 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VTxW62YH6z23jG for ; Wed, 1 May 2024 22:40:49 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1s29GC-0004Xk-1v; Wed, 01 May 2024 12:40:32 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1s29GA-0004XJ-7R for kernel-team@lists.ubuntu.com; Wed, 01 May 2024 12:40:30 +0000 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 1CF663F15B for ; Wed, 1 May 2024 12:40:28 +0000 (UTC) Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a58bca80981so360778366b.0 for ; Wed, 01 May 2024 05:40:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714567227; x=1715172027; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AOIAZySprg9xz3WPT74ONrCVgV8p/CV/GaHB7KZKeH0=; b=i3mChkvgR4UhHUNecn+NbQTCO8s2EzuE73us+srMT9E+wRL+FqpsvgagfuV3RcwidX OUG5BYF3SDc2JCJHYZ86MQGCFB5l83cWVmY55yGwF9yzxAk4zJRK0RaLErPk03WxY3RL v0PfcASthnUONNSGXA4SFMLeMuhuWurrXo8vZ8ZQmCSpdzmadj7jde0xIzT8Wj6umPco aH+coW7aExWSCL60v7h+aCkUfy7kjD0h2S2ShlbNhQhdMP/+lRCVBUlo9T5jHMHOtfF6 UviYVsrqa3t+OXxdJQiBCWcAdrL7S0lSV5TSs67HKx0cQiYWjszorOj44tVOhn+ml1TC /ElA== X-Gm-Message-State: AOJu0YzYDzEvPxQLmL2G99crugSGdvb9TSPDy5LseVMl3pUJ1tFg3log O7FTXJ2rgAmSKQPqN6TyH2wlDA6SFoF2PPt2NpPC1MFXLaGVonnXxNf01UnULV5j/kld7wCtlR+ rzv9GErABJ+kU3obG9wdlxjRGGfGqfvBhoHfczDYHCfpoJyN6dGwddS9WPOiKcdfvFG8ApqRMvN hb25XjY8yIiA== X-Received: by 2002:a17:906:52c1:b0:a55:5ddd:e5f6 with SMTP id w1-20020a17090652c100b00a555ddde5f6mr1913145ejn.28.1714567227253; Wed, 01 May 2024 05:40:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGeGkMRaoIFo+BFDCtssNArct24B38jSsEAGn+YRfUz5xdHitsxkvVpF+mFBNTW94N7zg/r7A== X-Received: by 2002:a17:906:52c1:b0:a55:5ddd:e5f6 with SMTP id w1-20020a17090652c100b00a555ddde5f6mr1913130ejn.28.1714567226722; Wed, 01 May 2024 05:40:26 -0700 (PDT) Received: from gpd.homenet.telecomitalia.it (host-82-49-69-7.retail.telecomitalia.it. [82.49.69.7]) by smtp.gmail.com with ESMTPSA id i7-20020a1709061e4700b00a52244ab819sm16602108ejj.170.2024.05.01.05.40.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 05:40:26 -0700 (PDT) From: Andrea Righi To: kernel-team@lists.ubuntu.com Subject: [SRU][N][PATCH 0/4] re-enable Ubuntu FAN in the Noble kernel Date: Wed, 1 May 2024 14:34:56 +0200 Message-ID: <20240501124023.683940-1-andrea.righi@canonical.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2064508 [Impact] In LP: #2063298, we have opted to deprecate Ubuntu FAN support because of the maintenance overhead and the possibility of regressions / conflicts with the new networking eBPF APIs in kernels >= 6.8. However, we cannot disable this feature in HWE/backport kernels, so it seems safer to adjust the Ubuntu FAN kernel patch set to ensure proper co-existence with the updated vxlan policy requirements in newer 6.8 kernels. The re-introduction of Ubuntu FAN should be considered as a temporary measure, aimed at facilitating a smooth transition during its deprecation without disrupting existing users (specifically Juju), and enabling the backporting of 6.8 kernels to older releases. The main plan is still to deprecate Ubuntu FAN in newer releases. [Test case] Rely on the specific Ubuntu FAN regression test to validate the proper kernel support of this feature: https://git.launchpad.net/~canonical-kernel-team/+git/autotest-client-tests/tree/ubuntu_fan_smoke_test?h=autotest3 [Fix] Re-apply the Ubuntu FAN patch set to the latest Noble kernel 6.8 and integrate the IFLA_VXLAN_FAN_MAP attribute type in vxlan_policy to satisfy the strict length validation check. Test result (ubuntu_fan_smoke_test) with this patch set applied to the latest Noble kernel: 11:48:05 INFO | Writing results to /home/ubuntu/autotest/client/results/default 11:48:05 INFO | START ---- ---- timestamp=1714564085 localtime=May 01 11:48:05 11:48:05 INFO | START ubuntu_fan_smoke_test.setup ubuntu_fan_smoke_test.setup timeout=1200 timestamp=1714564085 localtime=May 01 11:48:05 11:48:07 INFO | GOOD ubuntu_fan_smoke_test.setup ubuntu_fan_smoke_test.setup timestamp=1714564087 localtime=May 01 11:48:07 completed successfully 11:48:07 INFO | END GOOD ubuntu_fan_smoke_test.setup ubuntu_fan_smoke_test.setup timestamp=1714564087 localtime=May 01 11:48:07 11:48:07 INFO | START ubuntu_fan_smoke_test.fan-smoke-test ubuntu_fan_smoke_test.fan-smoke-test timeout=1800 timestamp=1714564087 localtime=May 01 11:48:07 11:51:46 INFO | Testing Fan Networking (pre-0.13.0 API) 11:51:46 INFO | docker pull --platform linux/amd64 ubuntu: PASSED 11:51:46 INFO | enable disable fan test: PASSED 11:51:46 INFO | fanctl show test: PASSED 11:51:46 INFO | fanctl check bridge config test: PASSED 11:51:46 INFO | fanatic docker test(--dns=192.168.122.1): PASSED 11:51:47 INFO | GOOD ubuntu_fan_smoke_test.fan-smoke-test ubuntu_fan_smoke_test.fan-smoke-test timestamp=1714564307 localtime=May 01 11:51:47 completed successfully 11:51:47 INFO | END GOOD ubuntu_fan_smoke_test.fan-smoke-test ubuntu_fan_smoke_test.fan-smoke-test timestamp=1714564307 localtime=May 01 11:51:47 11:51:47 INFO | END GOOD ---- ---- timestamp=1714564307 localtime=May 01 11:51:47 11:51:47 INFO | Report successfully generated at /home/ubuntu/autotest/client/results/default/job_report.html [Regression potential] We may experience regressions with eBPF vxlan capabilities and potentially specific use cases of the Ubuntu FAN technology (Juju installations). ---------------------------------------------------------------- Andrea Righi (1): UBUNTU: SAUCE: fan: support vxlan strict length validation Jay Vosburgh (2): UBUNTU: SAUCE: fan: tunnel multiple mapping mode (v3) UBUNTU: SAUCE: fan: add VXLAN implementation Juerg Haefliger (1): UBUNTU: SAUCE: fan: Fix NULL pointer dereference drivers/net/vxlan/vxlan_core.c | 264 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ include/net/ip_tunnels.h | 28 +++++++++++ include/net/vxlan.h | 2 + include/uapi/linux/if_link.h | 1 + include/uapi/linux/if_tunnel.h | 19 ++++++++ net/ipv4/ip_tunnel.c | 2 +- net/ipv4/ipip.c | 311 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 7 files changed, 624 insertions(+), 3 deletions(-) Acked-by: Roxana Nicolescu Acked-by: Stefan Bader