mbox series

[0/2,m/n:linux-aws] aws: aws: KVM and guest support for the PSCI SYSTEM_OFF2 (hibernate) call

Message ID 20240419171853.81663-1-philip.cox@canonical.com
Headers show
Series aws: aws: KVM and guest support for the PSCI SYSTEM_OFF2 (hibernate) call | expand

Message

Philip Cox April 19, 2024, 5:18 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2061006


SRU Justification:

[Impact]
PSCI v1.3 adds support for SYSTEM_OFF2 which is analogous to ACPI S4 state.

This will allow hosting environments to determine that a guest is hibernated rather than just powered off, and ensure that they preserve the virtual environment appropriately to allow the guest to resume safely (or bump the hardware_signature in the FACS to trigger a clean reboot instead).

[Fix]
This adds support for it to KVM, and to the guest hibernate code.

https://lore.kernel.org/lkml/20240312135958.727765-1-dwmw2@infradead.org

[Test Plan]
AWS tested.

[Where problems could occur]
If the final spec of the PSCI v1.3 changes, there may be changes required to this patch series.

[Other Info]

SF# 00383181

--



David Woodhouse (2):
  UBUNTU: SAUCE: ACPICA: Detect FACS even for hardware reduced platforms
  UBUNTU: SAUCE: arm64: acpi: Honour firmware_signature field of FACS,
    if it exists

 arch/arm64/kernel/acpi.c      | 10 ++++++++++
 drivers/acpi/acpica/tbfadt.c  | 30 +++++++++++++-----------------
 drivers/acpi/acpica/tbutils.c |  7 +------
 3 files changed, 24 insertions(+), 23 deletions(-)

Comments

Portia Stephens May 28, 2024, 11:58 p.m. UTC | #1
On Fri, Apr 19, 2024 at 01:18:51PM -0400, Philip Cox wrote:
> BugLink: https://bugs.launchpad.net/bugs/2061006
> 
> 
> SRU Justification:
> 
> [Impact]
> PSCI v1.3 adds support for SYSTEM_OFF2 which is analogous to ACPI S4 state.
> 
> This will allow hosting environments to determine that a guest is hibernated rather than just powered off, and ensure that they preserve the virtual environment appropriately to allow the guest to resume safely (or bump the hardware_signature in the FACS to trigger a clean reboot instead).
> 
> [Fix]
> This adds support for it to KVM, and to the guest hibernate code.
> 
> https://lore.kernel.org/lkml/20240312135958.727765-1-dwmw2@infradead.org
> 
> [Test Plan]
> AWS tested.
> 
> [Where problems could occur]
> If the final spec of the PSCI v1.3 changes, there may be changes required to this patch series.
> 
> [Other Info]
> 
> SF# 00383181

Acked-by: Portia Stephens <portia.stephens@canonical.com>
Tim Gardner May 29, 2024, 1:28 p.m. UTC | #2
On 4/19/24 11:18 AM, Philip Cox wrote:
> BugLink: https://bugs.launchpad.net/bugs/2061006
> 
> 
> SRU Justification:
> 
> [Impact]
> PSCI v1.3 adds support for SYSTEM_OFF2 which is analogous to ACPI S4 state.
> 
> This will allow hosting environments to determine that a guest is hibernated rather than just powered off, and ensure that they preserve the virtual environment appropriately to allow the guest to resume safely (or bump the hardware_signature in the FACS to trigger a clean reboot instead).
> 
> [Fix]
> This adds support for it to KVM, and to the guest hibernate code.
> 
> https://lore.kernel.org/lkml/20240312135958.727765-1-dwmw2@infradead.org
> 
> [Test Plan]
> AWS tested.
> 
> [Where problems could occur]
> If the final spec of the PSCI v1.3 changes, there may be changes required to this patch series.
> 
> [Other Info]
> 
> SF# 00383181
> 
> --
> 
> 
> 
> David Woodhouse (2):
>    UBUNTU: SAUCE: ACPICA: Detect FACS even for hardware reduced platforms
>    UBUNTU: SAUCE: arm64: acpi: Honour firmware_signature field of FACS,
>      if it exists
> 
>   arch/arm64/kernel/acpi.c      | 10 ++++++++++
>   drivers/acpi/acpica/tbfadt.c  | 30 +++++++++++++-----------------
>   drivers/acpi/acpica/tbutils.c |  7 +------
>   3 files changed, 24 insertions(+), 23 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Roxana Nicolescu June 17, 2024, 9:13 a.m. UTC | #3
On 19/04/2024 19:18, Philip Cox wrote:
> BugLink: https://bugs.launchpad.net/bugs/2061006
>
>
> SRU Justification:
>
> [Impact]
> PSCI v1.3 adds support for SYSTEM_OFF2 which is analogous to ACPI S4 state.
>
> This will allow hosting environments to determine that a guest is hibernated rather than just powered off, and ensure that they preserve the virtual environment appropriately to allow the guest to resume safely (or bump the hardware_signature in the FACS to trigger a clean reboot instead).
>
> [Fix]
> This adds support for it to KVM, and to the guest hibernate code.
>
> https://lore.kernel.org/lkml/20240312135958.727765-1-dwmw2@infradead.org
>
> [Test Plan]
> AWS tested.
>
> [Where problems could occur]
> If the final spec of the PSCI v1.3 changes, there may be changes required to this patch series.
>
> [Other Info]
>
> SF# 00383181
>
> --
>
>
>
> David Woodhouse (2):
>    UBUNTU: SAUCE: ACPICA: Detect FACS even for hardware reduced platforms
>    UBUNTU: SAUCE: arm64: acpi: Honour firmware_signature field of FACS,
>      if it exists
>
>   arch/arm64/kernel/acpi.c      | 10 ++++++++++
>   drivers/acpi/acpica/tbfadt.c  | 30 +++++++++++++-----------------
>   drivers/acpi/acpica/tbutils.c |  7 +------
>   3 files changed, 24 insertions(+), 23 deletions(-)
>
This seems to be applied.