mbox series

[0/5,SRU,Noble/Unstable] obsolete out-of-tree ivsc dkms in favor of in-tree one

Message ID 20240419052424.278801-1-vicamo.yang@canonical.com
Headers show
Series obsolete out-of-tree ivsc dkms in favor of in-tree one | expand

Message

You-Sheng Yang April 19, 2024, 5:24 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2061747

[Impact]

Starting from kernel v6.8, Intel demands the use of in-tree VSC driver instead
of the out-of-tree dkms originated from https://github.com/intel/ivsc-driver.

[Fix]

The in-tree vsc driver as of v6.8 still needs a few fixes to archive the same
supportness to launched Intel IPU6 Camera devices. Commit 1,4, and 5 are to add
supported devices and platforms. Commit 2,3 resolve an issue after resumed.

[Test Case]

This is supposed to work together with the updated dkms, which shall also be
built along with the kernel itself as linux-modules-ipu6-<variant>. Install the
corresponding kernel/modules packages and test camera functions.

[Where problems could occur]

While this is the first time we switch to in-tree VSC driver, and the
out-of-tree driver is not aligned at the time of transition and probably never
will, the provided functions and verified stability issues may vary.

[Other Info]

The dkms is created to be compatible of multiple versions, yet the in-tree vsc
driver transitioning should only happen for kernel >= v6.8. That is, oem-6.8,
noble and linux-unstable will be nominated.

Hao Yao (1):
  UBUNTU: SAUCE: media: ipu-bridge: Support more sensors

Sakari Ailus (3):
  Revert "mei: vsc: Call wake_up() in the threaded IRQ handler"
  mei: vsc: Unregister interrupt handler for system suspend
  media: ipu-bridge: Add ov01a10 in Dell XPS 9315

Wentong Wu (1):
  ACPI: scan: Defer enumeration of devices with a _DEP pointing to IVSC
    device

 drivers/acpi/scan.c                  |  1 +
 drivers/media/pci/intel/ipu-bridge.c | 19 +++++++
 drivers/misc/mei/platform-vsc.c      | 17 +++++-
 drivers/misc/mei/vsc-tp.c            | 84 +++++++++++++++++++---------
 drivers/misc/mei/vsc-tp.h            |  3 +
 5 files changed, 98 insertions(+), 26 deletions(-)

Comments

AceLan Kao April 29, 2024, 11:50 p.m. UTC | #1
The patch 1, 4, and 5 add IDs which is simple and straightforward.
Patch 2 and 3 were also CC'd 6.8 stable, so we will eventually include them.
So, the patchset looks good to me.

Acked-By: AceLan Kao <acelan.kao@canonical.com>
Anthony Wong April 30, 2024, 9:15 a.m. UTC | #2
On Tue, Apr 30, 2024 at 07:50:48AM +0800, AceLan Kao wrote:
> The patch 1, 4, and 5 add IDs which is simple and straightforward.
> Patch 2 and 3 were also CC'd 6.8 stable, so we will eventually include them.
> So, the patchset looks good to me.
> 
> Acked-By: AceLan Kao <acelan.kao@canonical.com>

In addition, I'd expect Intel to eventually submit patch #5 to upstream.

Acked-By: Anthony Wong <anthony.wong@canonical.com>
Roxana Nicolescu April 30, 2024, 1:17 p.m. UTC | #3
On 19/04/2024 07:24, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2061747
>
> [Impact]
>
> Starting from kernel v6.8, Intel demands the use of in-tree VSC driver instead
> of the out-of-tree dkms originated from https://github.com/intel/ivsc-driver.
>
> [Fix]
>
> The in-tree vsc driver as of v6.8 still needs a few fixes to archive the same
> supportness to launched Intel IPU6 Camera devices. Commit 1,4, and 5 are to add
> supported devices and platforms. Commit 2,3 resolve an issue after resumed.
>
> [Test Case]
>
> This is supposed to work together with the updated dkms, which shall also be
> built along with the kernel itself as linux-modules-ipu6-<variant>. Install the
> corresponding kernel/modules packages and test camera functions.
>
> [Where problems could occur]
>
> While this is the first time we switch to in-tree VSC driver, and the
> out-of-tree driver is not aligned at the time of transition and probably never
> will, the provided functions and verified stability issues may vary.
>
> [Other Info]
>
> The dkms is created to be compatible of multiple versions, yet the in-tree vsc
> driver transitioning should only happen for kernel >= v6.8. That is, oem-6.8,
> noble and linux-unstable will be nominated.
>
> Hao Yao (1):
>    UBUNTU: SAUCE: media: ipu-bridge: Support more sensors
>
> Sakari Ailus (3):
>    Revert "mei: vsc: Call wake_up() in the threaded IRQ handler"
>    mei: vsc: Unregister interrupt handler for system suspend
>    media: ipu-bridge: Add ov01a10 in Dell XPS 9315
>
> Wentong Wu (1):
>    ACPI: scan: Defer enumeration of devices with a _DEP pointing to IVSC
>      device
>
>   drivers/acpi/scan.c                  |  1 +
>   drivers/media/pci/intel/ipu-bridge.c | 19 +++++++
>   drivers/misc/mei/platform-vsc.c      | 17 +++++-
>   drivers/misc/mei/vsc-tp.c            | 84 +++++++++++++++++++---------
>   drivers/misc/mei/vsc-tp.h            |  3 +
>   5 files changed, 98 insertions(+), 26 deletions(-)
>
Applied to noble master-next branch. Thanks!
Stefan Bader May 28, 2024, 10:57 a.m. UTC | #4
On 19.04.24 07:24, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2061747
> 
> [Impact]
> 
> Starting from kernel v6.8, Intel demands the use of in-tree VSC driver instead
> of the out-of-tree dkms originated from https://github.com/intel/ivsc-driver.
> 
> [Fix]
> 
> The in-tree vsc driver as of v6.8 still needs a few fixes to archive the same
> supportness to launched Intel IPU6 Camera devices. Commit 1,4, and 5 are to add
> supported devices and platforms. Commit 2,3 resolve an issue after resumed.
> 
> [Test Case]
> 
> This is supposed to work together with the updated dkms, which shall also be
> built along with the kernel itself as linux-modules-ipu6-<variant>. Install the
> corresponding kernel/modules packages and test camera functions.
> 
> [Where problems could occur]
> 
> While this is the first time we switch to in-tree VSC driver, and the
> out-of-tree driver is not aligned at the time of transition and probably never
> will, the provided functions and verified stability issues may vary.
> 
> [Other Info]
> 
> The dkms is created to be compatible of multiple versions, yet the in-tree vsc
> driver transitioning should only happen for kernel >= v6.8. That is, oem-6.8,
> noble and linux-unstable will be nominated.
> 
> Hao Yao (1):
>    UBUNTU: SAUCE: media: ipu-bridge: Support more sensors
> 
> Sakari Ailus (3):
>    Revert "mei: vsc: Call wake_up() in the threaded IRQ handler"
>    mei: vsc: Unregister interrupt handler for system suspend
>    media: ipu-bridge: Add ov01a10 in Dell XPS 9315
> 
> Wentong Wu (1):
>    ACPI: scan: Defer enumeration of devices with a _DEP pointing to IVSC
>      device
> 
>   drivers/acpi/scan.c                  |  1 +
>   drivers/media/pci/intel/ipu-bridge.c | 19 +++++++
>   drivers/misc/mei/platform-vsc.c      | 17 +++++-
>   drivers/misc/mei/vsc-tp.c            | 84 +++++++++++++++++++---------
>   drivers/misc/mei/vsc-tp.h            |  3 +
>   5 files changed, 98 insertions(+), 26 deletions(-)
> 

Synced to oracular:linux-unstable. Thanks.

-Stefan