mbox series

[M,0/2] fix keyboard lost on 6.5 kernel

Message ID 20240417073038.437869-1-aaron.ma@canonical.com
Headers show
Series fix keyboard lost on 6.5 kernel | expand

Message

Aaron Ma April 17, 2024, 7:30 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2060727

[Impact]
Keyboard is lost after updated to 6.5.0-27 and oem-6.5-1019 kernel
versions.

[Fix]
Regression commit is found commit:
936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in translated mode")

Fixes:
9cf6e24c9fbf1 Input: atkbd - do not skip atkbd_deactivate() when
skipping ATKBD_CMD_GETID
683cd8259a9b8 Input: atkbd - skip ATKBD_CMD_SETLEDS when skipping
ATKBD_CMD_GETID

[Test]
Tested on hardware, keyboard works fine after bootup.

[Where problems could occur]
It may break keyboard.

Hans de Goede (2):
  Input: atkbd - skip ATKBD_CMD_SETLEDS when skipping ATKBD_CMD_GETID
  Input: atkbd - do not skip atkbd_deactivate() when skipping
    ATKBD_CMD_GETID

 drivers/input/keyboard/atkbd.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

Comments

Magali Lemes April 18, 2024, 7:48 p.m. UTC | #1
Acked-by: Magali Lemes <magali.lemes@canonical.com>

On 17/04/2024 04:30, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2060727
> 
> [Impact]
> Keyboard is lost after updated to 6.5.0-27 and oem-6.5-1019 kernel
> versions.
> 
> [Fix]
> Regression commit is found commit:
> 936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in translated mode")
> 
> Fixes:
> 9cf6e24c9fbf1 Input: atkbd - do not skip atkbd_deactivate() when
> skipping ATKBD_CMD_GETID
> 683cd8259a9b8 Input: atkbd - skip ATKBD_CMD_SETLEDS when skipping
> ATKBD_CMD_GETID
> 
> [Test]
> Tested on hardware, keyboard works fine after bootup.
> 
> [Where problems could occur]
> It may break keyboard.
> 
> Hans de Goede (2):
>    Input: atkbd - skip ATKBD_CMD_SETLEDS when skipping ATKBD_CMD_GETID
>    Input: atkbd - do not skip atkbd_deactivate() when skipping
>      ATKBD_CMD_GETID
> 
>   drivers/input/keyboard/atkbd.c | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)
>
Guoqing Jiang April 19, 2024, 9:24 a.m. UTC | #2
On 4/17/24 15:30, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2060727
>
> [Impact]
> Keyboard is lost after updated to 6.5.0-27 and oem-6.5-1019 kernel
> versions.
>
> [Fix]
> Regression commit is found commit:
> 936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in translated mode")
>
> Fixes:
> 9cf6e24c9fbf1 Input: atkbd - do not skip atkbd_deactivate() when
> skipping ATKBD_CMD_GETID
> 683cd8259a9b8 Input: atkbd - skip ATKBD_CMD_SETLEDS when skipping
> ATKBD_CMD_GETID
>
> [Test]
> Tested on hardware, keyboard works fine after bootup.
>
> [Where problems could occur]
> It may break keyboard.
>
> Hans de Goede (2):
>    Input: atkbd - skip ATKBD_CMD_SETLEDS when skipping ATKBD_CMD_GETID
>    Input: atkbd - do not skip atkbd_deactivate() when skipping
>      ATKBD_CMD_GETID
>
>   drivers/input/keyboard/atkbd.c | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)

Acked-by: Guoqing Jiang <guoqing.jiang@canonical.com>
Roxana Nicolescu April 23, 2024, 7:08 a.m. UTC | #3
On 17/04/2024 09:30, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2060727
>
> [Impact]
> Keyboard is lost after updated to 6.5.0-27 and oem-6.5-1019 kernel
> versions.
>
> [Fix]
> Regression commit is found commit:
> 936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in translated mode")
>
> Fixes:
> 9cf6e24c9fbf1 Input: atkbd - do not skip atkbd_deactivate() when
> skipping ATKBD_CMD_GETID
> 683cd8259a9b8 Input: atkbd - skip ATKBD_CMD_SETLEDS when skipping
> ATKBD_CMD_GETID
>
> [Test]
> Tested on hardware, keyboard works fine after bootup.
>
> [Where problems could occur]
> It may break keyboard.
>
> Hans de Goede (2):
>    Input: atkbd - skip ATKBD_CMD_SETLEDS when skipping ATKBD_CMD_GETID
>    Input: atkbd - do not skip atkbd_deactivate() when skipping
>      ATKBD_CMD_GETID
>
>   drivers/input/keyboard/atkbd.c | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)
>
First commit was already applied. See lp2059991.

Applied to mantic master-next branch. Thanks!