From patchwork Tue Apr 16 06:04:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hui Wang X-Patchwork-Id: 1923999 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VJYSD0Jwwz1yZh for ; Tue, 16 Apr 2024 16:05:47 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rwbwk-000418-PQ; Tue, 16 Apr 2024 06:05:34 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rwbwi-0003zk-IF for kernel-team@lists.ubuntu.com; Tue, 16 Apr 2024 06:05:32 +0000 Received: from hwang4-ThinkPad-T14s-Gen-2a.conference (1.general.hwang4.uk.vpn [10.172.195.16]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 69D1F3F077 for ; Tue, 16 Apr 2024 06:05:31 +0000 (UTC) From: Hui Wang To: kernel-team@lists.ubuntu.com Subject: [SRU][Noble][PATCH 0/8] Fix panel flickering issue when i915.psr2 is enabled Date: Tue, 16 Apr 2024 14:04:08 +0800 Message-Id: <20240416060416.18571-1-hui.wang@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2046315 [Impact] In Dell oem project, we found the graphic is flickering on some machines, finally we narrowed down the issue on (some specific panels + i915.psr2 enabled), and the issue was reported to Intel, Intel fixed the issue in the most recent mainline kernel. Here backporting the patches to Noble kernel. It is hard to backport the patches to mantic and oem-6.5, so we wrote a workaround patch to disable the psr2 for those pannels in the oem-6.5. https://gitlab.freedesktop.org/drm/intel/-/issues/9739 [Fix] cherry-pick 8 patches from mainline kernel [Test] I applied the patches to Noble kernel and built a testing kernel, and Dell validated the testing kernel on those machines, the graphic didn't flicker anymore. I installed the testing kernel on some machines with Intel 13th, 12th 11th and 10th gen cpu, the grahic worked well too. [Where problems could occur] This patchset changes the fast wake settings for some gpu, it is possible to make the graphic flicker, but this possibility is very low, since the patchset comes from mainline kernel and we validated the patchset on different gens of Intel cpus. Jouni Högander (8): drm/i915/alpm: Add ALPM register definitions drm/i915/psr: Add alpm_parameters struct drm/i915/alpm: Calculate ALPM Entry check drm/i915/alpm: Alpm aux wake configuration for lnl drm/i915/display: Make intel_dp_aux_fw_sync_len available for PSR code drm/i915/psr: Improve fast and IO wake lines calculation drm/i915/psr: Calculate IO wake and fast wake lines for DISPLAY_VER < 12 drm/i915/display: Increase number of fast wake precharge pulses .../drm/i915/display/intel_display_types.h | 11 +- drivers/gpu/drm/i915/display/intel_dp_aux.c | 10 +- drivers/gpu/drm/i915/display/intel_dp_aux.h | 1 + drivers/gpu/drm/i915/display/intel_psr.c | 118 ++++++++++++++---- drivers/gpu/drm/i915/display/intel_psr_regs.h | 57 +++++++++ 5 files changed, 170 insertions(+), 27 deletions(-) Acked-by: Timo Aaltonen Acked-by: Guoqing Jiang