mbox series

[SRU,mantic:linux,0/1] x86: performance: tsc: Extend watchdog check exemption to 4-Sockets platform

Message ID 20240227141037.1744821-1-philip.cox@canonical.com
Headers show
Series x86: performance: tsc: Extend watchdog check exemption to 4-Sockets platform | expand

Message

Philip Cox Feb. 27, 2024, 2:10 p.m. UTC
BugLink: BugLink: https://bugs.launchpad.net/bugs/2054699

SRU Justification:

[Impact]
Fix tsc clocksource on 4 sockets x86 servers was wrongly
judged as 'unstable' by 'jiffies' and other watchdogs,
and disabled

[Fix]
cherry-pick
    233756a640be x86/tsc: Extend watchdog check exemption to 4-Sockets platform
from upstream fixes this

[Test Plan]
This has been tested by intel, and has been upstreamed for a while.

[Where problems could occur]
This is a fairly narrow change, and extends a behaviour
correction to cover up to 4-socket machines, rather
than just 2 socket machines

--



Feng Tang (1):
  x86/tsc: Extend watchdog check exemption to 4-Sockets platform

 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacob Martin Feb. 27, 2024, 3:27 p.m. UTC | #1
Acked-by: Jacob Martin <jacob.martin@canonical.com>

On 2/27/24 8:10 AM, Philip Cox wrote:
> 
> BugLink: BugLink: https://bugs.launchpad.net/bugs/2054699
> 
> SRU Justification:
> 
> [Impact]
> Fix tsc clocksource on 4 sockets x86 servers was wrongly
> judged as 'unstable' by 'jiffies' and other watchdogs,
> and disabled
> 
> [Fix]
> cherry-pick
>      233756a640be x86/tsc: Extend watchdog check exemption to 4-Sockets platform
> from upstream fixes this
> 
> [Test Plan]
> This has been tested by intel, and has been upstreamed for a while.
> 
> [Where problems could occur]
> This is a fairly narrow change, and extends a behaviour
> correction to cover up to 4-socket machines, rather
> than just 2 socket machines
> 
> --
> 
> 
> 
> Feng Tang (1):
>    x86/tsc: Extend watchdog check exemption to 4-Sockets platform
> 
>   arch/x86/kernel/tsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
Kevin Becker Feb. 28, 2024, 6:33 p.m. UTC | #2
Acked-by: Kevin Becker <kevin.becker@canonical.com>

On Tue, Feb 27, 2024 at 9:13 AM Philip Cox <philip.cox@canonical.com> wrote:
>
>
> BugLink: BugLink: https://bugs.launchpad.net/bugs/2054699
>
> SRU Justification:
>
> [Impact]
> Fix tsc clocksource on 4 sockets x86 servers was wrongly
> judged as 'unstable' by 'jiffies' and other watchdogs,
> and disabled
>
> [Fix]
> cherry-pick
>     233756a640be x86/tsc: Extend watchdog check exemption to 4-Sockets platform
> from upstream fixes this
>
> [Test Plan]
> This has been tested by intel, and has been upstreamed for a while.
>
> [Where problems could occur]
> This is a fairly narrow change, and extends a behaviour
> correction to cover up to 4-socket machines, rather
> than just 2 socket machines
>
> --
>
>
>
> Feng Tang (1):
>   x86/tsc: Extend watchdog check exemption to 4-Sockets platform
>
>  arch/x86/kernel/tsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.34.1
Stefan Bader Feb. 29, 2024, 4:51 p.m. UTC | #3
On 27.02.24 15:10, Philip Cox wrote:
> 
> BugLink: BugLink: https://bugs.launchpad.net/bugs/2054699
> 
> SRU Justification:
> 
> [Impact]
> Fix tsc clocksource on 4 sockets x86 servers was wrongly
> judged as 'unstable' by 'jiffies' and other watchdogs,
> and disabled
> 
> [Fix]
> cherry-pick
>      233756a640be x86/tsc: Extend watchdog check exemption to 4-Sockets platform
> from upstream fixes this
> 
> [Test Plan]
> This has been tested by intel, and has been upstreamed for a while.
> 
> [Where problems could occur]
> This is a fairly narrow change, and extends a behaviour
> correction to cover up to 4-socket machines, rather
> than just 2 socket machines
> 
> --
> 
> 
> 
> Feng Tang (1):
>    x86/tsc: Extend watchdog check exemption to 4-Sockets platform
> 
>   arch/x86/kernel/tsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to mantic:linux/master-next. Thanks.

-Stefan