From patchwork Thu Feb 1 03:40:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kai-Heng Feng X-Patchwork-Id: 1893777 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TQPpS4Dyqz23fD for ; Thu, 1 Feb 2024 14:41:35 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rVNx0-0006mq-8O; Thu, 01 Feb 2024 03:41:18 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rVNwu-0006mV-NC for kernel-team@lists.ubuntu.com; Thu, 01 Feb 2024 03:41:12 +0000 Received: from localhost.localdomain (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 33AB9400E4 for ; Thu, 1 Feb 2024 03:41:10 +0000 (UTC) From: Kai-Heng Feng To: kernel-team@lists.ubuntu.com Subject: [SRU] [M/N] [PATCH 0/3] Fix spurious wakeup caused by Cirque touchpad Date: Thu, 1 Feb 2024 11:40:24 +0800 Message-Id: <20240201034027.406374-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2051896 [Impact] Spurious wakeup event caused by Cirque touchpad, prevent the system from sleep properly. [Fix] Skip SET_POWER SLEEP so there won't be any IRQ raised by the touchpad. [Test] Suspend the system 100 times and make sure non of the wakeup event is caused by the touchpad and its IRQ line. [Where problems could occur] Logically the power consumption can increase slightly, but in reality there isn't any noticeable change. Since the quirk only applies to one device, there isn't much regression risk. Hans de Goede (2): HID: i2c-hid: Remove I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV quirk HID: i2c-hid: Renumber I2C_HID_QUIRK_ defines Kai-Heng Feng (1): HID: i2c-hid: Skip SET_POWER SLEEP for Cirque touchpad on system suspend drivers/hid/hid-ids.h | 3 +++ drivers/hid/i2c-hid/i2c-hid-core.c | 22 +++++++++++----------- 2 files changed, 14 insertions(+), 11 deletions(-) Acked-by: Andrei Gherzan Acked-by: Tim Gardner