mbox series

[SRU,M/N,0/1] Add support of MTL audio of Lenovo

Message ID 20240104123304.8881-1-aaron.ma@canonical.com
Headers show
Series Add support of MTL audio of Lenovo | expand

Message

Aaron Ma Jan. 4, 2024, 12:33 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2048078

[Impact]
On Lenovo ThinkPad MTL platform, the audio and mic are not working.
Error Logs:
[ 22.098899] sof-audio-pci-intel-mtl 0000:00:1f.3: no llp found, fall
back to default HDA path
[ 22.107925] sof-audio-pci-intel-mtl 0000:00:1f.3: no matching blob for
sample rate: 48000 sample width: 32 channels: 2
[ 22.107931] sof-audio-pci-intel-mtl 0000:00:1f.3: failed to prepare
widget dai-copier.DMIC.dmic01.capture
[ 22.107933] sof-audio-pci-intel-mtl 0000:00:1f.3: Failed to prepare
connected widgets
[ 22.107935] sof-audio-pci-intel-mtl 0000:00:1f.3: error: failed widget
list set up for pcm 6 dir 1
[ 22.107937] sof-audio-pci-intel-mtl 0000:00:1f.3: ASoC: error at
snd_soc_pcm_component_hw_params on 0000:00:1f.3: -22

[Fix]
Commit:
"ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format"
Add support of both 24 bit and 32 bit of DMIC hardware.

[Test]
Tested on hardware, sound ouput and DMIC input work fine.

[Where problems could occur]
It may break sound driver.

MTL is not supported by 5.15 and 6.2 kernel, SRU for oem-6.5, 6.5 and
6.6.

Peter Ujfalusi (1):
  ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format

 sound/hda/intel-nhlt.c | 33 +++++++++++++++++++++++++++++----
 1 file changed, 29 insertions(+), 4 deletions(-)

Comments

Andrei Gherzan Jan. 4, 2024, 2:57 p.m. UTC | #1
On 24/01/04 08:33PM, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2048078
> 
> [Impact]
> On Lenovo ThinkPad MTL platform, the audio and mic are not working.
> Error Logs:
> [ 22.098899] sof-audio-pci-intel-mtl 0000:00:1f.3: no llp found, fall
> back to default HDA path
> [ 22.107925] sof-audio-pci-intel-mtl 0000:00:1f.3: no matching blob for
> sample rate: 48000 sample width: 32 channels: 2
> [ 22.107931] sof-audio-pci-intel-mtl 0000:00:1f.3: failed to prepare
> widget dai-copier.DMIC.dmic01.capture
> [ 22.107933] sof-audio-pci-intel-mtl 0000:00:1f.3: Failed to prepare
> connected widgets
> [ 22.107935] sof-audio-pci-intel-mtl 0000:00:1f.3: error: failed widget
> list set up for pcm 6 dir 1
> [ 22.107937] sof-audio-pci-intel-mtl 0000:00:1f.3: ASoC: error at
> snd_soc_pcm_component_hw_params on 0000:00:1f.3: -22
> 
> [Fix]
> Commit:
> "ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format"
> Add support of both 24 bit and 32 bit of DMIC hardware.
> 
> [Test]
> Tested on hardware, sound ouput and DMIC input work fine.
> 
> [Where problems could occur]
> It may break sound driver.
> 
> MTL is not supported by 5.15 and 6.2 kernel, SRU for oem-6.5, 6.5 and
> 6.6.
> 
> Peter Ujfalusi (1):
>   ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format
> 
>  sound/hda/intel-nhlt.c | 33 +++++++++++++++++++++++++++++----
>  1 file changed, 29 insertions(+), 4 deletions(-)

This commit landed in v6.7-rc4 with no known regressions.

It is a bit confusing that the LP bug includes Jammy for linux as a
target series (set on invalid). I know why we did that, but it is still
confusing.

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Tim Gardner Jan. 4, 2024, 4:14 p.m. UTC | #2
On 1/4/24 5:33 AM, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2048078
> 
> [Impact]
> On Lenovo ThinkPad MTL platform, the audio and mic are not working.
> Error Logs:
> [ 22.098899] sof-audio-pci-intel-mtl 0000:00:1f.3: no llp found, fall
> back to default HDA path
> [ 22.107925] sof-audio-pci-intel-mtl 0000:00:1f.3: no matching blob for
> sample rate: 48000 sample width: 32 channels: 2
> [ 22.107931] sof-audio-pci-intel-mtl 0000:00:1f.3: failed to prepare
> widget dai-copier.DMIC.dmic01.capture
> [ 22.107933] sof-audio-pci-intel-mtl 0000:00:1f.3: Failed to prepare
> connected widgets
> [ 22.107935] sof-audio-pci-intel-mtl 0000:00:1f.3: error: failed widget
> list set up for pcm 6 dir 1
> [ 22.107937] sof-audio-pci-intel-mtl 0000:00:1f.3: ASoC: error at
> snd_soc_pcm_component_hw_params on 0000:00:1f.3: -22
> 
> [Fix]
> Commit:
> "ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format"
> Add support of both 24 bit and 32 bit of DMIC hardware.
> 
> [Test]
> Tested on hardware, sound ouput and DMIC input work fine.
> 
> [Where problems could occur]
> It may break sound driver.
> 
> MTL is not supported by 5.15 and 6.2 kernel, SRU for oem-6.5, 6.5 and
> 6.6.
> 
> Peter Ujfalusi (1):
>    ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format
> 
>   sound/hda/intel-nhlt.c | 33 +++++++++++++++++++++++++++++----
>   1 file changed, 29 insertions(+), 4 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Roxana Nicolescu Jan. 4, 2024, 7:50 p.m. UTC | #3
On 04/01/2024 13:33, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2048078
>
> [Impact]
> On Lenovo ThinkPad MTL platform, the audio and mic are not working.
> Error Logs:
> [ 22.098899] sof-audio-pci-intel-mtl 0000:00:1f.3: no llp found, fall
> back to default HDA path
> [ 22.107925] sof-audio-pci-intel-mtl 0000:00:1f.3: no matching blob for
> sample rate: 48000 sample width: 32 channels: 2
> [ 22.107931] sof-audio-pci-intel-mtl 0000:00:1f.3: failed to prepare
> widget dai-copier.DMIC.dmic01.capture
> [ 22.107933] sof-audio-pci-intel-mtl 0000:00:1f.3: Failed to prepare
> connected widgets
> [ 22.107935] sof-audio-pci-intel-mtl 0000:00:1f.3: error: failed widget
> list set up for pcm 6 dir 1
> [ 22.107937] sof-audio-pci-intel-mtl 0000:00:1f.3: ASoC: error at
> snd_soc_pcm_component_hw_params on 0000:00:1f.3: -22
>
> [Fix]
> Commit:
> "ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format"
> Add support of both 24 bit and 32 bit of DMIC hardware.
>
> [Test]
> Tested on hardware, sound ouput and DMIC input work fine.
>
> [Where problems could occur]
> It may break sound driver.
>
> MTL is not supported by 5.15 and 6.2 kernel, SRU for oem-6.5, 6.5 and
> 6.6.
>
> Peter Ujfalusi (1):
>    ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format
>
>   sound/hda/intel-nhlt.c | 33 +++++++++++++++++++++++++++++----
>   1 file changed, 29 insertions(+), 4 deletions(-)
>
Applied to mantic master-next branch. Thanks!
Stefan Bader Jan. 12, 2024, 9:51 a.m. UTC | #4
On 04.01.24 13:33, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2048078
> 
> [Impact]
> On Lenovo ThinkPad MTL platform, the audio and mic are not working.
> Error Logs:
> [ 22.098899] sof-audio-pci-intel-mtl 0000:00:1f.3: no llp found, fall
> back to default HDA path
> [ 22.107925] sof-audio-pci-intel-mtl 0000:00:1f.3: no matching blob for
> sample rate: 48000 sample width: 32 channels: 2
> [ 22.107931] sof-audio-pci-intel-mtl 0000:00:1f.3: failed to prepare
> widget dai-copier.DMIC.dmic01.capture
> [ 22.107933] sof-audio-pci-intel-mtl 0000:00:1f.3: Failed to prepare
> connected widgets
> [ 22.107935] sof-audio-pci-intel-mtl 0000:00:1f.3: error: failed widget
> list set up for pcm 6 dir 1
> [ 22.107937] sof-audio-pci-intel-mtl 0000:00:1f.3: ASoC: error at
> snd_soc_pcm_component_hw_params on 0000:00:1f.3: -22
> 
> [Fix]
> Commit:
> "ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format"
> Add support of both 24 bit and 32 bit of DMIC hardware.
> 
> [Test]
> Tested on hardware, sound ouput and DMIC input work fine.
> 
> [Where problems could occur]
> It may break sound driver.
> 
> MTL is not supported by 5.15 and 6.2 kernel, SRU for oem-6.5, 6.5 and
> 6.6.
> 
> Peter Ujfalusi (1):
>    ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format
> 
>   sound/hda/intel-nhlt.c | 33 +++++++++++++++++++++++++++++----
>   1 file changed, 29 insertions(+), 4 deletions(-)
> 

Rejected for the following reasons:
- Already included with Noble after 6.7 transition.

-Stefan