| Message ID | 20240102142128.157022-1-limings@nvidia.com |
|---|---|
| Headers | show |
| Series | mmc: sdhci-of-dwcmshc: Replace sauce patches with upstream commits | expand |
Hi, On Tue, Jan 2, 2024 at 3:26 PM Liming Sun <limings@nvidia.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/2046657 > > SRU Justification: > > [Impact] > The msdhci-of-dwcmshc driver in the Jammy repo > consists of some SAUCE patches. These need to be replaced. > > [Fix] > The fix is to revert the four SAUCE patches, replacing them with > upstream commits for the same functionality. > > [Test Case] > * Boot BF3 platform, verify no new errors > > [Regression Potential] > The upstream commits are not exactly the same as the SAUCE patches, > so technically there is a chance of regression, but its been > well-tested and the functionality is the same. > > [Other] > n/a > > Liming Sun (7): > [SRU][J:linux-bluefield] Revert UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: > Add runtime PM operations for BlueField-3 > [SRU][J:linux-bluefield] Revert UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: > add the missing device table IDs for acpi > [SRU][J:linux-bluefield] Revert UBUNTU: SAUCE: sdhci-of-dwcmshc: > Enable host V4 support for BlueField-3 SoC > [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: enable host V4 support > for BlueField-3 SoC > [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: add the missing device > table IDs for acpi > [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: Add error handling in > dwcmshc_resume > [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: Add runtime PM > operations > > drivers/mmc/host/sdhci-of-dwcmshc.c | 124 ++++++++++++---------------- > 1 file changed, 52 insertions(+), 72 deletions(-) > Every patch that is processed by you should contain your Signed-off-by: line (including reverts) and patches that are cherry picks / backports from the upstream should contain corresponding information (please check "-s" and "-x" parameters for "git cherry-pick"). Please also use "[SRU][J:linux-bluefield][PATCH ...]" format instead of "[PATCH ...] [SRU][J:linux-bluefield]" one for the email subject for all patches in the submission. -- Best regards, Bartlomiej
Thanks! Posted v3 to address these comments. > -----Original Message----- > From: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com> > Sent: Wednesday, January 3, 2024 9:49 AM > To: Liming Sun <limings@nvidia.com> > Cc: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>; David Thompson > <davthompson@nvidia.com> > Subject: NAK/Cmnt: [SRU][J:linux-bluefield][PATCH v2 0/7] mmc: sdhci-of- > dwcmshc: Replace sauce patches with upstream commits > > Hi, > > On Tue, Jan 2, 2024 at 3:26 PM Liming Sun <limings@nvidia.com> wrote: > > > > BugLink: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbug > s.launchpad.net%2Fbugs%2F2046657&data=05%7C02%7Climings%40nvidia > .com%7C92bab8d2ec9341628d4908dc0c6b19de%7C43083d15727340c1b > 7db39efd9ccc17a%7C0%7C0%7C638398901348977246%7CUnknown%7CT > WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pAy9APaDApisYZOB8ZS8eW > BYOKCCEpUd6%2Fb3mhVR378%3D&reserved=0 > > > > SRU Justification: > > > > [Impact] > > The msdhci-of-dwcmshc driver in the Jammy repo > > consists of some SAUCE patches. These need to be replaced. > > > > [Fix] > > The fix is to revert the four SAUCE patches, replacing them with > > upstream commits for the same functionality. > > > > [Test Case] > > * Boot BF3 platform, verify no new errors > > > > [Regression Potential] > > The upstream commits are not exactly the same as the SAUCE patches, > > so technically there is a chance of regression, but its been > > well-tested and the functionality is the same. > > > > [Other] > > n/a > > > > Liming Sun (7): > > [SRU][J:linux-bluefield] Revert UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: > > Add runtime PM operations for BlueField-3 > > [SRU][J:linux-bluefield] Revert UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: > > add the missing device table IDs for acpi > > [SRU][J:linux-bluefield] Revert UBUNTU: SAUCE: sdhci-of-dwcmshc: > > Enable host V4 support for BlueField-3 SoC > > [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: enable host V4 support > > for BlueField-3 SoC > > [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: add the missing device > > table IDs for acpi > > [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: Add error handling in > > dwcmshc_resume > > [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: Add runtime PM > > operations > > > > drivers/mmc/host/sdhci-of-dwcmshc.c | 124 ++++++++++++---------------- > > 1 file changed, 52 insertions(+), 72 deletions(-) > > > > Every patch that is processed by you should contain your > Signed-off-by: line (including reverts) and patches that are cherry > picks / backports from the upstream should contain corresponding > information (please check "-s" and "-x" parameters for "git > cherry-pick"). > > Please also use "[SRU][J:linux-bluefield][PATCH ...]" format instead > of "[PATCH ...] [SRU][J:linux-bluefield]" one for the email subject > for all patches in the submission. > > -- > Best regards, > Bartlomiej
BugLink: https://bugs.launchpad.net/bugs/2046657 SRU Justification: [Impact] The msdhci-of-dwcmshc driver in the Jammy repo consists of some SAUCE patches. These need to be replaced. [Fix] The fix is to revert the four SAUCE patches, replacing them with upstream commits for the same functionality. [Test Case] * Boot BF3 platform, verify no new errors [Regression Potential] The upstream commits are not exactly the same as the SAUCE patches, so technically there is a chance of regression, but its been well-tested and the functionality is the same. [Other] n/a Liming Sun (7): [SRU][J:linux-bluefield] Revert UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: Add runtime PM operations for BlueField-3 [SRU][J:linux-bluefield] Revert UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: add the missing device table IDs for acpi [SRU][J:linux-bluefield] Revert UBUNTU: SAUCE: sdhci-of-dwcmshc: Enable host V4 support for BlueField-3 SoC [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: enable host V4 support for BlueField-3 SoC [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: add the missing device table IDs for acpi [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: Add error handling in dwcmshc_resume [SRU][J:linux-bluefield] mmc: sdhci-of-dwcmshc: Add runtime PM operations drivers/mmc/host/sdhci-of-dwcmshc.c | 124 ++++++++++++---------------- 1 file changed, 52 insertions(+), 72 deletions(-)