| Message ID | 20231108115901.20049-1-philip.cox@canonical.com |
|---|---|
| Headers | show |
| Series | drm/ast: Add BMC virtual connector | expand |
On 11/8/23 13:59, Philip Cox wrote: > > BugLink: https://bugs.launchpad.net/bugs/2042850 > > SRU Justification: > > [Impact] > On systems with Aspeed 2600 revision 52 GPUs, the display fails to progress to the login prompt. With the commit (added in 6.5.0-6.6) > > commit: 916ae609a033cbb55661905d310ba2358b7621ea > Author: Jocelyn Falempe <jfalempe@redhat.com> > Date: Thu Jul 13 15:41:31 2023 +0200 > Subject: drm/ast: report connection status on Display Port. > > the Aspeed 2600 rev 52 GPUs have issues. > > They need the commit: > > This change was dependant on the upstream change > commit e329cb53b45da475966c4b2e49f6a4a430f307fa > Author: Jocelyn Falempe <jfalempe@redhat.com> > Date: Thu Jul 13 15:41:30 2023 +0200 > Subject: drm/ast: Add BMC virtual connector > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e329cb53b45da475966c4b2e49f6a4a430f307fa > > > in order to have the display work correctly on the rev52 GPUs. > > > > [Fix] > With cherry-picking this change, the functionality of BMCs using Aspeed 2600 rev52 GPUs work as expected, as they did prior to the regression in 6.5.0-6.6. > > [Test Plan] > I have tested this on multiple versions of Aspeed 2600 GPU enabled BMCs, and the revision 52 systems that required the nomodeset option to boot to the prompt, now boot fine and display the login prompt, and there is no regression on the other systems. I have tested this on different Aspeed GPUs, and have not seen any regressions, or unexpected behaviour. > > > [Where problems could occur] > As this fixes a regression of functionality for the mantic kernel's Aspeed GPU driver on a very specific version of some BMCs to the state it was was in the mantic 6.5.0-5.5 kernel, I think there is little room for regressions. > > --- > > Jocelyn Falempe (1): > drm/ast: Add BMC virtual connector > > drivers/gpu/drm/ast/ast_drv.h | 4 +++ > drivers/gpu/drm/ast/ast_mode.c | 57 ++++++++++++++++++++++++++++++++++ > 2 files changed, 61 insertions(+) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
On Wed, Nov 08, 2023 at 01:59:00PM +0200, Philip Cox wrote: > > BugLink: https://bugs.launchpad.net/bugs/2042850 > > SRU Justification: > > [Impact] > On systems with Aspeed 2600 revision 52 GPUs, the display fails to progress to the login prompt. With the commit (added in 6.5.0-6.6) > > commit: 916ae609a033cbb55661905d310ba2358b7621ea > Author: Jocelyn Falempe <jfalempe@redhat.com> > Date: Thu Jul 13 15:41:31 2023 +0200 > Subject: drm/ast: report connection status on Display Port. > > the Aspeed 2600 rev 52 GPUs have issues. > > They need the commit: > > This change was dependant on the upstream change > commit e329cb53b45da475966c4b2e49f6a4a430f307fa > Author: Jocelyn Falempe <jfalempe@redhat.com> > Date: Thu Jul 13 15:41:30 2023 +0200 > Subject: drm/ast: Add BMC virtual connector > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e329cb53b45da475966c4b2e49f6a4a430f307fa > > > in order to have the display work correctly on the rev52 GPUs. > > > > [Fix] > With cherry-picking this change, the functionality of BMCs using Aspeed 2600 rev52 GPUs work as expected, as they did prior to the regression in 6.5.0-6.6. > > [Test Plan] > I have tested this on multiple versions of Aspeed 2600 GPU enabled BMCs, and the revision 52 systems that required the nomodeset option to boot to the prompt, now boot fine and display the login prompt, and there is no regression on the other systems. I have tested this on different Aspeed GPUs, and have not seen any regressions, or unexpected behaviour. > > > [Where problems could occur] > As this fixes a regression of functionality for the mantic kernel's Aspeed GPU driver on a very specific version of some BMCs to the state it was was in the mantic 6.5.0-5.5 kernel, I think there is little room for regressions. Looks good, thanks for fixing this! Acked-by: Andrea Righi <andrea.righi@canonical.com>
On 08/11/2023 12:59, Philip Cox wrote: > BugLink: https://bugs.launchpad.net/bugs/2042850 > > SRU Justification: > > [Impact] > On systems with Aspeed 2600 revision 52 GPUs, the display fails to progress to the login prompt. With the commit (added in 6.5.0-6.6) > > commit: 916ae609a033cbb55661905d310ba2358b7621ea > Author: Jocelyn Falempe <jfalempe@redhat.com> > Date: Thu Jul 13 15:41:31 2023 +0200 > Subject: drm/ast: report connection status on Display Port. > > the Aspeed 2600 rev 52 GPUs have issues. > > They need the commit: > > This change was dependant on the upstream change > commit e329cb53b45da475966c4b2e49f6a4a430f307fa > Author: Jocelyn Falempe <jfalempe@redhat.com> > Date: Thu Jul 13 15:41:30 2023 +0200 > Subject: drm/ast: Add BMC virtual connector > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e329cb53b45da475966c4b2e49f6a4a430f307fa > > > in order to have the display work correctly on the rev52 GPUs. > > > > [Fix] > With cherry-picking this change, the functionality of BMCs using Aspeed 2600 rev52 GPUs work as expected, as they did prior to the regression in 6.5.0-6.6. > > [Test Plan] > I have tested this on multiple versions of Aspeed 2600 GPU enabled BMCs, and the revision 52 systems that required the nomodeset option to boot to the prompt, now boot fine and display the login prompt, and there is no regression on the other systems. I have tested this on different Aspeed GPUs, and have not seen any regressions, or unexpected behaviour. > > > [Where problems could occur] > As this fixes a regression of functionality for the mantic kernel's Aspeed GPU driver on a very specific version of some BMCs to the state it was was in the mantic 6.5.0-5.5 kernel, I think there is little room for regressions. > > --- > > Jocelyn Falempe (1): > drm/ast: Add BMC virtual connector > > drivers/gpu/drm/ast/ast_drv.h | 4 +++ > drivers/gpu/drm/ast/ast_mode.c | 57 ++++++++++++++++++++++++++++++++++ > 2 files changed, 61 insertions(+) > Applied to mantic:master-next. Thanks! Roxana