mbox series

[SRU,focal-gcp,v2,0/1] Incorrect argument from SEV live-migration fix

Message ID 20231025182652.143307-1-john.cabaj@canonical.com
Headers show
Series Incorrect argument from SEV live-migration fix | expand

Message

John Cabaj Oct. 25, 2023, 6:26 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2040337

[Impact]

* Google requested fix to notify_range_enc_status_changed() passing incorrect argument.

[Fix]

* Upstream ac3f9c9f1b37 introduced change to notify_range_enc_status_changed() to accept page size instead of number of pages, but function was not updated. Updating to send correct argument. Upstream implementation changed with TDX
support, and is unaffected, so no plans to upstream.

[Test Case]

* Compile tested
* Boot tested
* Tested by Google

[Where things could go wrong]

* Low chance of regression. Isolated logic fix.

v2:
* 5.15 kernel had a refactor, so applying patches to previous source for 5.4

John Cabaj (1):
  UBUNTU: SAUCE: (no-up) x86/mm: Fixing notify_range_enc_status_changed
    incorrect argument

 arch/x86/mm/mem_encrypt.c | 2 +-
 arch/x86/mm/pageattr.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Tim Gardner Oct. 27, 2023, 2:17 p.m. UTC | #1
On 10/25/23 12:26 PM, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2040337
> 
> [Impact]
> 
> * Google requested fix to notify_range_enc_status_changed() passing incorrect argument.
> 
> [Fix]
> 
> * Upstream ac3f9c9f1b37 introduced change to notify_range_enc_status_changed() to accept page size instead of number of pages, but function was not updated. Updating to send correct argument. Upstream implementation changed with TDX
> support, and is unaffected, so no plans to upstream.
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * Tested by Google
> 
> [Where things could go wrong]
> 
> * Low chance of regression. Isolated logic fix.
> 
> v2:
> * 5.15 kernel had a refactor, so applying patches to previous source for 5.4
> 
> John Cabaj (1):
>    UBUNTU: SAUCE: (no-up) x86/mm: Fixing notify_range_enc_status_changed
>      incorrect argument
> 
>   arch/x86/mm/mem_encrypt.c | 2 +-
>   arch/x86/mm/pageattr.c    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Ian May Oct. 27, 2023, 3:42 p.m. UTC | #2
Acked-by: Ian May <ian.may@canonical.com>

On 2023-10-25 13:26:51 , John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2040337
> 
> [Impact]
> 
> * Google requested fix to notify_range_enc_status_changed() passing incorrect argument.
> 
> [Fix]
> 
> * Upstream ac3f9c9f1b37 introduced change to notify_range_enc_status_changed() to accept page size instead of number of pages, but function was not updated. Updating to send correct argument. Upstream implementation changed with TDX
> support, and is unaffected, so no plans to upstream.
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * Tested by Google
> 
> [Where things could go wrong]
> 
> * Low chance of regression. Isolated logic fix.
> 
> v2:
> * 5.15 kernel had a refactor, so applying patches to previous source for 5.4
> 
> John Cabaj (1):
>   UBUNTU: SAUCE: (no-up) x86/mm: Fixing notify_range_enc_status_changed
>     incorrect argument
> 
>  arch/x86/mm/mem_encrypt.c | 2 +-
>  arch/x86/mm/pageattr.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
John Cabaj Oct. 27, 2023, 6:25 p.m. UTC | #3
On 10/25/23 1:26 PM, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2040337
> 
> [Impact]
> 
> * Google requested fix to notify_range_enc_status_changed() passing incorrect argument.
> 
> [Fix]
> 
> * Upstream ac3f9c9f1b37 introduced change to notify_range_enc_status_changed() to accept page size instead of number of pages, but function was not updated. Updating to send correct argument. Upstream implementation changed with TDX
> support, and is unaffected, so no plans to upstream.
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * Tested by Google
> 
> [Where things could go wrong]
> 
> * Low chance of regression. Isolated logic fix.
> 
> v2:
> * 5.15 kernel had a refactor, so applying patches to previous source for 5.4
> 
> John Cabaj (1):
>   UBUNTU: SAUCE: (no-up) x86/mm: Fixing notify_range_enc_status_changed
>     incorrect argument
> 
>  arch/x86/mm/mem_encrypt.c | 2 +-
>  arch/x86/mm/pageattr.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Applied to focal:linux-gcp master-next branch.


Thanks,
John